From: Icenowy Zheng <icenowy@aosc.io> To: wens@kernel.org, Chen-Yu Tsai <wens@csie.org> Cc: Maxime Ripard <mripard@kernel.org>, Jernej Skrabec <jernej.skrabec@siol.net>, devicetree <devicetree@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, inux-kernel@vger.kernel.org, linux-sunxi <linux-sunxi@googlegroups.com> Subject: Re: [linux-sunxi] [PATCH 2/3] ARM: dts: sun8i: v3s: enable EHCI/OHCI for Lichee Pi Zero Date: Mon, 23 Nov 2020 18:21:51 +0800 [thread overview] Message-ID: <4FF2364F-76AE-4181-88BB-02AB95424DD4@aosc.io> (raw) In-Reply-To: <CAGb2v64f71Dv6cp4ObhMTyMELRNP6h524-cg4h07MNRhsz_MSA@mail.gmail.com> 于 2020年11月23日 GMT+08:00 上午11:37:43, Chen-Yu Tsai <wens@csie.org> 写到: >On Sun, Nov 22, 2020 at 8:40 AM Icenowy Zheng <icenowy@aosc.io> wrote: >> >> As the USB port on Lichee Pi Zero works in the OTG mode, enable the >> EHCI/OHCI controllers for it. > >You should probably mention that the host controllers work better >than the OTG controller in host mode. Otherwise this change lacks >justification for enabling two extra hardware blocks. Our PHY driver do not sense whether ?HCI is enabled or not, so for host to work it's necessary to be enabled, otherwise the phy driver will just route USB to unenabled ?HCI and fail. > >ChenYu > >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io> >> --- >> arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts >b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts >> index 2e4587d26ce5..0cd969194acb 100644 >> --- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts >> +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts >> @@ -77,6 +77,10 @@ red_led { >> }; >> }; >> >> +&ehci0 { >> + status = "okay"; >> +}; >> + >> &mmc0 { >> broken-cd; >> bus-width = <4>; >> @@ -84,6 +88,10 @@ &mmc0 { >> status = "okay"; >> }; >> >> +&ohci0 { >> + status = "okay"; >> +}; >> + >> &uart0 { >> pinctrl-0 = <&uart0_pb_pins>; >> pinctrl-names = "default"; >> -- >> 2.28.0 >> >> -- >> You received this message because you are subscribed to the Google >Groups "linux-sunxi" group. >> To unsubscribe from this group and stop receiving emails from it, >send an email to linux-sunxi+unsubscribe@googlegroups.com. >> To view this discussion on the web, visit >https://groups.google.com/d/msgid/linux-sunxi/20201122004011.1957325-1-icenowy%40aosc.io.
WARNING: multiple messages have this Message-ID (diff)
From: Icenowy Zheng <icenowy@aosc.io> To: wens@kernel.org,Chen-Yu Tsai <wens@csie.org> Cc: devicetree <devicetree@vger.kernel.org>, Jernej Skrabec <jernej.skrabec@siol.net>, inux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>, linux-sunxi <linux-sunxi@googlegroups.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [linux-sunxi] [PATCH 2/3] ARM: dts: sun8i: v3s: enable EHCI/OHCI for Lichee Pi Zero Date: Mon, 23 Nov 2020 18:21:51 +0800 [thread overview] Message-ID: <4FF2364F-76AE-4181-88BB-02AB95424DD4@aosc.io> (raw) In-Reply-To: <CAGb2v64f71Dv6cp4ObhMTyMELRNP6h524-cg4h07MNRhsz_MSA@mail.gmail.com> 于 2020年11月23日 GMT+08:00 上午11:37:43, Chen-Yu Tsai <wens@csie.org> 写到: >On Sun, Nov 22, 2020 at 8:40 AM Icenowy Zheng <icenowy@aosc.io> wrote: >> >> As the USB port on Lichee Pi Zero works in the OTG mode, enable the >> EHCI/OHCI controllers for it. > >You should probably mention that the host controllers work better >than the OTG controller in host mode. Otherwise this change lacks >justification for enabling two extra hardware blocks. Our PHY driver do not sense whether ?HCI is enabled or not, so for host to work it's necessary to be enabled, otherwise the phy driver will just route USB to unenabled ?HCI and fail. > >ChenYu > >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io> >> --- >> arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts >b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts >> index 2e4587d26ce5..0cd969194acb 100644 >> --- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts >> +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts >> @@ -77,6 +77,10 @@ red_led { >> }; >> }; >> >> +&ehci0 { >> + status = "okay"; >> +}; >> + >> &mmc0 { >> broken-cd; >> bus-width = <4>; >> @@ -84,6 +88,10 @@ &mmc0 { >> status = "okay"; >> }; >> >> +&ohci0 { >> + status = "okay"; >> +}; >> + >> &uart0 { >> pinctrl-0 = <&uart0_pb_pins>; >> pinctrl-names = "default"; >> -- >> 2.28.0 >> >> -- >> You received this message because you are subscribed to the Google >Groups "linux-sunxi" group. >> To unsubscribe from this group and stop receiving emails from it, >send an email to linux-sunxi+unsubscribe@googlegroups.com. >> To view this discussion on the web, visit >https://groups.google.com/d/msgid/linux-sunxi/20201122004011.1957325-1-icenowy%40aosc.io. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-23 10:22 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-22 0:38 [PATCH 0/3] ARM: dts: sun8i: v3s: enable EHCI/OHCI Icenowy Zheng 2020-11-22 0:38 ` Icenowy Zheng 2020-11-22 0:38 ` [PATCH 1/3] ARM: dts: sun8i: v3s: add EHCI/OHCI0 device nodes Icenowy Zheng 2020-11-22 0:38 ` Icenowy Zheng 2020-11-23 3:38 ` [linux-sunxi] " Chen-Yu Tsai 2020-11-23 3:38 ` Chen-Yu Tsai 2020-11-22 0:40 ` [PATCH 2/3] ARM: dts: sun8i: v3s: enable EHCI/OHCI for Lichee Pi Zero Icenowy Zheng 2020-11-22 0:40 ` Icenowy Zheng 2020-11-23 3:37 ` [linux-sunxi] " Chen-Yu Tsai 2020-11-23 3:37 ` Chen-Yu Tsai 2020-11-23 10:21 ` Icenowy Zheng [this message] 2020-11-23 10:21 ` Icenowy Zheng 2020-11-28 3:09 ` Chen-Yu Tsai 2020-11-28 3:09 ` Chen-Yu Tsai 2020-11-28 3:35 ` Icenowy Zheng 2020-11-28 3:35 ` Icenowy Zheng 2020-11-22 0:40 ` [PATCH 3/3] ARM: dts: sun8i: s3: switch PineCube to use OHCI/EHCI only Icenowy Zheng 2020-11-22 0:40 ` Icenowy Zheng 2020-11-23 3:29 ` [linux-sunxi] " Chen-Yu Tsai 2020-11-23 3:29 ` Chen-Yu Tsai 2020-11-23 11:43 ` Maxime Ripard 2020-11-23 11:43 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4FF2364F-76AE-4181-88BB-02AB95424DD4@aosc.io \ --to=icenowy@aosc.io \ --cc=devicetree@vger.kernel.org \ --cc=inux-kernel@vger.kernel.org \ --cc=jernej.skrabec@siol.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-sunxi@googlegroups.com \ --cc=mripard@kernel.org \ --cc=wens@csie.org \ --cc=wens@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.