From: "Breana, Tiberiu A" <tiberiu.a.breana@intel.com> To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Linus Walleij" <linus.walleij@linaro.org>, "Alexandre Courbot" <gnurou@gmail.com> Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "kernel@pengutronix.de" <kernel@pengutronix.de>, Jonathan Cameron <jic23@kernel.org>, Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald <pmeerw@pmeerw.net>, "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org> Subject: RE: [PATCH gpio-for-next 03/10] iio: light: stk3310: use flags argument of devm_gpiod_get Date: Mon, 6 Jul 2015 09:35:44 +0000 [thread overview] Message-ID: <4586F61A4A291F4DA44D32824E7C0F402216D8E5@IRSMSX109.ger.corp.intel.com> (raw) In-Reply-To: <1436173790-29963-3-git-send-email-u.kleine-koenig@pengutronix.de> > -----Original Message----- > From: Uwe Kleine-König [mailto:u.kleine-koenig@pengutronix.de] > Sent: Monday, July 6, 2015 12:10 PM > To: Linus Walleij; Alexandre Courbot > Cc: linux-gpio@vger.kernel.org; kernel@pengutronix.de; Breana, Tiberiu A; > Jonathan Cameron; Hartmut Knaack; Lars-Peter Clausen; Peter Meerwald; > linux-iio@vger.kernel.org > Subject: [PATCH gpio-for-next 03/10] iio: light: stk3310: use flags argument of > devm_gpiod_get > > Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions) > which appeared in v3.17-rc1, the gpiod_get* functions take an additional > parameter that allows to specify direction and initial value for output. > > Simplify driver accordingly. Furthermore this is one caller less that stops us > making the flags argument to gpiod_get*() mandatory. > > Acked-by: Jonathan Cameron <jic23@kernel.org> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> +1 Reviewed-by: Tiberiu Breana <tiberiu.a.breana@intel.com> > --- > drivers/iio/light/stk3310.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c index > fee4297d7c8f..84c77d42a2c6 100644 > --- a/drivers/iio/light/stk3310.c > +++ b/drivers/iio/light/stk3310.c > @@ -488,16 +488,12 @@ static int stk3310_gpio_probe(struct i2c_client > *client) > dev = &client->dev; > > /* gpio interrupt pin */ > - gpio = devm_gpiod_get_index(dev, STK3310_GPIO, 0); > + gpio = devm_gpiod_get_index(dev, STK3310_GPIO, 0, GPIOD_IN); > if (IS_ERR(gpio)) { > dev_err(dev, "acpi gpio get index failed\n"); > return PTR_ERR(gpio); > } > > - ret = gpiod_direction_input(gpio); > - if (ret) > - return ret; > - > ret = gpiod_to_irq(gpio); > dev_dbg(dev, "GPIO resource, no:%d irq:%d\n", desc_to_gpio(gpio), > ret); > > -- > 2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: "Breana, Tiberiu A" <tiberiu.a.breana@intel.com> To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Linus Walleij" <linus.walleij@linaro.org>, "Alexandre Courbot" <gnurou@gmail.com> Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "kernel@pengutronix.de" <kernel@pengutronix.de>, Jonathan Cameron <jic23@kernel.org>, Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald <pmeerw@pmeerw.net>, "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org> Subject: RE: [PATCH gpio-for-next 03/10] iio: light: stk3310: use flags argument of devm_gpiod_get Date: Mon, 6 Jul 2015 09:35:44 +0000 [thread overview] Message-ID: <4586F61A4A291F4DA44D32824E7C0F402216D8E5@IRSMSX109.ger.corp.intel.com> (raw) In-Reply-To: <1436173790-29963-3-git-send-email-u.kleine-koenig@pengutronix.de> PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBVd2UgS2xlaW5lLUvDtm5pZyBb bWFpbHRvOnUua2xlaW5lLWtvZW5pZ0BwZW5ndXRyb25peC5kZV0NCj4gU2VudDogTW9uZGF5LCBK dWx5IDYsIDIwMTUgMTI6MTAgUE0NCj4gVG86IExpbnVzIFdhbGxlaWo7IEFsZXhhbmRyZSBDb3Vy Ym90DQo+IENjOiBsaW51eC1ncGlvQHZnZXIua2VybmVsLm9yZzsga2VybmVsQHBlbmd1dHJvbml4 LmRlOyBCcmVhbmEsIFRpYmVyaXUgQTsNCj4gSm9uYXRoYW4gQ2FtZXJvbjsgSGFydG11dCBLbmFh Y2s7IExhcnMtUGV0ZXIgQ2xhdXNlbjsgUGV0ZXIgTWVlcndhbGQ7DQo+IGxpbnV4LWlpb0B2Z2Vy Lmtlcm5lbC5vcmcNCj4gU3ViamVjdDogW1BBVENIIGdwaW8tZm9yLW5leHQgMDMvMTBdIGlpbzog bGlnaHQ6IHN0azMzMTA6IHVzZSBmbGFncyBhcmd1bWVudCBvZg0KPiBkZXZtX2dwaW9kX2dldA0K PiANCj4gU2luY2UgMzliMmJiZTNkNzE1IChncGlvOiBhZGQgZmxhZ3MgYXJndW1lbnQgdG8gZ3Bp b2RfZ2V0KigpIGZ1bmN0aW9ucykNCj4gd2hpY2ggYXBwZWFyZWQgaW4gdjMuMTctcmMxLCB0aGUg Z3Bpb2RfZ2V0KiBmdW5jdGlvbnMgdGFrZSBhbiBhZGRpdGlvbmFsDQo+IHBhcmFtZXRlciB0aGF0 IGFsbG93cyB0byBzcGVjaWZ5IGRpcmVjdGlvbiBhbmQgaW5pdGlhbCB2YWx1ZSBmb3Igb3V0cHV0 Lg0KPiANCj4gU2ltcGxpZnkgZHJpdmVyIGFjY29yZGluZ2x5LiBGdXJ0aGVybW9yZSB0aGlzIGlz IG9uZSBjYWxsZXIgbGVzcyB0aGF0IHN0b3BzIHVzDQo+IG1ha2luZyB0aGUgZmxhZ3MgYXJndW1l bnQgdG8gZ3Bpb2RfZ2V0KigpIG1hbmRhdG9yeS4NCj4gDQo+IEFja2VkLWJ5OiBKb25hdGhhbiBD YW1lcm9uIDxqaWMyM0BrZXJuZWwub3JnPg0KPiBTaWduZWQtb2ZmLWJ5OiBVd2UgS2xlaW5lLUvD tm5pZyA8dS5rbGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPg0KDQorMQ0KDQpSZXZpZXdlZC1i eTogVGliZXJpdSBCcmVhbmEgPHRpYmVyaXUuYS5icmVhbmFAaW50ZWwuY29tPg0KDQo+IC0tLQ0K PiAgZHJpdmVycy9paW8vbGlnaHQvc3RrMzMxMC5jIHwgNiArLS0tLS0NCj4gIDEgZmlsZSBjaGFu Z2VkLCAxIGluc2VydGlvbigrKSwgNSBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2lpby9saWdodC9zdGszMzEwLmMgYi9kcml2ZXJzL2lpby9saWdodC9zdGszMzEwLmMg aW5kZXgNCj4gZmVlNDI5N2Q3YzhmLi44NGM3N2Q0MmEyYzYgMTAwNjQ0DQo+IC0tLSBhL2RyaXZl cnMvaWlvL2xpZ2h0L3N0azMzMTAuYw0KPiArKysgYi9kcml2ZXJzL2lpby9saWdodC9zdGszMzEw LmMNCj4gQEAgLTQ4OCwxNiArNDg4LDEyIEBAIHN0YXRpYyBpbnQgc3RrMzMxMF9ncGlvX3Byb2Jl KHN0cnVjdCBpMmNfY2xpZW50DQo+ICpjbGllbnQpDQo+ICAJZGV2ID0gJmNsaWVudC0+ZGV2Ow0K PiANCj4gIAkvKiBncGlvIGludGVycnVwdCBwaW4gKi8NCj4gLQlncGlvID0gZGV2bV9ncGlvZF9n ZXRfaW5kZXgoZGV2LCBTVEszMzEwX0dQSU8sIDApOw0KPiArCWdwaW8gPSBkZXZtX2dwaW9kX2dl dF9pbmRleChkZXYsIFNUSzMzMTBfR1BJTywgMCwgR1BJT0RfSU4pOw0KPiAgCWlmIChJU19FUlIo Z3BpbykpIHsNCj4gIAkJZGV2X2VycihkZXYsICJhY3BpIGdwaW8gZ2V0IGluZGV4IGZhaWxlZFxu Iik7DQo+ICAJCXJldHVybiBQVFJfRVJSKGdwaW8pOw0KPiAgCX0NCj4gDQo+IC0JcmV0ID0gZ3Bp b2RfZGlyZWN0aW9uX2lucHV0KGdwaW8pOw0KPiAtCWlmIChyZXQpDQo+IC0JCXJldHVybiByZXQ7 DQo+IC0NCj4gIAlyZXQgPSBncGlvZF90b19pcnEoZ3Bpbyk7DQo+ICAJZGV2X2RiZyhkZXYsICJH UElPIHJlc291cmNlLCBubzolZCBpcnE6JWRcbiIsIGRlc2NfdG9fZ3BpbyhncGlvKSwNCj4gcmV0 KTsNCj4gDQo+IC0tDQo+IDIuMS40DQoNCg==
next prev parent reply other threads:[~2015-07-06 9:36 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-15 21:36 [PATCH] gpio: make flags mandatory for gpiod_get functions Uwe Kleine-König 2015-06-21 6:51 ` Alexandre Courbot 2015-07-06 9:07 ` [PULL gpio-for-next] " Uwe Kleine-König 2015-07-06 9:07 ` Uwe Kleine-König 2015-07-06 9:09 ` [PATCH gpio-for-next 01/10] drm/msm/dp: use flags argument of devm_gpiod_get to set direction Uwe Kleine-König 2015-07-06 9:09 ` [PATCH gpio-for-next 02/10] drm/tilcdc: panel: make better use of gpiod API Uwe Kleine-König 2015-07-06 9:09 ` [PATCH gpio-for-next 05/10] media: i2c/adp1653: set enable gpio to output Uwe Kleine-König 2015-07-06 9:09 ` [PATCH gpio-for-next 06/10] NFC: nxp-nci_i2c: use flags argument of devm_gpiod_get_index Uwe Kleine-König 2015-07-06 9:09 ` [PATCH gpio-for-next 07/10] phy: tusb1210: make better use of gpiod API Uwe Kleine-König 2015-07-06 9:09 ` [PATCH gpio-for-next 08/10] usb: dwc3: pci: " Uwe Kleine-König [not found] ` <20150706090759.GS11824-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2015-07-06 9:09 ` [PATCH gpio-for-next 03/10] iio: light: stk3310: use flags argument of devm_gpiod_get Uwe Kleine-König 2015-07-06 9:09 ` Uwe Kleine-König 2015-07-06 9:35 ` Breana, Tiberiu A [this message] 2015-07-06 9:35 ` Breana, Tiberiu A 2015-07-06 9:09 ` [PATCH gpio-for-next 04/10] iio: magn: bmc150: " Uwe Kleine-König 2015-07-06 9:09 ` Uwe Kleine-König 2015-07-06 9:09 ` [PATCH gpio-for-next 09/10] usb: pass flags parameter to gpiod_get functions Uwe Kleine-König 2015-07-06 9:09 ` [PATCH gpio-for-next 10/10] gpio: make flags mandatory for " Uwe Kleine-König 2015-07-08 10:51 ` [PULL gpio-for-next] " Uwe Kleine-König 2015-07-15 6:28 ` Uwe Kleine-König 2015-07-15 6:39 ` Alexandre Courbot 2015-07-17 12:28 ` Linus Walleij 2015-07-20 6:56 ` Uwe Kleine-König 2015-07-20 7:41 ` Linus Walleij 2015-07-20 7:51 ` Uwe Kleine-König 2015-07-20 8:28 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4586F61A4A291F4DA44D32824E7C0F402216D8E5@IRSMSX109.ger.corp.intel.com \ --to=tiberiu.a.breana@intel.com \ --cc=gnurou@gmail.com \ --cc=jic23@kernel.org \ --cc=kernel@pengutronix.de \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-iio@vger.kernel.org \ --cc=pmeerw@pmeerw.net \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.