From: Richard Knutsson <ricknu-0@student.ltu.se>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] Taking the Min and Max macro job
Date: Fri, 09 Feb 2007 07:15:25 +0000 [thread overview]
Message-ID: <45CC1F8D.6020409@student.ltu.se> (raw)
In-Reply-To: <20070207235145.GZ8991@Ahmed>
Vignesh Babu BM wrote:
> Mehul like I said...xdr4.c needs a simple macro that does not check type
> at all.
>
> If my understanding of the min/max use is correct then they use default
> type checking and min_t/max_t use the type that 'we' specify...so end
> result-they are both bound to type-meaning they would both have
> statements in expression-resulting in compilation failure as xdr*.c uses
> them inside struct initializations.
>
> But the macro that would work in xdr*.c would look something like the
> below:
>
> #define min_s(x,y) ((x)>(y)?(x):(y))
>
> But with the above we need to make sure that x and y are not expressions
> if we dont want them to be evaluated twice and hence cause other
> probs ;)
>
> So either we modify min/max in kernel.h - this means a lot more cleanup
> or add another macro say min_s/max_s --- s for simple :)
>
> Unless we don't do that, it may not be possible to cleanup files like
> xdr*.c
>
What about __min/__max? At least I usually read the '__'-prefix as
something that is a subset of something (and most likely less secure).
I wrote about this in "[KJ] [RFC] Regarding min/max" (07-02-03) bit
since I was not able to find an example I took it as a mistake on my part.
Richard Knutsson
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2007-02-09 7:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-07 23:51 [KJ] Taking the Min and Max macro job Ahmed S. Darwish
2007-02-08 6:16 ` Alexey Dobriyan
2007-02-08 9:34 ` Ahmed S. Darwish
2007-02-08 9:41 ` Mehul Jani
2007-02-08 10:14 ` Mehul Jani
2007-02-08 11:40 ` Ahmed S. Darwish
2007-02-08 12:30 ` Mehul Jani
2007-02-08 12:34 ` Ahmed S. Darwish
2007-02-08 16:53 ` Robert P. J. Day
2007-02-08 18:40 ` Mehul Jani
2007-02-09 5:29 ` Mehul Jani
2007-02-09 6:44 ` Vignesh Babu BM
2007-02-09 7:15 ` Richard Knutsson [this message]
2007-02-09 7:56 ` Vignesh Babu BM
2007-02-09 8:19 ` Vignesh Babu BM
2007-02-09 8:55 ` Richard Knutsson
2007-02-09 9:41 ` Vignesh Babu BM
2007-02-09 9:56 ` Jaco Kroon
2007-02-09 12:17 ` Mehul Jani
2007-02-09 18:01 ` Richard Knutsson
2007-02-09 18:10 ` Richard Knutsson
2007-02-09 19:38 ` Mehul Jani
2007-02-09 22:28 ` Richard Knutsson
2007-02-10 5:49 ` Vignesh Babu BM
2007-02-10 8:24 ` Mehul Jani
2007-02-10 11:26 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45CC1F8D.6020409@student.ltu.se \
--to=ricknu-0@student.ltu.se \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.