Re: [KJ] Taking the Min and Max macro job

[Jaco Kroon <jaco@kroon.co.za>]

[-- Attachment #1.1: Type: text/plain, Size: 1010 bytes --]

Vignesh Babu BM wrote:
> On Fri, 2007-02-09 at 09:55 +0100, Richard Knutsson wrote:
> 
>>Vignesh Babu BM wrote:
>>
>>>Just went through the archives....
>>>
>>>        I tried to recreate the compile-failure (was some time ago since
>>>        it 
>>>        happened) when using min()/max() in a struct but it happily compiled it 
>>>        so (thankfully) you are correct, just need to use min()/max(). :)
>>>        
>>>        Richard Knutsson
>>>        
>>>Do you mean to say that you were able to compile when the macros were used inside struct?
>>>Im still not able to get that to happen...
>>>
>>>I tried that change in linux-2.6/fs/lockd/mon.c
>>>
>>>static struct rpc_procinfo	nsm_procedures[] = {
>>>[SM_MON] = {
>>>		.p_proc		= SM_MON,
>>>		.p_encode	= (kxdrproc_t) xdr_encode_mon,
>>>		.p_decode	= (kxdrproc_t) xdr_decode_stat_res,
>>>		.p_bufsiz	= max(SM_mon_sz, SM_monres_sz) << 2,

Will work since both SM_mon_sz and SM_monres_sz are compile-time
constants, not true?

[ ... snip ... ]

Jaco

[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 3233 bytes --]

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors