* Re: [kvm-commits] kvm: revert r4386 (rev 4422) [not found] ` <20070214075713.2D6DC250354-LjA0eNSCdXrQnzwC+xcbyw@public.gmane.org> @ 2007-02-14 8:06 ` Muli Ben-Yehuda [not found] ` <20070214080623.GD461-k73YwwB0fHlWk0Htik3J/w@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Muli Ben-Yehuda @ 2007-02-14 8:06 UTC (permalink / raw) To: Avi Kivity; +Cc: kvm-devel On Wed, Feb 14, 2007 at 09:57:13AM +0200, Avi Kivity wrote: > kvm: revert r4386 > > causes breakage, as well as using evil '?=' assignment. *sigh*, this breaks --kerneldir. The patch I resent early this morning does the right thing. Cheers, Muli ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20070214080623.GD461-k73YwwB0fHlWk0Htik3J/w@public.gmane.org>]
* Re: [kvm-commits] kvm: revert r4386 (rev 4422) [not found] ` <20070214080623.GD461-k73YwwB0fHlWk0Htik3J/w@public.gmane.org> @ 2007-02-14 8:25 ` Avi Kivity [not found] ` <45D2C78A.4060203-atKUWr5tajBWk0Htik3J/w@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Avi Kivity @ 2007-02-14 8:25 UTC (permalink / raw) To: Muli Ben-Yehuda; +Cc: kvm-devel Muli Ben-Yehuda wrote: > On Wed, Feb 14, 2007 at 09:57:13AM +0200, Avi Kivity wrote: > >> kvm: revert r4386 >> >> causes breakage, as well as using evil '?=' assignment. >> > > *sigh*, this breaks --kerneldir. > > The patch I resent early this morning does the right thing. > > Well, --kerneldir should be fixed without ?= and with testing. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <45D2C78A.4060203-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]
* Re: [kvm-commits] kvm: revert r4386 (rev 4422) [not found] ` <45D2C78A.4060203-atKUWr5tajBWk0Htik3J/w@public.gmane.org> @ 2007-02-14 8:30 ` Muli Ben-Yehuda [not found] ` <20070214083039.GE461-k73YwwB0fHlWk0Htik3J/w@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Muli Ben-Yehuda @ 2007-02-14 8:30 UTC (permalink / raw) To: Avi Kivity; +Cc: kvm-devel On Wed, Feb 14, 2007 at 10:25:46AM +0200, Avi Kivity wrote: > Muli Ben-Yehuda wrote: > >On Wed, Feb 14, 2007 at 09:57:13AM +0200, Avi Kivity wrote: > > > >>kvm: revert r4386 > >> > >>causes breakage, as well as using evil '?=' assignment. > >> > > > >*sigh*, this breaks --kerneldir. > > > >The patch I resent early this morning does the right thing. > > Well, --kerneldir should be fixed without ?= and with testing. What's wrong with '?='? Are we requiring running `configure' in the top level before running 'make' in kernel/? if yes, getting rid of the KERNELDIR assignment in kernel/Makefile is trivial, if not, '?=' expresses the semantics exactly - if KERNELDIR is already set, use that, if not set it to the default. Cheers, Muli ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20070214083039.GE461-k73YwwB0fHlWk0Htik3J/w@public.gmane.org>]
* Re: [kvm-commits] kvm: revert r4386 (rev 4422) [not found] ` <20070214083039.GE461-k73YwwB0fHlWk0Htik3J/w@public.gmane.org> @ 2007-02-14 13:15 ` Avi Kivity [not found] ` <45D30B79.6080807-atKUWr5tajBWk0Htik3J/w@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Avi Kivity @ 2007-02-14 13:15 UTC (permalink / raw) To: Muli Ben-Yehuda; +Cc: kvm-devel Muli Ben-Yehuda wrote: > On Wed, Feb 14, 2007 at 10:25:46AM +0200, Avi Kivity wrote: > >> Muli Ben-Yehuda wrote: >> >>> On Wed, Feb 14, 2007 at 09:57:13AM +0200, Avi Kivity wrote: >>> >>> >>>> kvm: revert r4386 >>>> >>>> causes breakage, as well as using evil '?=' assignment. >>>> >>>> >>> *sigh*, this breaks --kerneldir. >>> >>> The patch I resent early this morning does the right thing. >>> >> Well, --kerneldir should be fixed without ?= and with testing. >> > > What's wrong with '?='? > It allows environment variables to affect the compilation. > Are we requiring running `configure' in the top level before running > 'make' in kernel/? For now, yes. If it's desired to have kernel/ as a standalone directory, it should have its own ./configure (called from the top-level ./configure for a full build). > if yes, getting rid of the KERNELDIR assignment in > kernel/Makefile is trivial, if not, '?=' expresses the semantics > exactly - if KERNELDIR is already set, use that, if not set it to the > default. > Maybe. I'm just not up to testing 3 options x a zillion distros. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <45D30B79.6080807-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]
* Re: [kvm-commits] kvm: revert r4386 (rev 4422) [not found] ` <45D30B79.6080807-atKUWr5tajBWk0Htik3J/w@public.gmane.org> @ 2007-02-14 13:31 ` Laurent Vivier 2007-02-14 17:50 ` Muli Ben-Yehuda 1 sibling, 0 replies; 6+ messages in thread From: Laurent Vivier @ 2007-02-14 13:31 UTC (permalink / raw) To: Avi Kivity; +Cc: kvm-devel [-- Attachment #1.1: Type: text/plain, Size: 1558 bytes --] Avi Kivity wrote: > Muli Ben-Yehuda wrote: >> On Wed, Feb 14, 2007 at 10:25:46AM +0200, Avi Kivity wrote: >> >>> Muli Ben-Yehuda wrote: >>> >>>> On Wed, Feb 14, 2007 at 09:57:13AM +0200, Avi Kivity wrote: >>>> >>>> >>>>> kvm: revert r4386 >>>>> >>>>> causes breakage, as well as using evil '?=' assignment. >>>>> >>>>> >>>> *sigh*, this breaks --kerneldir. >>>> >>>> The patch I resent early this morning does the right thing. >>>> >>> Well, --kerneldir should be fixed without ?= and with testing. >>> >> What's wrong with '?='? >> > > It allows environment variables to affect the compilation. Environment variables affect compilation, try: # cd kvm-13 # make clean # ./configure --prefix=/usr --with-patched-kernel # export CC=toto # make make -C user make[1]: Entering directory `/home/vivierl/kvm-13/user' toto -I /usr/src/linux-2.6.20/include -MMD -MF ./.kvmctl.d -g -c -o kvmctl.o kvmctl.c make[1]: toto: Command not found make[1]: *** [kvmctl.o] Error 127 make[1]: Leaving directory `/home/vivierl/kvm-13/user' make: *** [user] Error 2 If you protect "KERNELDIR", perhaps you should protect "CC" too... and all other shell variables. IMHO, it is more flexible to allow environment to affect behaviour of commands : it is the aim of shell variables. Regards, Laurent -- ------------- Laurent.Vivier-6ktuUTfB/bM@public.gmane.org -------------- "Any sufficiently advanced technology is indistinguishable from magic." - Arthur C. Clarke [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 189 bytes --] [-- Attachment #2: Type: text/plain, Size: 345 bytes --] ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV [-- Attachment #3: Type: text/plain, Size: 186 bytes --] _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [kvm-commits] kvm: revert r4386 (rev 4422) [not found] ` <45D30B79.6080807-atKUWr5tajBWk0Htik3J/w@public.gmane.org> 2007-02-14 13:31 ` Laurent Vivier @ 2007-02-14 17:50 ` Muli Ben-Yehuda 1 sibling, 0 replies; 6+ messages in thread From: Muli Ben-Yehuda @ 2007-02-14 17:50 UTC (permalink / raw) To: Avi Kivity; +Cc: kvm-devel On Wed, Feb 14, 2007 at 03:15:37PM +0200, Avi Kivity wrote: > It allows environment variables to affect the compilation. I'd consider this a feature (also see Laurent's reply), but ok. > >Are we requiring running `configure' in the top level before running > >'make' in kernel/? > > For now, yes. If it's desired to have kernel/ as a standalone > directory, it should have its own ./configure (called from the > top-level ./configure for a full build). Ok, that makes the problem very easy to solve. Patch coming up in a few. Cheers, Muli ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-02-14 17:50 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20070214075713.2D6DC250354@il.qumranet.com> [not found] ` <20070214075713.2D6DC250354-LjA0eNSCdXrQnzwC+xcbyw@public.gmane.org> 2007-02-14 8:06 ` [kvm-commits] kvm: revert r4386 (rev 4422) Muli Ben-Yehuda [not found] ` <20070214080623.GD461-k73YwwB0fHlWk0Htik3J/w@public.gmane.org> 2007-02-14 8:25 ` Avi Kivity [not found] ` <45D2C78A.4060203-atKUWr5tajBWk0Htik3J/w@public.gmane.org> 2007-02-14 8:30 ` Muli Ben-Yehuda [not found] ` <20070214083039.GE461-k73YwwB0fHlWk0Htik3J/w@public.gmane.org> 2007-02-14 13:15 ` Avi Kivity [not found] ` <45D30B79.6080807-atKUWr5tajBWk0Htik3J/w@public.gmane.org> 2007-02-14 13:31 ` Laurent Vivier 2007-02-14 17:50 ` Muli Ben-Yehuda
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.