* [patch] Add missing breaks to {set, get}_address_size domctls.
@ 2007-02-14 12:30 Gerd Hoffmann
2007-02-14 15:25 ` Gerd Hoffmann
0 siblings, 1 reply; 5+ messages in thread
From: Gerd Hoffmann @ 2007-02-14 12:30 UTC (permalink / raw)
To: Xen devel list; +Cc: Jan Beulich
[-- Attachment #1: Type: text/plain, Size: 86 bytes --]
Hi,
$subject says all ;)
please apply,
Gerd
--
Gerd Hoffmann <kraxel@suse.de>
[-- Attachment #2: domctl.diff --]
[-- Type: text/x-patch, Size: 538 bytes --]
Add missing breaks to {set,get}_address_size domctls.
Signed-off-by: Gerd Hoffmann <kraxel@suse.de>
diff -r ad9bbd103034 xen/arch/x86/domctl.c
--- a/xen/arch/x86/domctl.c Fri Feb 09 18:19:24 2007 +0000
+++ b/xen/arch/x86/domctl.c Wed Feb 14 13:25:02 2007 +0100
@@ -398,6 +398,7 @@ long arch_do_domctl(
put_domain(d);
}
+ break;
case XEN_DOMCTL_get_address_size:
{
@@ -412,6 +413,7 @@ long arch_do_domctl(
ret = 0;
put_domain(d);
}
+ break;
default:
ret = -ENOSYS;
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] Add missing breaks to {set, get}_address_size domctls.
2007-02-14 12:30 [patch] Add missing breaks to {set, get}_address_size domctls Gerd Hoffmann
@ 2007-02-14 15:25 ` Gerd Hoffmann
2007-02-14 15:49 ` Jan Beulich
0 siblings, 1 reply; 5+ messages in thread
From: Gerd Hoffmann @ 2007-02-14 15:25 UTC (permalink / raw)
To: Xen devel list; +Cc: Jan Beulich
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
Gerd Hoffmann wrote:
> Hi,
>
> $subject says all ;)
Oops, fix was incomplete, the get_address_size also lacks the
copy_to_guest() ...
updated patch attached,
Gerd
--
Gerd Hoffmann <kraxel@suse.de>
[-- Attachment #2: domctl.diff --]
[-- Type: text/x-patch, Size: 769 bytes --]
diff -r ad9bbd103034 xen/arch/x86/domctl.c
--- a/xen/arch/x86/domctl.c Fri Feb 09 18:19:24 2007 +0000
+++ b/xen/arch/x86/domctl.c Wed Feb 14 15:42:34 2007 +0100
@@ -398,6 +398,7 @@ long arch_do_domctl(
put_domain(d);
}
+ break;
case XEN_DOMCTL_get_address_size:
{
@@ -407,11 +408,16 @@ long arch_do_domctl(
if ( (d = get_domain_by_id(domctl->domain)) == NULL )
break;
+ printk("%s: offset %zd\n", __FUNCTION__, offsetof(struct xen_domctl, u.address_size.size));
domctl->u.address_size.size = BITS_PER_GUEST_LONG(d);
ret = 0;
put_domain(d);
- }
+
+ if (copy_to_guest(u_domctl, domctl, 1))
+ ret = -EFAULT;
+ }
+ break;
default:
ret = -ENOSYS;
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] Add missing breaks to {set, get}_address_size domctls.
2007-02-14 15:25 ` Gerd Hoffmann
@ 2007-02-14 15:49 ` Jan Beulich
2007-02-14 15:50 ` Keir Fraser
2007-02-14 15:52 ` Gerd Hoffmann
0 siblings, 2 replies; 5+ messages in thread
From: Jan Beulich @ 2007-02-14 15:49 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: Xen devel list
>>> Gerd Hoffmann <kraxel@suse.de> 14.02.07 16:25 >>>
>Gerd Hoffmann wrote:
>> Hi,
>>
>> $subject says all ;)
>
>Oops, fix was incomplete, the get_address_size also lacks the
>copy_to_guest() ...
But the added printk in there is certainly a leftover...
Jan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Re: [patch] Add missing breaks to {set, get}_address_size domctls.
2007-02-14 15:49 ` Jan Beulich
@ 2007-02-14 15:50 ` Keir Fraser
2007-02-14 15:52 ` Gerd Hoffmann
1 sibling, 0 replies; 5+ messages in thread
From: Keir Fraser @ 2007-02-14 15:50 UTC (permalink / raw)
To: Jan Beulich, Gerd Hoffmann; +Cc: Xen devel list
On 14/2/07 15:49, "Jan Beulich" <jbeulich@novell.com> wrote:
>>> $subject says all ;)
>>
>> Oops, fix was incomplete, the get_address_size also lacks the
>> copy_to_guest() ...
>
> But the added printk in there is certainly a leftover...
It's cleaned up and checked in now.
K.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] Add missing breaks to {set, get}_address_size domctls.
2007-02-14 15:49 ` Jan Beulich
2007-02-14 15:50 ` Keir Fraser
@ 2007-02-14 15:52 ` Gerd Hoffmann
1 sibling, 0 replies; 5+ messages in thread
From: Gerd Hoffmann @ 2007-02-14 15:52 UTC (permalink / raw)
To: Jan Beulich; +Cc: Xen devel list
Jan Beulich wrote:
>>>> Gerd Hoffmann <kraxel@suse.de> 14.02.07 16:25 >>>
>> Gerd Hoffmann wrote:
>>> Hi,
>>>
>>> $subject says all ;)
>> Oops, fix was incomplete, the get_address_size also lacks the
>> copy_to_guest() ...
>
> But the added printk in there is certainly a leftover...
Yep, forgot to delete that one and -- as usual -- noticed that a few
seconds after sending off the mail ...
cheers,
Gerd
--
Gerd Hoffmann <kraxel@suse.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-02-14 15:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-14 12:30 [patch] Add missing breaks to {set, get}_address_size domctls Gerd Hoffmann
2007-02-14 15:25 ` Gerd Hoffmann
2007-02-14 15:49 ` Jan Beulich
2007-02-14 15:50 ` Keir Fraser
2007-02-14 15:52 ` Gerd Hoffmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.