[patch] Add missing breaks to {set, get}_address_size domctls.

[patch] Add missing breaks to {set, get}_address_size domctls.

[Gerd Hoffmann]

[-- Attachment #1: Type: text/plain, Size: 86 bytes --]

  Hi,

$subject says all ;)

please apply,
  Gerd

-- 
Gerd Hoffmann <kraxel@suse.de>

[-- Attachment #2: domctl.diff --]
[-- Type: text/x-patch, Size: 538 bytes --]

Add missing breaks to {set,get}_address_size domctls.

Signed-off-by: Gerd Hoffmann <kraxel@suse.de>
diff -r ad9bbd103034 xen/arch/x86/domctl.c
--- a/xen/arch/x86/domctl.c	Fri Feb 09 18:19:24 2007 +0000
+++ b/xen/arch/x86/domctl.c	Wed Feb 14 13:25:02 2007 +0100
@@ -398,6 +398,7 @@ long arch_do_domctl(
 
         put_domain(d);
     }
+    break;
 
     case XEN_DOMCTL_get_address_size:
     {
@@ -412,6 +413,7 @@ long arch_do_domctl(
         ret = 0;
         put_domain(d);
     }
+    break;
 
     default:
         ret = -ENOSYS;

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [patch] Add missing breaks to {set, get}_address_size domctls.

[Gerd Hoffmann]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

Gerd Hoffmann wrote:
>   Hi,
> 
> $subject says all ;)

Oops, fix was incomplete, the get_address_size also lacks the
copy_to_guest() ...

updated patch attached,
  Gerd

-- 
Gerd Hoffmann <kraxel@suse.de>

[-- Attachment #2: domctl.diff --]
[-- Type: text/x-patch, Size: 769 bytes --]

diff -r ad9bbd103034 xen/arch/x86/domctl.c
--- a/xen/arch/x86/domctl.c	Fri Feb 09 18:19:24 2007 +0000
+++ b/xen/arch/x86/domctl.c	Wed Feb 14 15:42:34 2007 +0100
@@ -398,6 +398,7 @@ long arch_do_domctl(
 
         put_domain(d);
     }
+    break;
 
     case XEN_DOMCTL_get_address_size:
     {
@@ -407,11 +408,16 @@ long arch_do_domctl(
         if ( (d = get_domain_by_id(domctl->domain)) == NULL )
             break;
 
+	printk("%s: offset %zd\n", __FUNCTION__, offsetof(struct xen_domctl, u.address_size.size));
         domctl->u.address_size.size = BITS_PER_GUEST_LONG(d);
 
         ret = 0;
         put_domain(d);
-    }
+
+        if (copy_to_guest(u_domctl, domctl, 1))
+            ret = -EFAULT;
+    }
+    break;
 
     default:
         ret = -ENOSYS;

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [patch] Add missing breaks to {set, get}_address_size domctls.

[Jan Beulich]

>>> Gerd Hoffmann <kraxel@suse.de> 14.02.07 16:25 >>>
>Gerd Hoffmann wrote:
>>   Hi,
>> 
>> $subject says all ;)
>
>Oops, fix was incomplete, the get_address_size also lacks the
>copy_to_guest() ...

But the added printk in there is certainly a leftover...

Jan

Re: Re: [patch] Add missing breaks to {set, get}_address_size domctls.

[Keir Fraser]

On 14/2/07 15:49, "Jan Beulich" <jbeulich@novell.com> wrote:

>>> $subject says all ;)
>> 
>> Oops, fix was incomplete, the get_address_size also lacks the
>> copy_to_guest() ...
> 
> But the added printk in there is certainly a leftover...

It's cleaned up and checked in now.

 K.

Re: [patch] Add missing breaks to {set, get}_address_size domctls.

[Gerd Hoffmann]

Jan Beulich wrote:
>>>> Gerd Hoffmann <kraxel@suse.de> 14.02.07 16:25 >>>
>> Gerd Hoffmann wrote:
>>>   Hi,
>>>
>>> $subject says all ;)
>> Oops, fix was incomplete, the get_address_size also lacks the
>> copy_to_guest() ...
> 
> But the added printk in there is certainly a leftover...

Yep, forgot to delete that one and -- as usual -- noticed that a few
seconds after sending off the mail ...

cheers,
  Gerd

-- 
Gerd Hoffmann <kraxel@suse.de>