From: Lucas Stach <l.stach@pengutronix.de> To: Tim Harvey <tharvey@gateworks.com>, Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: imx8mm-venice-gw7901.dts: disable pgc_gpumix Date: Wed, 06 Oct 2021 18:26:24 +0200 [thread overview] Message-ID: <45dc35aa5e7901051cd86f3461aab01d8604c746.camel@pengutronix.de> (raw) In-Reply-To: <20211006153836.13760-1-tharvey@gateworks.com> Am Mittwoch, dem 06.10.2021 um 08:38 -0700 schrieb Tim Harvey: > Since commit b21269b12e48 ("arm64: dts: imx8mm: add GPC node") the > GW7901 will hang during kernel init because it does not power the unused > GPU voltage rails on the IMX8MM. Disable pgc_gpumix to work around this. > > We also disable the GPU devices that depend on the gpumix power domain > and pgc_gpu to avoid them staying in a probe deferred state forever. > > Additionally as the MIPI voltage rail is also not connected on this > board we disable pgc_mipi and disp_blk_ctrl. > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > --- > v2: > - also disable pgc_gpu to keep gpu from getting in probe deferred state > - also disable pgc_mipi and disp_blk_ctrl as the MIPI power rails are > not connected > --- > .../dts/freescale/imx8mm-venice-gw7901.dts | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts > index bafd5c8ea4e2..21c546c4628d 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts > @@ -255,6 +255,10 @@ > }; > }; > > +&disp_blk_ctrl { > + status = "disabled"; > +}; > + > &ecspi1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_spi1>; > @@ -282,6 +286,14 @@ > }; > }; > > +&gpu_2d { > + status = "disabled"; > +}; > + > +&gpu_3d { > + status = "disabled"; > +}; > + > &i2c1 { > clock-frequency = <100000>; > pinctrl-names = "default"; > @@ -632,6 +644,18 @@ > status = "okay"; > }; > > +&pgc_gpu { > + status = "disabled"; > +}; > + > +&pgc_gpumix { > + status = "disabled"; > +}; > + > +&pgc_mipi { > + status = "disabled"; > +}; > + > &uart1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_uart1>, <&pinctrl_uart1_gpio>;
WARNING: multiple messages have this Message-ID (diff)
From: Lucas Stach <l.stach@pengutronix.de> To: Tim Harvey <tharvey@gateworks.com>, Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: imx8mm-venice-gw7901.dts: disable pgc_gpumix Date: Wed, 06 Oct 2021 18:26:24 +0200 [thread overview] Message-ID: <45dc35aa5e7901051cd86f3461aab01d8604c746.camel@pengutronix.de> (raw) In-Reply-To: <20211006153836.13760-1-tharvey@gateworks.com> Am Mittwoch, dem 06.10.2021 um 08:38 -0700 schrieb Tim Harvey: > Since commit b21269b12e48 ("arm64: dts: imx8mm: add GPC node") the > GW7901 will hang during kernel init because it does not power the unused > GPU voltage rails on the IMX8MM. Disable pgc_gpumix to work around this. > > We also disable the GPU devices that depend on the gpumix power domain > and pgc_gpu to avoid them staying in a probe deferred state forever. > > Additionally as the MIPI voltage rail is also not connected on this > board we disable pgc_mipi and disp_blk_ctrl. > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > --- > v2: > - also disable pgc_gpu to keep gpu from getting in probe deferred state > - also disable pgc_mipi and disp_blk_ctrl as the MIPI power rails are > not connected > --- > .../dts/freescale/imx8mm-venice-gw7901.dts | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts > index bafd5c8ea4e2..21c546c4628d 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts > @@ -255,6 +255,10 @@ > }; > }; > > +&disp_blk_ctrl { > + status = "disabled"; > +}; > + > &ecspi1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_spi1>; > @@ -282,6 +286,14 @@ > }; > }; > > +&gpu_2d { > + status = "disabled"; > +}; > + > +&gpu_3d { > + status = "disabled"; > +}; > + > &i2c1 { > clock-frequency = <100000>; > pinctrl-names = "default"; > @@ -632,6 +644,18 @@ > status = "okay"; > }; > > +&pgc_gpu { > + status = "disabled"; > +}; > + > +&pgc_gpumix { > + status = "disabled"; > +}; > + > +&pgc_mipi { > + status = "disabled"; > +}; > + > &uart1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_uart1>, <&pinctrl_uart1_gpio>; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-06 16:26 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-06 15:38 [PATCH v2] arm64: dts: imx8mm-venice-gw7901.dts: disable pgc_gpumix Tim Harvey 2021-10-06 15:38 ` Tim Harvey 2021-10-06 16:26 ` Lucas Stach [this message] 2021-10-06 16:26 ` Lucas Stach 2021-10-15 2:43 ` Shawn Guo 2021-10-15 2:43 ` Shawn Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=45dc35aa5e7901051cd86f3461aab01d8604c746.camel@pengutronix.de \ --to=l.stach@pengutronix.de \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=tharvey@gateworks.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.