All of lore.kernel.org
 help / color / mirror / Atom feed
From: lijiang <lijiang@redhat.com>
To: Dave Hansen <dave.hansen@intel.com>, linux-kernel@vger.kernel.org
Cc: kexec@lists.infradead.org, x86@kernel.org,
	linux-ia64@vger.kernel.org, linux-efi@vger.kernel.org,
	tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	akpm@linux-foundation.org, dave.hansen@linux.intel.com,
	luto@kernel.org, peterz@infradead.org, ard.biesheuvel@linaro.org,
	tony.luck@intel.com, fenghua.yu@intel.com, dyoung@redhat.com,
	bhe@redhat.com
Subject: Re: [PATCH 0/2 RESEND v7] add reserved e820 ranges to the kdump kernel e820 table
Date: Tue, 27 Nov 2018 10:58:38 +0800	[thread overview]
Message-ID: <463c284b-115e-0784-ca07-a430127e6176@redhat.com> (raw)
In-Reply-To: <35e8ade5-d5a8-b5e4-180b-44b4ff0a83b1@intel.com>

在 2018年11月27日 02:54, Dave Hansen 写道:
> On 11/23/18 9:12 PM, Lianbo Jiang wrote:
>> These patches add the new I/O resource descriptor 'IORES_DESC_RESERVED'
>> for the iomem resources search interfaces, and in order to make it still
>> work after the new descriptor is added, these codes originally related
>> to 'IORES_DESC_NONE' have been updated.
> 
> This is rather anemic "0/" text.  Could you please include some more
> background in here?  The 2/2 patch is pretty good in this regard, but it
> needs to be here, too.
> 

Thanks for your comment. 

Originally, this patch added the e820 reserved ranges by accurately comparing
a string. It only modifies fewer code paths. Please refer to patch v6.
https://lore.kernel.org/lkml/20181114072926.13312-2-lijiang@redhat.com/

Because the string comparison is fragile and error-prone, this patch used the
solution that adds a new descriptor 'IORES_DESC_RESERVED'. Please refer to this
link: https://lore.kernel.org/lkml/20181120192935.GK2527@zn.tnic/

When passing the e820 reserved ranges to the second kernel, why does it need to
compare strings accurately or add a new descriptor 'IORES_DESC_RESERVED'?

-The reason is that it can not exactly match the e820 reserved resource ranges
when walking through iomem resources with the descriptor 'IORES_DESC_NONE'.

Thanks.
Lianbo

WARNING: multiple messages have this Message-ID (diff)
From: lijiang <lijiang@redhat.com>
To: Dave Hansen <dave.hansen@intel.com>, linux-kernel@vger.kernel.org
Cc: fenghua.yu@intel.com, linux-efi@vger.kernel.org,
	linux-ia64@vger.kernel.org, bhe@redhat.com,
	ard.biesheuvel@linaro.org, peterz@infradead.org, x86@kernel.org,
	kexec@lists.infradead.org, tony.luck@intel.com,
	dave.hansen@linux.intel.com, mingo@redhat.com, bp@alien8.de,
	luto@kernel.org, tglx@linutronix.de, dyoung@redhat.com,
	akpm@linux-foundation.org
Subject: Re: [PATCH 0/2 RESEND v7] add reserved e820 ranges to the kdump kernel e820 table
Date: Tue, 27 Nov 2018 10:58:38 +0800	[thread overview]
Message-ID: <463c284b-115e-0784-ca07-a430127e6176@redhat.com> (raw)
In-Reply-To: <35e8ade5-d5a8-b5e4-180b-44b4ff0a83b1@intel.com>

在 2018年11月27日 02:54, Dave Hansen 写道:
> On 11/23/18 9:12 PM, Lianbo Jiang wrote:
>> These patches add the new I/O resource descriptor 'IORES_DESC_RESERVED'
>> for the iomem resources search interfaces, and in order to make it still
>> work after the new descriptor is added, these codes originally related
>> to 'IORES_DESC_NONE' have been updated.
> 
> This is rather anemic "0/" text.  Could you please include some more
> background in here?  The 2/2 patch is pretty good in this regard, but it
> needs to be here, too.
> 

Thanks for your comment. 

Originally, this patch added the e820 reserved ranges by accurately comparing
a string. It only modifies fewer code paths. Please refer to patch v6.
https://lore.kernel.org/lkml/20181114072926.13312-2-lijiang@redhat.com/

Because the string comparison is fragile and error-prone, this patch used the
solution that adds a new descriptor 'IORES_DESC_RESERVED'. Please refer to this
link: https://lore.kernel.org/lkml/20181120192935.GK2527@zn.tnic/

When passing the e820 reserved ranges to the second kernel, why does it need to
compare strings accurately or add a new descriptor 'IORES_DESC_RESERVED'?

-The reason is that it can not exactly match the e820 reserved resource ranges
when walking through iomem resources with the descriptor 'IORES_DESC_NONE'.

Thanks.
Lianbo

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: lijiang <lijiang@redhat.com>
To: Dave Hansen <dave.hansen@intel.com>, linux-kernel@vger.kernel.org
Cc: kexec@lists.infradead.org, x86@kernel.org,
	linux-ia64@vger.kernel.org, linux-efi@vger.kernel.org,
	tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	akpm@linux-foundation.org, dave.hansen@linux.intel.com,
	luto@kernel.org, peterz@infradead.org, ard.biesheuvel@linaro.org,
	tony.luck@intel.com, fenghua.yu@intel.com, dyoung@redhat.com,
	bhe@redhat.com
Subject: Re: [PATCH 0/2 RESEND v7] add reserved e820 ranges to the kdump kernel e820 table
Date: Tue, 27 Nov 2018 02:58:38 +0000	[thread overview]
Message-ID: <463c284b-115e-0784-ca07-a430127e6176@redhat.com> (raw)
In-Reply-To: <35e8ade5-d5a8-b5e4-180b-44b4ff0a83b1@intel.com>

在 2018年11月27日 02:54, Dave Hansen 写道:
> On 11/23/18 9:12 PM, Lianbo Jiang wrote:
>> These patches add the new I/O resource descriptor 'IORES_DESC_RESERVED'
>> for the iomem resources search interfaces, and in order to make it still
>> work after the new descriptor is added, these codes originally related
>> to 'IORES_DESC_NONE' have been updated.
> 
> This is rather anemic "0/" text.  Could you please include some more
> background in here?  The 2/2 patch is pretty good in this regard, but it
> needs to be here, too.
> 

Thanks for your comment. 

Originally, this patch added the e820 reserved ranges by accurately comparing
a string. It only modifies fewer code paths. Please refer to patch v6.
https://lore.kernel.org/lkml/20181114072926.13312-2-lijiang@redhat.com/

Because the string comparison is fragile and error-prone, this patch used the
solution that adds a new descriptor 'IORES_DESC_RESERVED'. Please refer to this
link: https://lore.kernel.org/lkml/20181120192935.GK2527@zn.tnic/

When passing the e820 reserved ranges to the second kernel, why does it need to
compare strings accurately or add a new descriptor 'IORES_DESC_RESERVED'?

-The reason is that it can not exactly match the e820 reserved resource ranges
when walking through iomem resources with the descriptor 'IORES_DESC_NONE'.

Thanks.
Lianbo

  reply	other threads:[~2018-11-27  2:59 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-24  5:12 [PATCH 0/2 RESEND v7] add reserved e820 ranges to the kdump kernel e820 table Lianbo Jiang
2018-11-24  5:12 ` Lianbo Jiang
2018-11-24  5:12 ` Lianbo Jiang
2018-11-24  5:12 ` [PATCH 1/2 RESEND v7] resource: add the new I/O resource descriptor 'IORES_DESC_RESERVED' Lianbo Jiang
2018-11-24  5:12   ` Lianbo Jiang
2018-11-24  5:12   ` Lianbo Jiang
2018-11-26 20:52   ` Dave Hansen
2018-11-26 20:52     ` Dave Hansen
2018-11-26 20:52     ` Dave Hansen
2018-11-27 10:04     ` lijiang
2018-11-27 10:04       ` lijiang
2018-11-27 10:04       ` lijiang
2018-11-27 15:34       ` Dave Hansen
2018-11-27 15:34         ` Dave Hansen
2018-11-27 15:34         ` Dave Hansen
2018-11-28  3:51         ` lijiang
2018-11-28  3:51           ` lijiang
2018-11-28  3:51           ` lijiang
2018-11-28 16:02           ` Dave Hansen
2018-11-28 16:02             ` Dave Hansen
2018-11-28 16:02             ` Dave Hansen
2018-11-28 16:02             ` Dave Hansen
2018-11-29  2:14             ` lijiang
2018-11-29  2:14               ` lijiang
2018-11-29  2:14               ` lijiang
2018-11-24  5:12 ` [PATCH 2/2 RESEND v7] x86/kexec_file: add reserved e820 ranges to kdump kernel e820 table Lianbo Jiang
2018-11-24  5:12   ` Lianbo Jiang
2018-11-24  5:12   ` Lianbo Jiang
2018-11-26 17:44 ` [PATCH 0/2 RESEND v7] add reserved e820 ranges to the " Dave Hansen
2018-11-26 17:44   ` Dave Hansen
2018-11-26 17:44   ` Dave Hansen
2018-11-26 18:04   ` Borislav Petkov
2018-11-26 18:04     ` Borislav Petkov
2018-11-26 18:04     ` Borislav Petkov
2018-11-26 18:54 ` Dave Hansen
2018-11-26 18:54   ` Dave Hansen
2018-11-26 18:54   ` Dave Hansen
2018-11-26 18:54   ` Dave Hansen
2018-11-27  2:58   ` lijiang [this message]
2018-11-27  2:58     ` lijiang
2018-11-27  2:58     ` lijiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=463c284b-115e-0784-ca07-a430127e6176@redhat.com \
    --to=lijiang@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=bhe@redhat.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=dyoung@redhat.com \
    --cc=fenghua.yu@intel.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.