All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: lijiang <lijiang@redhat.com>, linux-kernel@vger.kernel.org
Cc: kexec@lists.infradead.org, x86@kernel.org,
	linux-ia64@vger.kernel.org, linux-efi@vger.kernel.org,
	tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	akpm@linux-foundation.org, dave.hansen@linux.intel.com,
	luto@kernel.org, peterz@infradead.org, ard.biesheuvel@linaro.org,
	tony.luck@intel.com, fenghua.yu@intel.com, dyoung@redhat.com,
	bhe@redhat.com
Subject: Re: [PATCH 1/2 RESEND v7] resource: add the new I/O resource descriptor 'IORES_DESC_RESERVED'
Date: Tue, 27 Nov 2018 07:34:16 -0800	[thread overview]
Message-ID: <703ce20d-be09-9b8d-d457-5b002a50dff7@intel.com> (raw)
In-Reply-To: <460c5552-a48e-3523-275a-7f94d0f08f9b@redhat.com>

On 11/27/18 2:04 AM, lijiang wrote:
> What happens if we don't modify this functions
> __ioremap_check_desc_other()? -When SEV is active, it might map these
> reserved regions with the encryption mask. That is incorrect. 

This is missing another sentence or two to "connect the dots".

SEV uses data that comes from the e820 table to tell whether or not the
memory should be encrypted?  If we don't reflect these reserved areas in
the e820 table, the SEV code will set up encrypted mappings for device
memory, for instance?

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: lijiang <lijiang@redhat.com>, linux-kernel@vger.kernel.org
Cc: fenghua.yu@intel.com, linux-efi@vger.kernel.org,
	linux-ia64@vger.kernel.org, bhe@redhat.com,
	ard.biesheuvel@linaro.org, peterz@infradead.org, x86@kernel.org,
	kexec@lists.infradead.org, tony.luck@intel.com,
	dave.hansen@linux.intel.com, mingo@redhat.com, bp@alien8.de,
	luto@kernel.org, tglx@linutronix.de, dyoung@redhat.com,
	akpm@linux-foundation.org
Subject: Re: [PATCH 1/2 RESEND v7] resource: add the new I/O resource descriptor 'IORES_DESC_RESERVED'
Date: Tue, 27 Nov 2018 07:34:16 -0800	[thread overview]
Message-ID: <703ce20d-be09-9b8d-d457-5b002a50dff7@intel.com> (raw)
In-Reply-To: <460c5552-a48e-3523-275a-7f94d0f08f9b@redhat.com>

On 11/27/18 2:04 AM, lijiang wrote:
> What happens if we don't modify this functions
> __ioremap_check_desc_other()? -When SEV is active, it might map these
> reserved regions with the encryption mask. That is incorrect. 

This is missing another sentence or two to "connect the dots".

SEV uses data that comes from the e820 table to tell whether or not the
memory should be encrypted?  If we don't reflect these reserved areas in
the e820 table, the SEV code will set up encrypted mappings for device
memory, for instance?

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: lijiang <lijiang@redhat.com>, linux-kernel@vger.kernel.org
Cc: kexec@lists.infradead.org, x86@kernel.org,
	linux-ia64@vger.kernel.org, linux-efi@vger.kernel.org,
	tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	akpm@linux-foundation.org, dave.hansen@linux.intel.com,
	luto@kernel.org, peterz@infradead.org, ard.biesheuvel@linaro.org,
	tony.luck@intel.com, fenghua.yu@intel.com, dyoung@redhat.com,
	bhe@redhat.com
Subject: Re: [PATCH 1/2 RESEND v7] resource: add the new I/O resource descriptor 'IORES_DESC_RESERVED'
Date: Tue, 27 Nov 2018 15:34:16 +0000	[thread overview]
Message-ID: <703ce20d-be09-9b8d-d457-5b002a50dff7@intel.com> (raw)
In-Reply-To: <460c5552-a48e-3523-275a-7f94d0f08f9b@redhat.com>

On 11/27/18 2:04 AM, lijiang wrote:
> What happens if we don't modify this functions
> __ioremap_check_desc_other()? -When SEV is active, it might map these
> reserved regions with the encryption mask. That is incorrect. 

This is missing another sentence or two to "connect the dots".

SEV uses data that comes from the e820 table to tell whether or not the
memory should be encrypted?  If we don't reflect these reserved areas in
the e820 table, the SEV code will set up encrypted mappings for device
memory, for instance?

  reply	other threads:[~2018-11-27 15:34 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-24  5:12 [PATCH 0/2 RESEND v7] add reserved e820 ranges to the kdump kernel e820 table Lianbo Jiang
2018-11-24  5:12 ` Lianbo Jiang
2018-11-24  5:12 ` Lianbo Jiang
2018-11-24  5:12 ` [PATCH 1/2 RESEND v7] resource: add the new I/O resource descriptor 'IORES_DESC_RESERVED' Lianbo Jiang
2018-11-24  5:12   ` Lianbo Jiang
2018-11-24  5:12   ` Lianbo Jiang
2018-11-26 20:52   ` Dave Hansen
2018-11-26 20:52     ` Dave Hansen
2018-11-26 20:52     ` Dave Hansen
2018-11-27 10:04     ` lijiang
2018-11-27 10:04       ` lijiang
2018-11-27 10:04       ` lijiang
2018-11-27 15:34       ` Dave Hansen [this message]
2018-11-27 15:34         ` Dave Hansen
2018-11-27 15:34         ` Dave Hansen
2018-11-28  3:51         ` lijiang
2018-11-28  3:51           ` lijiang
2018-11-28  3:51           ` lijiang
2018-11-28 16:02           ` Dave Hansen
2018-11-28 16:02             ` Dave Hansen
2018-11-28 16:02             ` Dave Hansen
2018-11-28 16:02             ` Dave Hansen
2018-11-29  2:14             ` lijiang
2018-11-29  2:14               ` lijiang
2018-11-29  2:14               ` lijiang
2018-11-24  5:12 ` [PATCH 2/2 RESEND v7] x86/kexec_file: add reserved e820 ranges to kdump kernel e820 table Lianbo Jiang
2018-11-24  5:12   ` Lianbo Jiang
2018-11-24  5:12   ` Lianbo Jiang
2018-11-26 17:44 ` [PATCH 0/2 RESEND v7] add reserved e820 ranges to the " Dave Hansen
2018-11-26 17:44   ` Dave Hansen
2018-11-26 17:44   ` Dave Hansen
2018-11-26 18:04   ` Borislav Petkov
2018-11-26 18:04     ` Borislav Petkov
2018-11-26 18:04     ` Borislav Petkov
2018-11-26 18:54 ` Dave Hansen
2018-11-26 18:54   ` Dave Hansen
2018-11-26 18:54   ` Dave Hansen
2018-11-26 18:54   ` Dave Hansen
2018-11-27  2:58   ` lijiang
2018-11-27  2:58     ` lijiang
2018-11-27  2:58     ` lijiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=703ce20d-be09-9b8d-d457-5b002a50dff7@intel.com \
    --to=dave.hansen@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=bhe@redhat.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=dyoung@redhat.com \
    --cc=fenghua.yu@intel.com \
    --cc=kexec@lists.infradead.org \
    --cc=lijiang@redhat.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.