[Buildroot] [PATCH] package/libgeos: disable package if binutils is affected from bug 21464

[Buildroot] [PATCH] package/libgeos: disable package if binutils is affected from bug 21464

[Giulio Benetti]

This package is affected from binutils bug 21464, since there is no
workaround, let's disable it.

Fixes:
http://autobuild.buildroot.net/results/3eb/3eb9f9d0f6d8274b2d19753c006bd83f7d536e3c/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
This patch must be applied after this patchset:
https://patchwork.ozlabs.org/project/buildroot/list/?series=232409
---
 package/libgeos/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/libgeos/Config.in b/package/libgeos/Config.in
index 2caf6d1d5e..bbcafe7740 100644
--- a/package/libgeos/Config.in
+++ b/package/libgeos/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_LIBGEOS
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_USE_WCHAR
 	depends on !BR2_nios2
+	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
 	help
 	  GEOS (Geometry Engine - Open Source) is a C++ port of the
 	  JTS Topology Suite (JTS). It aims to contain the complete
@@ -14,4 +15,4 @@ config BR2_PACKAGE_LIBGEOS
 
 comment "libgeos needs a toolchain w/ C++, wchar"
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
-	depends on !BR2_nios2
+	depends on !BR2_nios2 || !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
-- 
2.25.1

[Buildroot] [PATCH] package/libgeos: disable package if binutils is affected from bug 21464

[Thomas Petazzoni]

On Sun,  7 Mar 2021 18:52:14 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> This package is affected from binutils bug 21464, since there is no
> workaround, let's disable it.
> 
> Fixes:
> http://autobuild.buildroot.net/results/3eb/3eb9f9d0f6d8274b2d19753c006bd83f7d536e3c/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> This patch must be applied after this patchset:
> https://patchwork.ozlabs.org/project/buildroot/list/?series=232409
> ---
>  package/libgeos/Config.in | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

I've applied. However, it's a bit inconsistent that we fixed this for
OpenRISC with a proper BR2_TOOLCHAIN_HAS_BINUTILS_BUG_xyz, but for
NIOS2 it is globally disabled for BR2_nios2.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597

[Giulio Benetti]

On Nios II binutils it still present ld bug 27597 leading to a package
libgeos to fail building:
http://autobuild.buildroot.net/results/a05fdf1958f93a206c5c66c7f636b6650683626d/http://autobuild.buildroot.net/results/c05/c053b9e191b31f0b1f8f8c902b602e187f714dc0/

The bug was already reported and it's been updated:
https://sourceware.org/bugzilla/show_bug.cgi?id=27597

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 toolchain/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/toolchain/Config.in b/toolchain/Config.in
index 5c76bdf4ea..87f4d486a3 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -83,6 +83,12 @@ config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27100
 	bool
 	default y if BR2_or1k && !BR2_BINUTILS_VERSION_2_36_X
 
+# https://sourceware.org/bugzilla/show_bug.cgi?id=27597
+# Affect toolchains built with binutils 2.36.1, still not fixed.
+config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
+	bool
+	default y if BR2_nios2
+
 # Atomic types can be:
 #  - never lock-free
 #  - sometimes lock-free
-- 
2.25.1

[Buildroot] [PATCH 2/2] package/libgeos: use specific bug instead of BR2_nios2 to disable package

[Giulio Benetti]

Let's use the _BUG_ form for disabling this package instead of BR2_nios2
architecture as we already use it for other packages.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/libgeos/Config.in | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/package/libgeos/Config.in b/package/libgeos/Config.in
index bbcafe7740..8759d2011e 100644
--- a/package/libgeos/Config.in
+++ b/package/libgeos/Config.in
@@ -2,7 +2,7 @@ config BR2_PACKAGE_LIBGEOS
 	bool "libgeos"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_USE_WCHAR
-	depends on !BR2_nios2
+	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
 	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
 	help
 	  GEOS (Geometry Engine - Open Source) is a C++ port of the
@@ -14,5 +14,6 @@ config BR2_PACKAGE_LIBGEOS
 	  https://trac.osgeo.org/geos
 
 comment "libgeos needs a toolchain w/ C++, wchar"
-	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
-	depends on !BR2_nios2 || !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
+		   !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 || \
+		   !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
-- 
2.25.1

[Buildroot] [PATCH 2/2] package/libgeos: use specific bug instead of BR2_nios2 to disable package

[Arnout Vandecappelle]

On 17/03/2021 17:34, Giulio Benetti wrote:
> Let's use the _BUG_ form for disabling this package instead of BR2_nios2
> architecture as we already use it for other packages.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

 Applied to master, thanks. I made the following changes:

     - put 27597 after 21464 instead of before it;
     - propagate dependency to postgis;
     - mention the bugs in the comments.

postgis didn't exist yet at the time so that's no surpise... The rest is nitpicking.


 Regards,
 Arnout

> ---
>  package/libgeos/Config.in | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/package/libgeos/Config.in b/package/libgeos/Config.in
> index bbcafe7740..8759d2011e 100644
> --- a/package/libgeos/Config.in
> +++ b/package/libgeos/Config.in
> @@ -2,7 +2,7 @@ config BR2_PACKAGE_LIBGEOS
>  	bool "libgeos"
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_USE_WCHAR
> -	depends on !BR2_nios2
> +	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
>  	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
>  	help
>  	  GEOS (Geometry Engine - Open Source) is a C++ port of the
> @@ -14,5 +14,6 @@ config BR2_PACKAGE_LIBGEOS
>  	  https://trac.osgeo.org/geos
>  
>  comment "libgeos needs a toolchain w/ C++, wchar"
> -	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
> -	depends on !BR2_nios2 || !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
> +		   !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 || \
> +		   !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
> 

[Buildroot] [PATCH 2/2] package/libgeos: use specific bug instead of BR2_nios2 to disable package

[Peter Korsgaard]

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

 > On 17/03/2021 17:34, Giulio Benetti wrote:
 >> Let's use the _BUG_ form for disabling this package instead of BR2_nios2
 >> architecture as we already use it for other packages.
 >> 
 >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

 >  Applied to master, thanks. I made the following changes:

 >      - put 27597 after 21464 instead of before it;
 >      - propagate dependency to postgis;
 >      - mention the bugs in the comments.

 > postgis didn't exist yet at the time so that's no surpise... The rest is nitpicking.

Committed to 2021.02.x (without the postgis hunk), thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597

[Arnout Vandecappelle]

On 17/03/2021 17:34, Giulio Benetti wrote:
> On Nios II binutils it still present ld bug 27597 leading to a package
> libgeos to fail building:
> http://autobuild.buildroot.net/results/a05fdf1958f93a206c5c66c7f636b6650683626d/http://autobuild.buildroot.net/results/c05/c053b9e191b31f0b1f8f8c902b602e187f714dc0/
> 
> The bug was already reported and it's been updated:
> https://sourceware.org/bugzilla/show_bug.cgi?id=27597
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

 Applied to master, thanks.

 Regards,
 Arnout

> ---
>  toolchain/Config.in | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/toolchain/Config.in b/toolchain/Config.in
> index 5c76bdf4ea..87f4d486a3 100644
> --- a/toolchain/Config.in
> +++ b/toolchain/Config.in
> @@ -83,6 +83,12 @@ config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27100
>  	bool
>  	default y if BR2_or1k && !BR2_BINUTILS_VERSION_2_36_X
>  
> +# https://sourceware.org/bugzilla/show_bug.cgi?id=27597
> +# Affect toolchains built with binutils 2.36.1, still not fixed.
> +config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
> +	bool
> +	default y if BR2_nios2
> +
>  # Atomic types can be:
>  #  - never lock-free
>  #  - sometimes lock-free
> 

[Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597

[Peter Korsgaard]

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

 > On 17/03/2021 17:34, Giulio Benetti wrote:
 >> On Nios II binutils it still present ld bug 27597 leading to a package
 >> libgeos to fail building:
 >> http://autobuild.buildroot.net/results/a05fdf1958f93a206c5c66c7f636b6650683626d/http://autobuild.buildroot.net/results/c05/c053b9e191b31f0b1f8f8c902b602e187f714dc0/
 >> 
 >> The bug was already reported and it's been updated:
 >> https://sourceware.org/bugzilla/show_bug.cgi?id=27597
 >> 
 >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Committed to 2021.02.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] package/libgeos: disable package if binutils is affected from bug 21464

[Peter Korsgaard]

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > This package is affected from binutils bug 21464, since there is no
 > workaround, let's disable it.

 > Fixes:
 > http://autobuild.buildroot.net/results/3eb/3eb9f9d0f6d8274b2d19753c006bd83f7d536e3c/

 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
 > ---
 > This patch must be applied after this patchset:
 > https://patchwork.ozlabs.org/project/buildroot/list/?series=232409

Committed to 2021.02.x, thanks.

-- 
Bye, Peter Korsgaard