From: Ulrich Hecht <uli@fpond.eu>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/4] arm64: dts: renesas: rcar-gen3: Add reset control properties for display
Date: Wed, 19 Feb 2020 12:00:06 +0100 (CET) [thread overview]
Message-ID: <465772718.273222.1582110006831@webmail.strato.com> (raw)
In-Reply-To: <20200218133019.22299-4-geert+renesas@glider.be>
> On February 18, 2020 at 2:30 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>
>
> Add reset control properties to the device nodes for the Display Units
> on all supported R-Car Gen3 SoCs. Note that on these SoCs, there is
> only a single reset for each pair of DU channels.
>
> The display nodes on R-Car V3M and V3H already had "resets" properties,
> but lacked the corresponding "reset-names" properties.
>
> Join the clocks lines while at it, to increase uniformity.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
> - Use "du.0" resp. "du.2" instead of "du.0-1" resp. "du.2-3",
> - Drop LVDS reset, as LVDS is now a separate node,
> - Add other R-Car Gen3 SoCs.
> ---
> arch/arm64/boot/dts/renesas/r8a77951.dtsi | 8 ++++----
> arch/arm64/boot/dts/renesas/r8a77960.dtsi | 5 +++--
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 5 +++--
> arch/arm64/boot/dts/renesas/r8a77970.dtsi | 1 +
> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 1 +
> arch/arm64/boot/dts/renesas/r8a77990.dtsi | 3 +--
> arch/arm64/boot/dts/renesas/r8a77995.dtsi | 3 +--
> 7 files changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77951.dtsi b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> index 27cbe697490c7c78..52229546454c400a 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> @@ -3177,11 +3177,11 @@
> <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cpg CPG_MOD 724>,
> - <&cpg CPG_MOD 723>,
> - <&cpg CPG_MOD 722>,
> - <&cpg CPG_MOD 721>;
> + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>,
> + <&cpg CPG_MOD 722>, <&cpg CPG_MOD 721>;
> clock-names = "du.0", "du.1", "du.2", "du.3";
> + resets = <&cpg 724>, <&cpg 722>;
> + reset-names = "du.0", "du.2";
>
> renesas,cmms = <&cmm0>, <&cmm1>, <&cmm2>, <&cmm3>;
> renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>,
> diff --git a/arch/arm64/boot/dts/renesas/r8a77960.dtsi b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> index ea03b91bdf9d9cbc..31282367d3acd8cf 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> @@ -2827,10 +2827,11 @@
> interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cpg CPG_MOD 724>,
> - <&cpg CPG_MOD 723>,
> + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>,
> <&cpg CPG_MOD 722>;
> clock-names = "du.0", "du.1", "du.2";
> + resets = <&cpg 724>, <&cpg 722>;
> + reset-names = "du.0", "du.2";
>
> renesas,cmms = <&cmm0>, <&cmm1>, <&cmm2>;
> renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> index 1a20ebe9ea5be5da..f7468822e81e41d6 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -2503,10 +2503,11 @@
> interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cpg CPG_MOD 724>,
> - <&cpg CPG_MOD 723>,
> + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>,
> <&cpg CPG_MOD 721>;
> clock-names = "du.0", "du.1", "du.3";
> + resets = <&cpg 724>, <&cpg 722>;
> + reset-names = "du.0", "du.3";
>
> renesas,cmms = <&cmm0>, <&cmm1>, <&cmm3>;
> renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd0 1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> index dbf1c677dbc6e51f..a009c0ebc8b4f8d0 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -1121,6 +1121,7 @@
> clock-names = "du.0";
> power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
> resets = <&cpg 724>;
> + reset-names = "du.0";
> renesas,vsps = <&vspd0 0>;
>
> status = "disabled";
> diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> index 9444347e61eb881d..e01b0508a18fa91a 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> @@ -1491,6 +1491,7 @@
> clock-names = "du.0";
> power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
> resets = <&cpg 724>;
> + reset-names = "du.0";
> renesas,vsps = <&vspd0 0>;
>
> status = "disabled";
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> index c05ee98043b2c7a5..0ad20b78e6eb62fd 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> @@ -1793,8 +1793,7 @@
> reg = <0 0xfeb00000 0 0x40000>;
> interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cpg CPG_MOD 724>,
> - <&cpg CPG_MOD 723>;
> + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>;
> clock-names = "du.0", "du.1";
> resets = <&cpg 724>;
> reset-names = "du.0";
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> index 7d3102dccac96e42..e8d2290fe79d761a 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> @@ -1026,8 +1026,7 @@
> reg = <0 0xfeb00000 0 0x40000>;
> interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cpg CPG_MOD 724>,
> - <&cpg CPG_MOD 723>;
> + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>;
> clock-names = "du.0", "du.1";
> resets = <&cpg 724>;
> reset-names = "du.0";
> --
> 2.17.1
>
Reviewed-by: Ulrich Hecht <uli+renesas@fpond.eu>
CU
Uli
WARNING: multiple messages have this Message-ID (diff)
From: Ulrich Hecht <uli@fpond.eu>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>
Cc: linux-renesas-soc@vger.kernel.org,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/4] arm64: dts: renesas: rcar-gen3: Add reset control properties for display
Date: Wed, 19 Feb 2020 12:00:06 +0100 (CET) [thread overview]
Message-ID: <465772718.273222.1582110006831@webmail.strato.com> (raw)
In-Reply-To: <20200218133019.22299-4-geert+renesas@glider.be>
> On February 18, 2020 at 2:30 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>
>
> Add reset control properties to the device nodes for the Display Units
> on all supported R-Car Gen3 SoCs. Note that on these SoCs, there is
> only a single reset for each pair of DU channels.
>
> The display nodes on R-Car V3M and V3H already had "resets" properties,
> but lacked the corresponding "reset-names" properties.
>
> Join the clocks lines while at it, to increase uniformity.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
> - Use "du.0" resp. "du.2" instead of "du.0-1" resp. "du.2-3",
> - Drop LVDS reset, as LVDS is now a separate node,
> - Add other R-Car Gen3 SoCs.
> ---
> arch/arm64/boot/dts/renesas/r8a77951.dtsi | 8 ++++----
> arch/arm64/boot/dts/renesas/r8a77960.dtsi | 5 +++--
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 5 +++--
> arch/arm64/boot/dts/renesas/r8a77970.dtsi | 1 +
> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 1 +
> arch/arm64/boot/dts/renesas/r8a77990.dtsi | 3 +--
> arch/arm64/boot/dts/renesas/r8a77995.dtsi | 3 +--
> 7 files changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77951.dtsi b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> index 27cbe697490c7c78..52229546454c400a 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> @@ -3177,11 +3177,11 @@
> <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cpg CPG_MOD 724>,
> - <&cpg CPG_MOD 723>,
> - <&cpg CPG_MOD 722>,
> - <&cpg CPG_MOD 721>;
> + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>,
> + <&cpg CPG_MOD 722>, <&cpg CPG_MOD 721>;
> clock-names = "du.0", "du.1", "du.2", "du.3";
> + resets = <&cpg 724>, <&cpg 722>;
> + reset-names = "du.0", "du.2";
>
> renesas,cmms = <&cmm0>, <&cmm1>, <&cmm2>, <&cmm3>;
> renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>,
> diff --git a/arch/arm64/boot/dts/renesas/r8a77960.dtsi b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> index ea03b91bdf9d9cbc..31282367d3acd8cf 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> @@ -2827,10 +2827,11 @@
> interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cpg CPG_MOD 724>,
> - <&cpg CPG_MOD 723>,
> + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>,
> <&cpg CPG_MOD 722>;
> clock-names = "du.0", "du.1", "du.2";
> + resets = <&cpg 724>, <&cpg 722>;
> + reset-names = "du.0", "du.2";
>
> renesas,cmms = <&cmm0>, <&cmm1>, <&cmm2>;
> renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> index 1a20ebe9ea5be5da..f7468822e81e41d6 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -2503,10 +2503,11 @@
> interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cpg CPG_MOD 724>,
> - <&cpg CPG_MOD 723>,
> + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>,
> <&cpg CPG_MOD 721>;
> clock-names = "du.0", "du.1", "du.3";
> + resets = <&cpg 724>, <&cpg 722>;
> + reset-names = "du.0", "du.3";
>
> renesas,cmms = <&cmm0>, <&cmm1>, <&cmm3>;
> renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd0 1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> index dbf1c677dbc6e51f..a009c0ebc8b4f8d0 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -1121,6 +1121,7 @@
> clock-names = "du.0";
> power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
> resets = <&cpg 724>;
> + reset-names = "du.0";
> renesas,vsps = <&vspd0 0>;
>
> status = "disabled";
> diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> index 9444347e61eb881d..e01b0508a18fa91a 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> @@ -1491,6 +1491,7 @@
> clock-names = "du.0";
> power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
> resets = <&cpg 724>;
> + reset-names = "du.0";
> renesas,vsps = <&vspd0 0>;
>
> status = "disabled";
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> index c05ee98043b2c7a5..0ad20b78e6eb62fd 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> @@ -1793,8 +1793,7 @@
> reg = <0 0xfeb00000 0 0x40000>;
> interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cpg CPG_MOD 724>,
> - <&cpg CPG_MOD 723>;
> + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>;
> clock-names = "du.0", "du.1";
> resets = <&cpg 724>;
> reset-names = "du.0";
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> index 7d3102dccac96e42..e8d2290fe79d761a 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> @@ -1026,8 +1026,7 @@
> reg = <0 0xfeb00000 0 0x40000>;
> interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cpg CPG_MOD 724>,
> - <&cpg CPG_MOD 723>;
> + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>;
> clock-names = "du.0", "du.1";
> resets = <&cpg 724>;
> reset-names = "du.0";
> --
> 2.17.1
>
Reviewed-by: Ulrich Hecht <uli+renesas@fpond.eu>
CU
Uli
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-19 11:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 13:30 [PATCH v2 0/4] arm: dts: renesas: Add reset control properties for display Geert Uytterhoeven
2020-02-18 13:30 ` Geert Uytterhoeven
2020-02-18 13:30 ` [PATCH v2 1/4] ARM: dts: rcar-gen2: " Geert Uytterhoeven
2020-02-18 13:30 ` Geert Uytterhoeven
2020-02-19 10:59 ` Ulrich Hecht
2020-02-19 10:59 ` Ulrich Hecht
2020-02-19 15:27 ` Laurent Pinchart
2020-02-19 15:27 ` Laurent Pinchart
2020-02-19 15:30 ` Geert Uytterhoeven
2020-02-19 15:30 ` Geert Uytterhoeven
2020-02-18 13:30 ` [PATCH v2 2/4] ARM: dts: rzg1: " Geert Uytterhoeven
2020-02-18 13:30 ` Geert Uytterhoeven
2020-02-19 10:59 ` Ulrich Hecht
2020-02-19 10:59 ` Ulrich Hecht
2020-02-19 15:28 ` Laurent Pinchart
2020-02-19 15:28 ` Laurent Pinchart
2020-02-18 13:30 ` [PATCH v2 3/4] arm64: dts: renesas: rcar-gen3: " Geert Uytterhoeven
2020-02-18 13:30 ` Geert Uytterhoeven
2020-02-19 11:00 ` Ulrich Hecht [this message]
2020-02-19 11:00 ` Ulrich Hecht
2020-02-19 15:33 ` Laurent Pinchart
2020-02-19 15:33 ` Laurent Pinchart
2020-02-19 15:55 ` Geert Uytterhoeven
2020-02-19 15:55 ` Geert Uytterhoeven
2020-02-19 16:06 ` Laurent Pinchart
2020-02-19 16:06 ` Laurent Pinchart
2020-02-18 13:30 ` [PATCH v2 4/4] arm64: dts: renesas: rzg2: " Geert Uytterhoeven
2020-02-18 13:30 ` Geert Uytterhoeven
2020-02-19 11:01 ` Ulrich Hecht
2020-02-19 11:01 ` Ulrich Hecht
2020-02-19 15:40 ` Laurent Pinchart
2020-02-19 15:40 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465772718.273222.1582110006831@webmail.strato.com \
--to=uli@fpond.eu \
--cc=geert+renesas@glider.be \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.