All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lokesh Vutla <lokeshvutla@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [u-boot PATCH v2 6/8] ARM: Use Kconfig for board EEPROM's I2C bus and chip address
Date: Tue, 31 Jan 2017 09:47:19 +0530	[thread overview]
Message-ID: <46904e6c-9099-4cce-b6cc-fa457bbd4b43@ti.com> (raw)
In-Reply-To: <1485789316-22216-7-git-send-email-rogerq@ti.com>



On Monday 30 January 2017 08:45 PM, Roger Quadros wrote:
> In stead of defining the board EEPROM address in the board headers
> let's define them in the board config files and make them
> configurable by Kconfig.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>  arch/arm/Kconfig                  | 10 ++++++++++
>  configs/am57xx_evm_defconfig      |  2 ++
>  configs/am57xx_evm_nodt_defconfig |  2 ++
>  configs/am57xx_hs_evm_defconfig   |  2 ++
>  configs/dra7xx_evm_defconfig      |  2 ++
>  configs/dra7xx_hs_evm_defconfig   |  2 ++
>  include/configs/am57xx_evm.h      |  4 ----
>  include/configs/dra7xx_evm.h      |  4 ----
>  8 files changed, 20 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index c04adfb..19886ad 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1009,6 +1009,16 @@ config TARGET_THUNDERX_88XX
>  
>  endchoice
>  
> +config EEPROM_BUS_ADDRESS
> +        int "Board EEPROM's I2C bus address"
> +        range 0 8
> +        default 0
> +
> +config EEPROM_CHIP_ADDRESS
> +        hex "Board EEPROM's I2C chip address"
> +        range 0 0xff
> +        default 0x50
> +

IMO, these should be placed in board/ti/common/Kconfig. Also need not
specify the value explicitly in defconfig if default value is used.

Thanks and regards,
Lokesh

>  source "arch/arm/mach-at91/Kconfig"
>  
>  source "arch/arm/mach-bcm283x/Kconfig"
> diff --git a/configs/am57xx_evm_defconfig b/configs/am57xx_evm_defconfig
> index 656d991..3b3e74a 100644
> --- a/configs/am57xx_evm_defconfig
> +++ b/configs/am57xx_evm_defconfig
> @@ -2,6 +2,8 @@ CONFIG_ARM=y
>  CONFIG_OMAP54XX=y
>  # CONFIG_SPL_NAND_SUPPORT is not set
>  CONFIG_TARGET_AM57XX_EVM=y
> +CONFIG_EEPROM_BUS_ADDRESS=0
> +CONFIG_EEPROM_CHIP_ADDRESS=0x50
>  CONFIG_SPL_SPI_FLASH_SUPPORT=y
>  CONFIG_SPL_SPI_SUPPORT=y
>  CONFIG_ARMV7_LPAE=y
> diff --git a/configs/am57xx_evm_nodt_defconfig b/configs/am57xx_evm_nodt_defconfig
> index b3b95f9..8d722e7 100644
> --- a/configs/am57xx_evm_nodt_defconfig
> +++ b/configs/am57xx_evm_nodt_defconfig
> @@ -2,6 +2,8 @@ CONFIG_ARM=y
>  CONFIG_OMAP54XX=y
>  # CONFIG_SPL_NAND_SUPPORT is not set
>  CONFIG_TARGET_AM57XX_EVM=y
> +CONFIG_EEPROM_BUS_ADDRESS=0
> +CONFIG_EEPROM_CHIP_ADDRESS=0x50
>  CONFIG_SPL_SPI_FLASH_SUPPORT=y
>  CONFIG_SPL_SPI_SUPPORT=y
>  CONFIG_SYS_CONSOLE_INFO_QUIET=y
> diff --git a/configs/am57xx_hs_evm_defconfig b/configs/am57xx_hs_evm_defconfig
> index d920d68..36c8004 100644
> --- a/configs/am57xx_hs_evm_defconfig
> +++ b/configs/am57xx_hs_evm_defconfig
> @@ -3,6 +3,8 @@ CONFIG_OMAP54XX=y
>  CONFIG_TI_SECURE_DEVICE=y
>  # CONFIG_SPL_NAND_SUPPORT is not set
>  CONFIG_TARGET_AM57XX_EVM=y
> +CONFIG_EEPROM_BUS_ADDRESS=0
> +CONFIG_EEPROM_CHIP_ADDRESS=0x50
>  CONFIG_TI_SECURE_EMIF_REGION_START=0xbe000000
>  CONFIG_TI_SECURE_EMIF_TOTAL_REGION_SIZE=0x02000000
>  CONFIG_TI_SECURE_EMIF_PROTECTED_REGION_SIZE=0x01c00000
> diff --git a/configs/dra7xx_evm_defconfig b/configs/dra7xx_evm_defconfig
> index 1836021..3108c58 100644
> --- a/configs/dra7xx_evm_defconfig
> +++ b/configs/dra7xx_evm_defconfig
> @@ -2,6 +2,8 @@ CONFIG_ARM=y
>  CONFIG_OMAP54XX=y
>  # CONFIG_SPL_NAND_SUPPORT is not set
>  CONFIG_TARGET_DRA7XX_EVM=y
> +CONFIG_EEPROM_BUS_ADDRESS=0
> +CONFIG_EEPROM_CHIP_ADDRESS=0x50
>  CONFIG_SPL_SPI_FLASH_SUPPORT=y
>  CONFIG_SPL_SPI_SUPPORT=y
>  CONFIG_ARMV7_LPAE=y
> diff --git a/configs/dra7xx_hs_evm_defconfig b/configs/dra7xx_hs_evm_defconfig
> index 1d107e4..7f5ce49 100644
> --- a/configs/dra7xx_hs_evm_defconfig
> +++ b/configs/dra7xx_hs_evm_defconfig
> @@ -4,6 +4,8 @@ CONFIG_SYS_MALLOC_F_LEN=0x2000
>  CONFIG_TI_SECURE_DEVICE=y
>  # CONFIG_SPL_NAND_SUPPORT is not set
>  CONFIG_TARGET_DRA7XX_EVM=y
> +CONFIG_EEPROM_BUS_ADDRESS=0
> +CONFIG_EEPROM_CHIP_ADDRESS=0x50
>  CONFIG_TI_SECURE_EMIF_REGION_START=0xbe000000
>  CONFIG_TI_SECURE_EMIF_TOTAL_REGION_SIZE=0x02000000
>  CONFIG_TI_SECURE_EMIF_PROTECTED_REGION_SIZE=0x01c00000
> diff --git a/include/configs/am57xx_evm.h b/include/configs/am57xx_evm.h
> index 840502c..d9e1119 100644
> --- a/include/configs/am57xx_evm.h
> +++ b/include/configs/am57xx_evm.h
> @@ -105,10 +105,6 @@
>  #define CONFIG_SYS_SCSI_MAX_DEVICE	(CONFIG_SYS_SCSI_MAX_SCSI_ID * \
>  						CONFIG_SYS_SCSI_MAX_LUN)
>  
> -/* EEPROM */
> -#define CONFIG_EEPROM_CHIP_ADDRESS 0x50
> -#define CONFIG_EEPROM_BUS_ADDRESS 0
> -
>  /*
>   * Default to using SPI for environment, etc.
>   * 0x000000 - 0x040000 : QSPI.SPL (256KiB)
> diff --git a/include/configs/dra7xx_evm.h b/include/configs/dra7xx_evm.h
> index da458a4..46beb8b 100644
> --- a/include/configs/dra7xx_evm.h
> +++ b/include/configs/dra7xx_evm.h
> @@ -264,8 +264,4 @@
>  #endif
>  #endif  /* NOR support */
>  
> -/* EEPROM */
> -#define CONFIG_EEPROM_CHIP_ADDRESS 0x50
> -#define CONFIG_EEPROM_BUS_ADDRESS 0
> -
>  #endif /* __CONFIG_DRA7XX_EVM_H */
> 

  reply	other threads:[~2017-01-31  4:17 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-30 15:15 [U-Boot] [u-boot PATCH v2 0/8] am57xx-idk LCD and am571x-idk 6 port ethernet pinmux Roger Quadros
2017-01-30 15:15 ` [U-Boot] [u-boot PATCH v2 1/8] ARM: OMAP5+: GPIO: Add GPIO_TO_PIN() macro Roger Quadros
2017-01-31  4:08   ` Lokesh Vutla
2017-01-30 15:15 ` [U-Boot] [u-boot PATCH v2 2/8] ti: common: board_detect: commodify ethaddr environment setting code Roger Quadros
2017-01-31  4:08   ` Lokesh Vutla
2017-01-31 21:38   ` Tom Rini
2017-01-30 15:15 ` [U-Boot] [u-boot PATCH v2 3/8] board: ti: am571x-idk: Support 6 port Ethernet or 4 port Ethernet with LCD Roger Quadros
2017-01-31  4:10   ` Lokesh Vutla
2017-01-30 15:15 ` [U-Boot] [u-boot PATCH v2 4/8] board: ti: am571x-idk: Update pinmux for ICSS2 Ethernet Roger Quadros
2017-01-31  4:10   ` Lokesh Vutla
2017-01-30 15:15 ` [U-Boot] [u-boot PATCH v2 5/8] board: ti: am57xx-idk: Auto detect LCD Panel Roger Quadros
2017-01-30 15:15 ` [U-Boot] [u-boot PATCH v2 6/8] ARM: Use Kconfig for board EEPROM's I2C bus and chip address Roger Quadros
2017-01-31  4:17   ` Lokesh Vutla [this message]
2017-02-01  9:42     ` Roger Quadros
2017-02-01 10:47       ` Lokesh Vutla
2017-02-01 12:01         ` Roger Quadros
2017-02-01 12:14           ` Tom Rini
2017-02-01 13:05             ` Roger Quadros
2017-02-01 13:44               ` Tom Rini
2017-01-30 15:15 ` [U-Boot] [u-boot PATCH v2 7/8] ARM: k2g: setup PRU ethernet MAC addresses Roger Quadros
2017-01-31  4:18   ` Lokesh Vutla
2017-01-30 15:15 ` [U-Boot] [u-boot PATCH v2 8/8] ti: common: board_detect: Rename EEPROM scratch start macro Roger Quadros
2017-01-31 21:38   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46904e6c-9099-4cce-b6cc-fa457bbd4b43@ti.com \
    --to=lokeshvutla@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.