All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [u-boot PATCH v2 6/8] ARM: Use Kconfig for board EEPROM's I2C bus and chip address
Date: Wed, 1 Feb 2017 11:42:31 +0200	[thread overview]
Message-ID: <4b608991-cc94-be87-a25d-cf3db8b999f1@ti.com> (raw)
In-Reply-To: <46904e6c-9099-4cce-b6cc-fa457bbd4b43@ti.com>

On 31/01/17 06:17, Lokesh Vutla wrote:
> 
> 
> On Monday 30 January 2017 08:45 PM, Roger Quadros wrote:
>> In stead of defining the board EEPROM address in the board headers
>> let's define them in the board config files and make them
>> configurable by Kconfig.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>>  arch/arm/Kconfig                  | 10 ++++++++++
>>  configs/am57xx_evm_defconfig      |  2 ++
>>  configs/am57xx_evm_nodt_defconfig |  2 ++
>>  configs/am57xx_hs_evm_defconfig   |  2 ++
>>  configs/dra7xx_evm_defconfig      |  2 ++
>>  configs/dra7xx_hs_evm_defconfig   |  2 ++
>>  include/configs/am57xx_evm.h      |  4 ----
>>  include/configs/dra7xx_evm.h      |  4 ----
>>  8 files changed, 20 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index c04adfb..19886ad 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -1009,6 +1009,16 @@ config TARGET_THUNDERX_88XX
>>  
>>  endchoice
>>  
>> +config EEPROM_BUS_ADDRESS
>> +        int "Board EEPROM's I2C bus address"
>> +        range 0 8
>> +        default 0
>> +
>> +config EEPROM_CHIP_ADDRESS
>> +        hex "Board EEPROM's I2C chip address"
>> +        range 0 0xff
>> +        default 0x50
>> +
> 
> IMO, these should be placed in board/ti/common/Kconfig. Also need not
> specify the value explicitly in defconfig if default value is used.

"board/ti/common/Kconfig" is not used by keystone
Is it OK to source it in board/ti/ks2_evm/Kconfig?

-- 
cheers,
-roger

  reply	other threads:[~2017-02-01  9:42 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-30 15:15 [U-Boot] [u-boot PATCH v2 0/8] am57xx-idk LCD and am571x-idk 6 port ethernet pinmux Roger Quadros
2017-01-30 15:15 ` [U-Boot] [u-boot PATCH v2 1/8] ARM: OMAP5+: GPIO: Add GPIO_TO_PIN() macro Roger Quadros
2017-01-31  4:08   ` Lokesh Vutla
2017-01-30 15:15 ` [U-Boot] [u-boot PATCH v2 2/8] ti: common: board_detect: commodify ethaddr environment setting code Roger Quadros
2017-01-31  4:08   ` Lokesh Vutla
2017-01-31 21:38   ` Tom Rini
2017-01-30 15:15 ` [U-Boot] [u-boot PATCH v2 3/8] board: ti: am571x-idk: Support 6 port Ethernet or 4 port Ethernet with LCD Roger Quadros
2017-01-31  4:10   ` Lokesh Vutla
2017-01-30 15:15 ` [U-Boot] [u-boot PATCH v2 4/8] board: ti: am571x-idk: Update pinmux for ICSS2 Ethernet Roger Quadros
2017-01-31  4:10   ` Lokesh Vutla
2017-01-30 15:15 ` [U-Boot] [u-boot PATCH v2 5/8] board: ti: am57xx-idk: Auto detect LCD Panel Roger Quadros
2017-01-30 15:15 ` [U-Boot] [u-boot PATCH v2 6/8] ARM: Use Kconfig for board EEPROM's I2C bus and chip address Roger Quadros
2017-01-31  4:17   ` Lokesh Vutla
2017-02-01  9:42     ` Roger Quadros [this message]
2017-02-01 10:47       ` Lokesh Vutla
2017-02-01 12:01         ` Roger Quadros
2017-02-01 12:14           ` Tom Rini
2017-02-01 13:05             ` Roger Quadros
2017-02-01 13:44               ` Tom Rini
2017-01-30 15:15 ` [U-Boot] [u-boot PATCH v2 7/8] ARM: k2g: setup PRU ethernet MAC addresses Roger Quadros
2017-01-31  4:18   ` Lokesh Vutla
2017-01-30 15:15 ` [U-Boot] [u-boot PATCH v2 8/8] ti: common: board_detect: Rename EEPROM scratch start macro Roger Quadros
2017-01-31 21:38   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b608991-cc94-be87-a25d-cf3db8b999f1@ti.com \
    --to=rogerq@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.