From: Gustavo Pimentel <gustavo.pimentel@synopsys.com> To: Jose Abreu <jose.abreu@synopsys.com>, Gustavo Pimentel <gustavo.pimentel@synopsys.com>, "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org> Cc: Vinod Koul <vkoul@kernel.org>, Dan Williams <dan.j.williams@intel.com>, Eugeniy Paltsev <eugeniy.paltsev@synopsys.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Russell King <rmk+kernel@armlinux.org.uk>, Niklas Cassel <niklas.cassel@linaro.org>, Joao Pinto <joao.pinto@synopsys.com>, Luis de Oliveira <luis.oliveira@synopsys.com>, Vitor Soares <vitor.soares@synopsys.com>, Nelson Costa <nelson.costa@synopsys.com>, Pedro Sousa <pedrom.sousa@synopsys.com> Subject: [RFC,v3,7/7] dmaengine: Add Synopsys eDMA IP test and sample driver Date: Wed, 16 Jan 2019 11:56:20 +0000 [thread overview] Message-ID: <488fda69-6e92-00ae-a5f2-2fe099a0ac8f@synopsys.com> (raw) Hi Jose, On 16/01/2019 10:45, Jose Abreu wrote: > Hi Gustavo, > > On 1/11/2019 6:33 PM, Gustavo Pimentel wrote: >> Add Synopsys eDMA IP test and sample driver to be use for testing >> purposes and also as a reference for any developer who needs to >> implement and use Synopsys eDMA. >> >> This driver can be compile as built-in or external module in kernel. >> >> To enable this driver just select DW_EDMA_TEST option in kernel >> configuration, however it requires and selects automatically DW_EDMA >> option too. >> >> Changes: >> RFC v1->RFC v2: >> - No changes >> RFC v2->RFC v3: >> - Add test module >> >> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> >> Cc: Vinod Koul <vkoul@kernel.org> >> Cc: Dan Williams <dan.j.williams@intel.com> >> Cc: Eugeniy Paltsev <paltsev@synopsys.com> >> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> Cc: Russell King <rmk+kernel@armlinux.org.uk> >> Cc: Niklas Cassel <niklas.cassel@linaro.org> >> Cc: Joao Pinto <jpinto@synopsys.com> >> Cc: Jose Abreu <jose.abreu@synopsys.com> >> Cc: Luis Oliveira <lolivei@synopsys.com> >> Cc: Vitor Soares <vitor.soares@synopsys.com> >> Cc: Nelson Costa <nelson.costa@synopsys.com> >> Cc: Pedro Sousa <pedrom.sousa@synopsys.com> > >> +static int dw_edma_test_add_channel(struct dw_edma_test_info *info, >> + struct dma_chan *chan, >> + u32 channel) >> +{ >> + struct dw_edma_test_params *params = &info->params; >> + struct dw_edma_test_thread *thread; >> + struct dw_edma_test_chan *tchan; >> + >> + tchan = kvmalloc(sizeof(*tchan), GFP_KERNEL); >> + if (!tchan) >> + return -ENOMEM; >> + >> + tchan->chan = chan; >> + >> + thread = kvzalloc(sizeof(*thread), GFP_KERNEL); >> + if (!thread) { >> + kvfree(tchan); >> + return -ENOMEM; >> + } >> + >> + thread->info = info; >> + thread->chan = tchan->chan; >> + switch (channel) { >> + case EDMA_CH_WR: >> + thread->direction = DMA_DEV_TO_MEM; >> + break; >> + case EDMA_CH_RD: >> + thread->direction = DMA_MEM_TO_DEV; >> + break; >> + default: >> + kvfree(tchan); > > You are leaking thread here. Yes, indeed. > >> + return -EPERM; >> + } >> + thread->test_done.wait = &thread->done_wait; >> + init_waitqueue_head(&thread->done_wait); >> + >> + if (!params->repetitions) >> + thread->task = kthread_create(dw_edma_test_sg, thread, "%s", >> + dma_chan_name(chan)); >> + else >> + thread->task = kthread_create(dw_edma_test_cyclic, thread, "%s", >> + dma_chan_name(chan)); >> + >> + if (IS_ERR(thread->task)) { >> + pr_err("failed to create thread %s\n", dma_chan_name(chan)); >> + kvfree(tchan); >> + kvfree(thread); >> + return -EPERM; >> + } >> + >> + tchan->thread = thread; >> + dev_dbg(chan->device->dev, "add thread %s\n", dma_chan_name(chan)); >> + list_add_tail(&tchan->node, &info->channels); >> + >> + return 0; >> +} >> + Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Gustavo Pimentel <gustavo.pimentel@synopsys.com> To: Jose Abreu <jose.abreu@synopsys.com>, Gustavo Pimentel <gustavo.pimentel@synopsys.com>, "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org> Cc: Vinod Koul <vkoul@kernel.org>, Dan Williams <dan.j.williams@intel.com>, Eugeniy Paltsev <eugeniy.paltsev@synopsys.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Russell King <rmk+kernel@armlinux.org.uk>, Niklas Cassel <niklas.cassel@linaro.org>, Joao Pinto <joao.pinto@synopsys.com>, Jose Abreu <jose.abreu@synopsys.com>, Luis de Oliveira <luis.oliveira@synopsys.com>, Vitor Soares <vitor.soares@synopsys.com>, Nelson Costa <nelson.costa@synopsys.com>, "Pedro Sousa" <pedrom.sousa@synopsys.com> Subject: Re: [RFC v3 7/7] dmaengine: Add Synopsys eDMA IP test and sample driver Date: Wed, 16 Jan 2019 11:56:20 +0000 [thread overview] Message-ID: <488fda69-6e92-00ae-a5f2-2fe099a0ac8f@synopsys.com> (raw) In-Reply-To: <1876fee2-9f8c-925c-a9ab-cf69fe6693a1@synopsys.com> Hi Jose, On 16/01/2019 10:45, Jose Abreu wrote: > Hi Gustavo, > > On 1/11/2019 6:33 PM, Gustavo Pimentel wrote: >> Add Synopsys eDMA IP test and sample driver to be use for testing >> purposes and also as a reference for any developer who needs to >> implement and use Synopsys eDMA. >> >> This driver can be compile as built-in or external module in kernel. >> >> To enable this driver just select DW_EDMA_TEST option in kernel >> configuration, however it requires and selects automatically DW_EDMA >> option too. >> >> Changes: >> RFC v1->RFC v2: >> - No changes >> RFC v2->RFC v3: >> - Add test module >> >> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> >> Cc: Vinod Koul <vkoul@kernel.org> >> Cc: Dan Williams <dan.j.williams@intel.com> >> Cc: Eugeniy Paltsev <paltsev@synopsys.com> >> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> Cc: Russell King <rmk+kernel@armlinux.org.uk> >> Cc: Niklas Cassel <niklas.cassel@linaro.org> >> Cc: Joao Pinto <jpinto@synopsys.com> >> Cc: Jose Abreu <jose.abreu@synopsys.com> >> Cc: Luis Oliveira <lolivei@synopsys.com> >> Cc: Vitor Soares <vitor.soares@synopsys.com> >> Cc: Nelson Costa <nelson.costa@synopsys.com> >> Cc: Pedro Sousa <pedrom.sousa@synopsys.com> > >> +static int dw_edma_test_add_channel(struct dw_edma_test_info *info, >> + struct dma_chan *chan, >> + u32 channel) >> +{ >> + struct dw_edma_test_params *params = &info->params; >> + struct dw_edma_test_thread *thread; >> + struct dw_edma_test_chan *tchan; >> + >> + tchan = kvmalloc(sizeof(*tchan), GFP_KERNEL); >> + if (!tchan) >> + return -ENOMEM; >> + >> + tchan->chan = chan; >> + >> + thread = kvzalloc(sizeof(*thread), GFP_KERNEL); >> + if (!thread) { >> + kvfree(tchan); >> + return -ENOMEM; >> + } >> + >> + thread->info = info; >> + thread->chan = tchan->chan; >> + switch (channel) { >> + case EDMA_CH_WR: >> + thread->direction = DMA_DEV_TO_MEM; >> + break; >> + case EDMA_CH_RD: >> + thread->direction = DMA_MEM_TO_DEV; >> + break; >> + default: >> + kvfree(tchan); > > You are leaking thread here. Yes, indeed. > >> + return -EPERM; >> + } >> + thread->test_done.wait = &thread->done_wait; >> + init_waitqueue_head(&thread->done_wait); >> + >> + if (!params->repetitions) >> + thread->task = kthread_create(dw_edma_test_sg, thread, "%s", >> + dma_chan_name(chan)); >> + else >> + thread->task = kthread_create(dw_edma_test_cyclic, thread, "%s", >> + dma_chan_name(chan)); >> + >> + if (IS_ERR(thread->task)) { >> + pr_err("failed to create thread %s\n", dma_chan_name(chan)); >> + kvfree(tchan); >> + kvfree(thread); >> + return -EPERM; >> + } >> + >> + tchan->thread = thread; >> + dev_dbg(chan->device->dev, "add thread %s\n", dma_chan_name(chan)); >> + list_add_tail(&tchan->node, &info->channels); >> + >> + return 0; >> +} >> + Thanks!
next reply other threads:[~2019-01-16 11:56 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-16 11:56 Gustavo Pimentel [this message] 2019-01-16 11:56 ` [RFC v3 7/7] dmaengine: Add Synopsys eDMA IP test and sample driver Gustavo Pimentel -- strict thread matches above, loose matches on Subject: below -- 2019-02-06 18:06 [RFC,v3,1/7] dmaengine: Add Synopsys eDMA IP core driver Gustavo Pimentel 2019-02-06 18:06 ` [RFC v3 1/7] " Gustavo Pimentel 2019-02-02 10:07 [RFC,v3,1/7] " Vinod Koul 2019-02-02 10:07 ` [RFC v3 1/7] " Vinod Koul 2019-02-01 11:23 [RFC,v3,1/7] " Gustavo Pimentel 2019-02-01 11:23 ` [RFC v3 1/7] " Gustavo Pimentel 2019-02-01 4:14 [RFC,v3,1/7] " Vinod Koul 2019-02-01 4:14 ` [RFC v3 1/7] " Vinod Koul 2019-01-31 11:33 [RFC,v3,1/7] " Gustavo Pimentel 2019-01-31 11:33 ` [RFC v3 1/7] " Gustavo Pimentel 2019-01-23 13:08 [RFC,v3,1/7] " Vinod Koul 2019-01-23 13:08 ` [RFC v3 1/7] " Vinod Koul 2019-01-21 15:59 [RFC,v3,7/7] dmaengine: Add Synopsys eDMA IP test and sample driver Gustavo Pimentel 2019-01-21 15:59 ` [RFC v3 7/7] " Gustavo Pimentel 2019-01-21 15:49 [RFC,v3,1/7] dmaengine: Add Synopsys eDMA IP core driver Gustavo Pimentel 2019-01-21 15:49 ` [RFC v3 1/7] " Gustavo Pimentel 2019-01-21 15:48 [RFC,v3,1/7] " Gustavo Pimentel 2019-01-21 15:48 ` [RFC v3 1/7] " Gustavo Pimentel 2019-01-21 9:21 [RFC,v3,5/7] dmaengine: Add Synopsys eDMA IP PCIe glue-logic Gustavo Pimentel 2019-01-21 9:21 ` [RFC v3 5/7] " Gustavo Pimentel 2019-01-21 9:14 [RFC,v3,1/7] dmaengine: Add Synopsys eDMA IP core driver Gustavo Pimentel 2019-01-21 9:14 ` [RFC v3 1/7] " Gustavo Pimentel 2019-01-20 11:47 [RFC,v3,1/7] " Vinod Koul 2019-01-20 11:47 ` [RFC v3 1/7] " Vinod Koul 2019-01-20 11:44 [RFC,v3,1/7] " Vinod Koul 2019-01-20 11:44 ` [RFC v3 1/7] " Vinod Koul 2019-01-19 16:21 [RFC,v3,1/7] " Andy Shevchenko 2019-01-19 16:21 ` [RFC v3 1/7] " Andy Shevchenko 2019-01-19 15:45 [RFC,v3,5/7] dmaengine: Add Synopsys eDMA IP PCIe glue-logic Andy Shevchenko 2019-01-19 15:45 ` [RFC v3 5/7] " Andy Shevchenko 2019-01-17 5:03 [RFC,v3,7/7] dmaengine: Add Synopsys eDMA IP test and sample driver Vinod Koul 2019-01-17 5:03 ` [RFC v3 7/7] " Vinod Koul 2019-01-16 14:02 [RFC,v3,2/7] dmaengine: Add Synopsys eDMA IP version 0 support Gustavo Pimentel 2019-01-16 14:02 ` [RFC v3 2/7] " Gustavo Pimentel 2019-01-16 11:53 [RFC,v3,1/7] dmaengine: Add Synopsys eDMA IP core driver Gustavo Pimentel 2019-01-16 11:53 ` [RFC v3 1/7] " Gustavo Pimentel 2019-01-16 10:45 [RFC,v3,7/7] dmaengine: Add Synopsys eDMA IP test and sample driver Jose Abreu 2019-01-16 10:45 ` [RFC v3 7/7] " Jose Abreu 2019-01-16 10:33 [RFC,v3,2/7] dmaengine: Add Synopsys eDMA IP version 0 support Jose Abreu 2019-01-16 10:33 ` [RFC v3 2/7] " Jose Abreu 2019-01-16 10:21 [RFC,v3,1/7] dmaengine: Add Synopsys eDMA IP core driver Jose Abreu 2019-01-16 10:21 ` [RFC v3 1/7] " Jose Abreu 2019-01-15 13:02 [RFC,v3,7/7] dmaengine: Add Synopsys eDMA IP test and sample driver Gustavo Pimentel 2019-01-15 13:02 ` [RFC v3 7/7] " Gustavo Pimentel 2019-01-15 12:48 [RFC,v3,5/7] dmaengine: Add Synopsys eDMA IP PCIe glue-logic Gustavo Pimentel 2019-01-15 12:48 ` [RFC v3 5/7] " Gustavo Pimentel 2019-01-15 5:45 [RFC,v3,7/7] dmaengine: Add Synopsys eDMA IP test and sample driver Andy Shevchenko 2019-01-15 5:45 ` [RFC v3 7/7] " Andy Shevchenko 2019-01-15 5:43 [RFC,v3,5/7] dmaengine: Add Synopsys eDMA IP PCIe glue-logic Andy Shevchenko 2019-01-15 5:43 ` [RFC v3 5/7] " Andy Shevchenko 2019-01-14 14:41 [RFC,v3,4/7] PCI: Add Synopsys endpoint EDDA Device id Bjorn Helgaas 2019-01-14 14:41 ` [RFC v3 4/7] " Bjorn Helgaas 2019-01-14 11:44 [RFC,v3,7/7] dmaengine: Add Synopsys eDMA IP test and sample driver Gustavo Pimentel 2019-01-14 11:44 ` [RFC v3 7/7] " Gustavo Pimentel 2019-01-14 11:38 [RFC,v3,5/7] dmaengine: Add Synopsys eDMA IP PCIe glue-logic Gustavo Pimentel 2019-01-14 11:38 ` [RFC v3 5/7] " Gustavo Pimentel 2019-01-11 19:48 [RFC,v3,7/7] dmaengine: Add Synopsys eDMA IP test and sample driver Andy Shevchenko 2019-01-11 19:48 ` [RFC v3 7/7] " Andy Shevchenko 2019-01-11 19:47 [RFC,v3,5/7] dmaengine: Add Synopsys eDMA IP PCIe glue-logic Andy Shevchenko 2019-01-11 19:47 ` [RFC v3 5/7] " Andy Shevchenko 2019-01-11 18:33 [RFC,v3,7/7] dmaengine: Add Synopsys eDMA IP test and sample driver Gustavo Pimentel 2019-01-11 18:33 ` [RFC v3 7/7] " Gustavo Pimentel 2019-01-11 18:33 [RFC,v3,6/7] MAINTAINERS: Add Synopsys eDMA IP driver maintainer Gustavo Pimentel 2019-01-11 18:33 ` [RFC v3 6/7] " Gustavo Pimentel 2019-01-11 18:33 [RFC,v3,5/7] dmaengine: Add Synopsys eDMA IP PCIe glue-logic Gustavo Pimentel 2019-01-11 18:33 ` [RFC v3 5/7] " Gustavo Pimentel 2019-01-11 18:33 [RFC,v3,4/7] PCI: Add Synopsys endpoint EDDA Device id Gustavo Pimentel 2019-01-11 18:33 ` [RFC v3 4/7] " Gustavo Pimentel 2019-01-11 18:33 [RFC,v3,3/7] dmaengine: Add Synopsys eDMA IP version 0 debugfs support Gustavo Pimentel 2019-01-11 18:33 ` [RFC v3 3/7] " Gustavo Pimentel 2019-01-11 18:33 [RFC,v3,2/7] dmaengine: Add Synopsys eDMA IP version 0 support Gustavo Pimentel 2019-01-11 18:33 ` [RFC v3 2/7] " Gustavo Pimentel 2019-01-11 18:33 [RFC,v3,1/7] dmaengine: Add Synopsys eDMA IP core driver Gustavo Pimentel 2019-01-11 18:33 ` [RFC v3 1/7] " Gustavo Pimentel 2019-01-11 18:33 [RFC v3 0/6] dmaengine: Add Synopsys eDMA IP driver (version 0) Gustavo Pimentel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=488fda69-6e92-00ae-a5f2-2fe099a0ac8f@synopsys.com \ --to=gustavo.pimentel@synopsys.com \ --cc=andriy.shevchenko@linux.intel.com \ --cc=dan.j.williams@intel.com \ --cc=dmaengine@vger.kernel.org \ --cc=eugeniy.paltsev@synopsys.com \ --cc=joao.pinto@synopsys.com \ --cc=jose.abreu@synopsys.com \ --cc=linux-pci@vger.kernel.org \ --cc=luis.oliveira@synopsys.com \ --cc=nelson.costa@synopsys.com \ --cc=niklas.cassel@linaro.org \ --cc=pedrom.sousa@synopsys.com \ --cc=rmk+kernel@armlinux.org.uk \ --cc=vitor.soares@synopsys.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.