All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Lee Jones <lee.jones@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	Sylwester Nawrocki <snawrocki@kernel.org>
Subject: Re: [PATCH 06/12] regulator: dt-bindings: samsung,s5m8767: convert to dtschema
Date: Tue, 28 Sep 2021 14:21:43 +0200	[thread overview]
Message-ID: <48ec9ee9-0fc6-4c25-3e3a-1395286ee89d@canonical.com> (raw)
In-Reply-To: <20210928084949.27939-7-krzysztof.kozlowski@canonical.com>

On 28/09/2021 10:49, Krzysztof Kozlowski wrote:
> Convert the regulators of Samsung S5M8767 PMIC to DT schema format.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  .../bindings/regulator/samsung,s5m8767.txt    | 23 +----
>  .../bindings/regulator/samsung,s5m8767.yaml   | 83 +++++++++++++++++++
>  MAINTAINERS                                   |  2 +-
>  3 files changed, 85 insertions(+), 23 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
> 
> diff --git a/Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt b/Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt
> index 6cd83d920155..a1c6eb6f07c8 100644
> --- a/Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt
> +++ b/Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt
> @@ -48,28 +48,7 @@ Additional properties required if either of the optional properties are used:
>     for dvs. The format of the gpio specifier depends in the gpio controller.
>  
>  
> -Names of regulators supported by S5M8767 device:
> -	- LDOn
> -		  - valid values for n are 1 to 28
> -		  - Example: LDO1, LDO2, LDO28
> -	- BUCKn
> -		  - valid values for n are 1 to 9.
> -		  - Example: BUCK1, BUCK2, BUCK9
> -Note: The 'n' in LDOn and BUCKn represents the LDO or BUCK number
> -as per the datasheet of device.
> -
> -
> -Optional properties of the nodes under "regulators" sub-node:
> - - op_mode: describes the different operating modes of the LDO's with
> -            power mode change in SOC. The different possible values are,
> -             0 - always off mode
> -             1 - on in normal mode
> -             2 - low power mode
> -             3 - suspend mode
> - - s5m8767,pmic-ext-control-gpios: (optional) GPIO specifier for one
> -                                   GPIO controlling this regulator
> -                                   (enable/disable); This is valid only
> -                                   for buck9.
> +

That's obviously not sufficient - I will remove full file in v2.

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Lee Jones <lee.jones@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	Sylwester Nawrocki <snawrocki@kernel.org>
Subject: Re: [PATCH 06/12] regulator: dt-bindings: samsung, s5m8767: convert to dtschema
Date: Tue, 28 Sep 2021 14:21:43 +0200	[thread overview]
Message-ID: <48ec9ee9-0fc6-4c25-3e3a-1395286ee89d@canonical.com> (raw)
In-Reply-To: <20210928084949.27939-7-krzysztof.kozlowski@canonical.com>

On 28/09/2021 10:49, Krzysztof Kozlowski wrote:
> Convert the regulators of Samsung S5M8767 PMIC to DT schema format.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  .../bindings/regulator/samsung,s5m8767.txt    | 23 +----
>  .../bindings/regulator/samsung,s5m8767.yaml   | 83 +++++++++++++++++++
>  MAINTAINERS                                   |  2 +-
>  3 files changed, 85 insertions(+), 23 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
> 
> diff --git a/Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt b/Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt
> index 6cd83d920155..a1c6eb6f07c8 100644
> --- a/Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt
> +++ b/Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt
> @@ -48,28 +48,7 @@ Additional properties required if either of the optional properties are used:
>     for dvs. The format of the gpio specifier depends in the gpio controller.
>  
>  
> -Names of regulators supported by S5M8767 device:
> -	- LDOn
> -		  - valid values for n are 1 to 28
> -		  - Example: LDO1, LDO2, LDO28
> -	- BUCKn
> -		  - valid values for n are 1 to 9.
> -		  - Example: BUCK1, BUCK2, BUCK9
> -Note: The 'n' in LDOn and BUCKn represents the LDO or BUCK number
> -as per the datasheet of device.
> -
> -
> -Optional properties of the nodes under "regulators" sub-node:
> - - op_mode: describes the different operating modes of the LDO's with
> -            power mode change in SOC. The different possible values are,
> -             0 - always off mode
> -             1 - on in normal mode
> -             2 - low power mode
> -             3 - suspend mode
> - - s5m8767,pmic-ext-control-gpios: (optional) GPIO specifier for one
> -                                   GPIO controlling this regulator
> -                                   (enable/disable); This is valid only
> -                                   for buck9.
> +

That's obviously not sufficient - I will remove full file in v2.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-28 12:21 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28  8:49 [PATCH 00/12] regulator/mfd/clock: dt-bindings: Samsung S2M and S5M to dtschema Krzysztof Kozlowski
2021-09-28  8:49 ` Krzysztof Kozlowski
2021-09-28  8:49 ` [PATCH 01/12] regulator: s5m8767: do not use reset value as DVS voltage if GPIO DVS is disabled Krzysztof Kozlowski
2021-09-28  8:49   ` Krzysztof Kozlowski
2021-09-28  8:49 ` [PATCH 02/12] regulator: dt-bindings: samsung,s5m8767: correct s5m8767,pmic-buck-default-dvs-idx property Krzysztof Kozlowski
2021-09-28  8:49   ` [PATCH 02/12] regulator: dt-bindings: samsung, s5m8767: correct s5m8767, pmic-buck-default-dvs-idx property Krzysztof Kozlowski
2021-09-28  8:49 ` [PATCH 03/12] clock: dt-bindings: samsung,s2mps11: convert to dtschema Krzysztof Kozlowski
2021-09-28  8:49   ` [PATCH 03/12] clock: dt-bindings: samsung, s2mps11: " Krzysztof Kozlowski
2021-09-28  8:49 ` [PATCH 04/12] regulator: dt-bindings: samsung,s2m: " Krzysztof Kozlowski
2021-09-28  8:49   ` [PATCH 04/12] regulator: dt-bindings: samsung, s2m: " Krzysztof Kozlowski
2021-09-28  8:49 ` [PATCH 05/12] regulator: dt-bindings: samsung,s2mpa01: " Krzysztof Kozlowski
2021-09-28  8:49   ` [PATCH 05/12] regulator: dt-bindings: samsung, s2mpa01: " Krzysztof Kozlowski
2021-09-28  8:49 ` [PATCH 06/12] regulator: dt-bindings: samsung,s5m8767: " Krzysztof Kozlowski
2021-09-28  8:49   ` [PATCH 06/12] regulator: dt-bindings: samsung, s5m8767: " Krzysztof Kozlowski
2021-09-28 12:21   ` Krzysztof Kozlowski [this message]
2021-09-28 12:21     ` Krzysztof Kozlowski
2021-09-28  8:49 ` [PATCH 07/12] mfd: dt-bindings: samsung,s2mps11: " Krzysztof Kozlowski
2021-09-28  8:49   ` Krzysztof Kozlowski
2021-09-28  8:49 ` [PATCH 08/12] mfd: dt-bindings: samsung,s2mpa01: " Krzysztof Kozlowski
2021-09-28  8:49   ` Krzysztof Kozlowski
2021-09-28  8:49 ` [PATCH 09/12] mfd: dt-bindings: samsung,s5m8767: " Krzysztof Kozlowski
2021-09-28  8:49   ` Krzysztof Kozlowski
2021-09-28  8:49 ` [PATCH 10/12] mfd: dt-bindings: samsung,s5m8767: document buck and LDO supplies Krzysztof Kozlowski
2021-09-28  8:49   ` [PATCH 10/12] mfd: dt-bindings: samsung, s5m8767: " Krzysztof Kozlowski
2021-09-30 12:47   ` [PATCH 10/12] mfd: dt-bindings: samsung,s5m8767: " Lee Jones
2021-09-30 12:47     ` Lee Jones
2021-09-30 13:16     ` Krzysztof Kozlowski
2021-09-30 13:16       ` Krzysztof Kozlowski
2021-09-30 13:21       ` Lee Jones
2021-09-30 13:21         ` Lee Jones
2021-09-28  8:49 ` [PATCH 11/12] ARM: dts: exynos: remove unneeded DVS voltages from PMIC on Arndale Krzysztof Kozlowski
2021-09-28  8:49   ` Krzysztof Kozlowski
2021-09-30 11:47   ` (subset) " Krzysztof Kozlowski
2021-09-30 11:47     ` Krzysztof Kozlowski
2021-09-28  8:49 ` [PATCH 12/12] ARM: dts: exynos: use spaces instead of tabs around '=' Krzysztof Kozlowski
2021-09-28  8:49   ` Krzysztof Kozlowski
2021-09-30 11:47   ` (subset) " Krzysztof Kozlowski
2021-09-30 11:47     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48ec9ee9-0fc6-4c25-3e3a-1395286ee89d@canonical.com \
    --to=krzysztof.kozlowski@canonical.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=broonie@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@kernel.org \
    --cc=snawrocki@kernel.org \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.