[PATCH -next] x86/sgx: Make symbol 'sgx_vepc_vm_ops' static

[PATCH -next] x86/sgx: Make symbol 'sgx_vepc_vm_ops' static

[Wei Yongjun]

The sparse tool complains as follows:

arch/x86/kernel/cpu/sgx/virt.c:95:35: warning:
 symbol 'sgx_vepc_vm_ops' was not declared. Should it be static?

This symbol is not used outside of virt.c, so this
commit marks it static.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 arch/x86/kernel/cpu/sgx/virt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/sgx/virt.c b/arch/x86/kernel/cpu/sgx/virt.c
index 7d221eac716a..6ad165a5c0cc 100644
--- a/arch/x86/kernel/cpu/sgx/virt.c
+++ b/arch/x86/kernel/cpu/sgx/virt.c
@@ -92,7 +92,7 @@ static vm_fault_t sgx_vepc_fault(struct vm_fault *vmf)
 	return VM_FAULT_SIGBUS;
 }
 
-const struct vm_operations_struct sgx_vepc_vm_ops = {
+static const struct vm_operations_struct sgx_vepc_vm_ops = {
 	.fault = sgx_vepc_fault,
 };
 

Re: [PATCH -next] x86/sgx: Make symbol 'sgx_vepc_vm_ops' static

[Borislav Petkov]

On Mon, Apr 12, 2021 at 04:00:23PM +0000, Wei Yongjun wrote:
> The sparse tool complains as follows:
> 
> arch/x86/kernel/cpu/sgx/virt.c:95:35: warning:
>  symbol 'sgx_vepc_vm_ops' was not declared. Should it be static?
> 
> This symbol is not used outside of virt.c, so this
> commit marks it static.

For the future:

Avoid having "This patch" or "This commit" in the commit message. It is
tautologically useless.

Also, do

$ git grep 'This patch' Documentation/process

for more details.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

[tip: x86/sgx] x86/sgx: Mark sgx_vepc_vm_ops static

[tip-bot2 for Wei Yongjun]

The following commit has been merged into the x86/sgx branch of tip:

Commit-ID:     523caed9efbb049339706b124185c9358c1b6477
Gitweb:        https://git.kernel.org/tip/523caed9efbb049339706b124185c9358c1b6477
Author:        Wei Yongjun <weiyongjun1@huawei.com>
AuthorDate:    Mon, 12 Apr 2021 16:00:23 
Committer:     Borislav Petkov <bp@suse.de>
CommitterDate: Mon, 12 Apr 2021 19:48:32 +02:00

x86/sgx: Mark sgx_vepc_vm_ops static

Fix the following sparse warning:

  arch/x86/kernel/cpu/sgx/virt.c:95:35: warning:
    symbol 'sgx_vepc_vm_ops' was not declared. Should it be static?

This symbol is not used outside of virt.c so mark it static.

 [ bp: Massage commit message. ]

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20210412160023.193850-1-weiyongjun1@huawei.com
---
 arch/x86/kernel/cpu/sgx/virt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/sgx/virt.c b/arch/x86/kernel/cpu/sgx/virt.c
index 7d221ea..6ad165a 100644
--- a/arch/x86/kernel/cpu/sgx/virt.c
+++ b/arch/x86/kernel/cpu/sgx/virt.c
@@ -92,7 +92,7 @@ static vm_fault_t sgx_vepc_fault(struct vm_fault *vmf)
 	return VM_FAULT_SIGBUS;
 }
 
-const struct vm_operations_struct sgx_vepc_vm_ops = {
+static const struct vm_operations_struct sgx_vepc_vm_ops = {
 	.fault = sgx_vepc_fault,
 };
 

答复: [PATCH -next] x86/sgx: Make symbol 'sgx_vepc_vm_ops' static

[weiyongjun (A)]

> 
> On Mon, Apr 12, 2021 at 04:00:23PM +0000, Wei Yongjun wrote:
> > The sparse tool complains as follows:
> >
> > arch/x86/kernel/cpu/sgx/virt.c:95:35: warning:
> >  symbol 'sgx_vepc_vm_ops' was not declared. Should it be static?
> >
> > This symbol is not used outside of virt.c, so this commit marks it
> > static.
> 
> For the future:
> 
> Avoid having "This patch" or "This commit" in the commit message. It is tautologically useless.
> 
> Also, do
> 
> $ git grep 'This patch' Documentation/process
> 
> for more details.
> 
> Thx.


Got it, thanks.

Regards,
Wei Yongjun

Re: [PATCH -next] x86/sgx: Make symbol 'sgx_vepc_vm_ops' static

[Jarkko Sakkinen]

On Mon, Apr 12, 2021 at 04:00:23PM +0000, Wei Yongjun wrote:
> The sparse tool complains as follows:
> 
> arch/x86/kernel/cpu/sgx/virt.c:95:35: warning:
>  symbol 'sgx_vepc_vm_ops' was not declared. Should it be static?
> 
> This symbol is not used outside of virt.c, so this
> commit marks it static.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---

The only reason I cannot ack this is that instead telling what the
commit does, the long description asks should this be done or not.


/Jarkko

>  arch/x86/kernel/cpu/sgx/virt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/sgx/virt.c b/arch/x86/kernel/cpu/sgx/virt.c
> index 7d221eac716a..6ad165a5c0cc 100644
> --- a/arch/x86/kernel/cpu/sgx/virt.c
> +++ b/arch/x86/kernel/cpu/sgx/virt.c
> @@ -92,7 +92,7 @@ static vm_fault_t sgx_vepc_fault(struct vm_fault *vmf)
>  	return VM_FAULT_SIGBUS;
>  }
>  
> -const struct vm_operations_struct sgx_vepc_vm_ops = {
> +static const struct vm_operations_struct sgx_vepc_vm_ops = {
>  	.fault = sgx_vepc_fault,
>  };
>  
> 
>