All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fs: namei: fix two excess parameter description warnings
@ 2022-11-17 12:28 Kushagra Verma
  2022-11-25  2:51 ` Randy Dunlap
  0 siblings, 1 reply; 2+ messages in thread
From: Kushagra Verma @ 2022-11-17 12:28 UTC (permalink / raw)
  To: Alexander Viro, linux-fsdevel, linux-kernel

While building the kernel documentation, two excess parameter description
warnings appear:
	./fs/namei.c:3589: warning: Excess function parameter 'dentry'
	description in 'vfs_tmpfile'
	./fs/namei.c:3589: warning: Excess function parameter 'open_flag'
	description in 'vfs_tmpfile'

Fix these warnings by changing 'dentry' to 'parentpath' in the parameter
description and 'open_flag' to 'file' and change 'file' parameter's
description accordingly.

Signed-off-by: Kushagra Verma <kushagra765@outlook.com>
---
 fs/namei.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/namei.c b/fs/namei.c
index 578c2110df02..8e77e194fed5 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -3571,9 +3571,9 @@ static int do_open(struct nameidata *nd,
 /**
  * vfs_tmpfile - create tmpfile
  * @mnt_userns:	user namespace of the mount the inode was found from
- * @dentry:	pointer to dentry of the base directory
+ * @parentpath:	pointer to dentry of the base directory
  * @mode:	mode of the new tmpfile
- * @open_flag:	flags
+ * @file:	file information
  *
  * Create a temporary file.
  *
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] fs: namei: fix two excess parameter description warnings
  2022-11-17 12:28 [PATCH] fs: namei: fix two excess parameter description warnings Kushagra Verma
@ 2022-11-25  2:51 ` Randy Dunlap
  0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2022-11-25  2:51 UTC (permalink / raw)
  To: Kushagra Verma, Alexander Viro, linux-fsdevel, linux-kernel



On 11/17/22 04:28, Kushagra Verma wrote:
> While building the kernel documentation, two excess parameter description
> warnings appear:
> 	./fs/namei.c:3589: warning: Excess function parameter 'dentry'
> 	description in 'vfs_tmpfile'
> 	./fs/namei.c:3589: warning: Excess function parameter 'open_flag'
> 	description in 'vfs_tmpfile'
> 
> Fix these warnings by changing 'dentry' to 'parentpath' in the parameter
> description and 'open_flag' to 'file' and change 'file' parameter's
> description accordingly.
> 
> Signed-off-by: Kushagra Verma <kushagra765@outlook.com>

Tested-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  fs/namei.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/namei.c b/fs/namei.c
> index 578c2110df02..8e77e194fed5 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -3571,9 +3571,9 @@ static int do_open(struct nameidata *nd,
>  /**
>   * vfs_tmpfile - create tmpfile
>   * @mnt_userns:	user namespace of the mount the inode was found from
> - * @dentry:	pointer to dentry of the base directory
> + * @parentpath:	pointer to dentry of the base directory
>   * @mode:	mode of the new tmpfile
> - * @open_flag:	flags
> + * @file:	file information
>   *
>   * Create a temporary file.
>   *

-- 
~Randy

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-25  2:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-17 12:28 [PATCH] fs: namei: fix two excess parameter description warnings Kushagra Verma
2022-11-25  2:51 ` Randy Dunlap

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.