All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	KVM General <kvm@vger.kernel.org>,
	"Kevin O'Connor" <kevin@koconnor.net>,
	Avi Kivity <avi@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg
Date: Mon, 25 Jan 2010 18:46:06 +0100	[thread overview]
Message-ID: <4B5DD8DE.7050100@redhat.com> (raw)
In-Reply-To: <04C75D06-9153-410E-8D91-474F2A92D265@suse.de>

On 01/25/10 18:28, Alexander Graf wrote:
>>> That way we'd get 2 entries and the chance to enhance them later on.
>>> In fact, it might even make sense to pass the whole table in such a
>>> form. That way qemu generates all of the e820 tables and we can
>>> declare whatever we want. Just add a type field in the table.
>>
>> I am fine with having QEMU build the e820 tables completely if there is
>> a consensus to take that path.
>
> I agree. We better get this right :-). I don't want to maintain 5
> versions of an 380 fw_cfg interface.

Looking at the internals, some of the e820 entries are based on compile
time constants for the BIOS, so it will be hard to pass those from
QEMU, but we could do it in a way so we pass a number of additional
e820 entries. Ie. address, length, and type.

What do you think?

Cheers,
Jes

WARNING: multiple messages have this Message-ID (diff)
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Kevin O'Connor <kevin@koconnor.net>,
	QEMU Developers <qemu-devel@nongnu.org>,
	KVM General <kvm@vger.kernel.org>, Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg
Date: Mon, 25 Jan 2010 18:46:06 +0100	[thread overview]
Message-ID: <4B5DD8DE.7050100@redhat.com> (raw)
In-Reply-To: <04C75D06-9153-410E-8D91-474F2A92D265@suse.de>

On 01/25/10 18:28, Alexander Graf wrote:
>>> That way we'd get 2 entries and the chance to enhance them later on.
>>> In fact, it might even make sense to pass the whole table in such a
>>> form. That way qemu generates all of the e820 tables and we can
>>> declare whatever we want. Just add a type field in the table.
>>
>> I am fine with having QEMU build the e820 tables completely if there is
>> a consensus to take that path.
>
> I agree. We better get this right :-). I don't want to maintain 5
> versions of an 380 fw_cfg interface.

Looking at the internals, some of the e820 entries are based on compile
time constants for the BIOS, so it will be hard to pass those from
QEMU, but we could do it in a way so we pass a number of additional
e820 entries. Ie. address, length, and type.

What do you think?

Cheers,
Jes

  reply	other threads:[~2010-01-25 17:46 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-25 16:46 [PATCH] Seabios - read e820 reserve from qemu_cfg Jes Sorensen
2010-01-25 16:46 ` [Qemu-devel] " Jes Sorensen
2010-01-25 16:49 ` [PATCH] QEMU-KVM - provide e820 reserve through qemu_cfg Jes Sorensen
2010-01-25 16:49   ` [Qemu-devel] " Jes Sorensen
2010-01-25 16:52   ` [PATCH] QEMU " Jes Sorensen
2010-01-25 16:52     ` [Qemu-devel] " Jes Sorensen
2010-01-25 16:58     ` Alexander Graf
2010-01-25 16:58       ` [Qemu-devel] " Alexander Graf
2010-01-25 17:13       ` Jes Sorensen
2010-01-25 17:13         ` [Qemu-devel] " Jes Sorensen
2010-01-25 17:28         ` Alexander Graf
2010-01-25 17:28           ` [Qemu-devel] " Alexander Graf
2010-01-25 17:46           ` Jes Sorensen [this message]
2010-01-25 17:46             ` Jes Sorensen
2010-01-25 20:04             ` Alexander Graf
2010-01-25 20:04               ` [Qemu-devel] " Alexander Graf
2010-01-25 20:14               ` Anthony Liguori
2010-01-25 20:14                 ` [Qemu-devel] " Anthony Liguori
2010-01-25 21:05                 ` Jes Sorensen
2010-01-25 21:05                   ` [Qemu-devel] " Jes Sorensen
2010-01-25 21:08                   ` Alexander Graf
2010-01-25 21:08                     ` [Qemu-devel] " Alexander Graf
2010-01-25 21:24                     ` Jes Sorensen
2010-01-25 21:24                       ` [Qemu-devel] " Jes Sorensen
2010-01-26  6:46         ` Gleb Natapov
2010-01-26  6:46           ` [Qemu-devel] " Gleb Natapov
2010-01-26  8:36           ` Jes Sorensen
2010-01-26  8:36             ` [Qemu-devel] " Jes Sorensen
2010-01-26  0:24 ` [PATCH] Seabios - read e820 reserve from qemu_cfg Kevin O'Connor
2010-01-26  0:24   ` [Qemu-devel] " Kevin O'Connor
2010-01-26 21:52   ` [PATCH] Seabios - read e820 table " Jes Sorensen
2010-01-26 21:52     ` [Qemu-devel] " Jes Sorensen
2010-01-26 21:53     ` [PATCH] QEMU-KVM - provide e820 table via fw_cfg Jes Sorensen
2010-01-26 21:53       ` [Qemu-devel] " Jes Sorensen
2010-01-26 21:55       ` Alexander Graf
2010-01-26 21:55         ` [Qemu-devel] " Alexander Graf
2010-01-28  4:39     ` [PATCH] Seabios - read e820 table from qemu_cfg Kevin O'Connor
2010-01-28  4:39       ` [Qemu-devel] " Kevin O'Connor
2010-01-29  9:03       ` Jes Sorensen
2010-01-29  9:03         ` [Qemu-devel] " Jes Sorensen
2010-01-29 16:08         ` Gleb Natapov
2010-01-29 16:08           ` [Qemu-devel] " Gleb Natapov
2010-01-30  3:35         ` Kevin O'Connor
2010-01-30  3:35           ` [Qemu-devel] " Kevin O'Connor
2010-02-08 10:31       ` Jes Sorensen
2010-02-08 10:31         ` [Qemu-devel] " Jes Sorensen
2010-02-14  3:16         ` Kevin O'Connor
2010-02-14  3:16           ` [Qemu-devel] " Kevin O'Connor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B5DD8DE.7050100@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=agraf@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.