Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

From: Alexander Graf <agraf@suse.de>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	KVM General <kvm@vger.kernel.org>,
	Kevin O'Connor <kevin@koconnor.net>, Avi Kivity <avi@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg
Date: Mon, 25 Jan 2010 17:58:26 +0100	[thread overview]
Message-ID: <2CE27313-0F43-4A93-905F-3DF4815BC0B5@suse.de> (raw)
In-Reply-To: <4B5DCC53.508@redhat.com>

On 25.01.2010, at 17:52, Jes Sorensen wrote:

> Hi,
> 
> This is the QEMU patch for providing the e820-reserve space through
> qemu-cfg.

Howdy. Congratulations to the new mail address - looks neat ;-).

Two comments:

1) I don't see how passing a single region is any help. I'd rather like to see a device tree like table structure
You'd get one variable for len of the table, one with the contents. So for a universal reserved region specifier you'd get:

<u64 base><u64 len>

Then have len=2 and put data in the table:

<u64 base1><u64 len1><u64 base2><u64 len2>

That way we'd get 2 entries and the chance to enhance them later on. In fact, it might even make sense to pass the whole table in such a form. That way qemu generates all of the e820 tables and we can declare whatever we want. Just add a type field in the table.

2) Please inline patches. They showed up as attachments here, making them really hard to comment on.

Alex