* [Qemu-devel] [RESEND][PATCH][STABLE] Fix corner case in chardev udp: parameter
@ 2010-03-07 10:28 Jan Kiszka
2010-03-08 16:44 ` [Qemu-devel] " Anthony Liguori
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kiszka @ 2010-03-07 10:28 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel, Gerd Hoffmann
The missing '@' broke 'udp::<port>@:<port>' parsing.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
qemu-char.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 86c7c5a..0d8553d 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2333,7 +2333,7 @@ QemuOpts *qemu_chr_parse_compat(const char *label, const char *filename)
qemu_opt_set(opts, "backend", "udp");
if (sscanf(p, "%64[^:]:%32[^@,]%n", host, port, &pos) < 2) {
host[0] = 0;
- if (sscanf(p, ":%32[^,]%n", port, &pos) < 1) {
+ if (sscanf(p, ":%32[^@,]%n", port, &pos) < 1) {
goto fail;
}
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Qemu-devel] Re: [RESEND][PATCH][STABLE] Fix corner case in chardev udp: parameter
2010-03-07 10:28 [Qemu-devel] [RESEND][PATCH][STABLE] Fix corner case in chardev udp: parameter Jan Kiszka
@ 2010-03-08 16:44 ` Anthony Liguori
2010-03-13 11:05 ` Aurelien Jarno
0 siblings, 1 reply; 3+ messages in thread
From: Anthony Liguori @ 2010-03-08 16:44 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Anthony Liguori, qemu-devel, Gerd Hoffmann
On 03/07/2010 04:28 AM, Jan Kiszka wrote:
> The missing '@' broke 'udp::<port>@:<port>' parsing.
>
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
>
Applied to stable, thanks.
Regards,
Anthony Liguori
> ---
> qemu-char.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 86c7c5a..0d8553d 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -2333,7 +2333,7 @@ QemuOpts *qemu_chr_parse_compat(const char *label, const char *filename)
> qemu_opt_set(opts, "backend", "udp");
> if (sscanf(p, "%64[^:]:%32[^@,]%n", host, port,&pos)< 2) {
> host[0] = 0;
> - if (sscanf(p, ":%32[^,]%n", port,&pos)< 1) {
> + if (sscanf(p, ":%32[^@,]%n", port,&pos)< 1) {
> goto fail;
> }
> }
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] Re: [RESEND][PATCH][STABLE] Fix corner case in chardev udp: parameter
2010-03-08 16:44 ` [Qemu-devel] " Anthony Liguori
@ 2010-03-13 11:05 ` Aurelien Jarno
0 siblings, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2010-03-13 11:05 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Jan Kiszka, Anthony Liguori, qemu-devel, Gerd Hoffmann
On Mon, Mar 08, 2010 at 10:44:37AM -0600, Anthony Liguori wrote:
> On 03/07/2010 04:28 AM, Jan Kiszka wrote:
>> The missing '@' broke 'udp::<port>@:<port>' parsing.
>>
>> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
>>
>
> Applied to stable, thanks.
The same problem exists in HEAD. Shouldn't it be applied here too?
>
> Regards,
>
> Anthony Liguori
>
>> ---
>> qemu-char.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/qemu-char.c b/qemu-char.c
>> index 86c7c5a..0d8553d 100644
>> --- a/qemu-char.c
>> +++ b/qemu-char.c
>> @@ -2333,7 +2333,7 @@ QemuOpts *qemu_chr_parse_compat(const char *label, const char *filename)
>> qemu_opt_set(opts, "backend", "udp");
>> if (sscanf(p, "%64[^:]:%32[^@,]%n", host, port,&pos)< 2) {
>> host[0] = 0;
>> - if (sscanf(p, ":%32[^,]%n", port,&pos)< 1) {
>> + if (sscanf(p, ":%32[^@,]%n", port,&pos)< 1) {
>> goto fail;
>> }
>> }
>>
>>
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-13 11:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-07 10:28 [Qemu-devel] [RESEND][PATCH][STABLE] Fix corner case in chardev udp: parameter Jan Kiszka
2010-03-08 16:44 ` [Qemu-devel] " Anthony Liguori
2010-03-13 11:05 ` Aurelien Jarno
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.