From: Yinghai <yinghai.lu@oracle.com>
To: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>,
Andy Isaacson <adi@hexapodia.org>,
guenter.roeck@ericsson.com,
Linus Torvalds <torvalds@linux-foundation.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Thomas Renninger <trenn@suse.de>
Subject: [PATCH 3/3] x86,pci,acpi: Handle invalid _CRS
Date: Tue, 20 Apr 2010 22:35:59 -0700 [thread overview]
Message-ID: <4BCE8EBF.5050207@oracle.com> (raw)
In-Reply-To: <4BCE8E3E.4030809@oracle.com>
Don't clear root bus resource too early, until We can make sure _CRS works
also restore it, if all _CRS get rejected because of conflicts
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
arch/x86/pci/acpi.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
Index: linux-2.6/arch/x86/pci/acpi.c
===================================================================
--- linux-2.6.orig/arch/x86/pci/acpi.c
+++ linux-2.6/arch/x86/pci/acpi.c
@@ -196,9 +196,6 @@ get_current_resources(struct acpi_device
struct pci_root_info info;
size_t size;
- if (pci_use_crs)
- pci_bus_remove_resources(bus);
-
info.bridge = device;
info.bus = bus;
info.res_num = 0;
@@ -217,10 +214,20 @@ get_current_resources(struct acpi_device
goto name_alloc_fail;
sprintf(info.name, "PCI Bus %04x:%02x", domain, busnum);
+ /* Only clear that when _CRS works for sure*/
+ if (pci_use_crs)
+ pci_bus_remove_resources(bus);
+
info.res_num = 0;
acpi_walk_resources(device->handle, METHOD_NAME__CRS, setup_resource,
&info);
+ if (pci_use_crs && !info.res_num) {
+ /* Restore default one */
+ bus->resource[0] = &ioport_resource;
+ bus->resource[1] = &iomem_resource;
+ }
+
return;
name_alloc_fail:
next prev parent reply other threads:[~2010-04-21 5:39 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 21:06 [PATCH] x86: Reserve legacy VGA MMIO area for x86_64 as well as x86_32 Bjorn Helgaas
2010-04-07 22:45 ` Yinghai
2010-04-07 23:05 ` Bjorn Helgaas
2010-04-07 23:22 ` Yinghai
2010-04-08 3:24 ` Bjorn Helgaas
2010-04-08 4:42 ` H. Peter Anvin
2010-04-08 13:04 ` Bjorn Helgaas
2010-04-09 16:04 ` Bjorn Helgaas
2010-04-09 16:44 ` H. Peter Anvin
2010-04-09 17:22 ` Yinghai
2010-04-09 18:23 ` H. Peter Anvin
2010-04-09 18:55 ` Guenter Roeck
2010-04-09 19:55 ` Yinghai
2010-04-09 22:21 ` Andy Isaacson
2010-04-09 22:27 ` Yinghai Lu
2010-04-09 22:35 ` Andy Isaacson
2010-04-09 22:44 ` H. Peter Anvin
2010-04-09 22:54 ` Yinghai
2010-04-09 23:01 ` Yinghai
2010-04-10 0:00 ` Andy Isaacson
2010-04-10 1:10 ` Yinghai
2010-04-10 1:43 ` Andy Isaacson
2010-04-10 1:48 ` Yinghai
2010-04-10 1:57 ` Andy Isaacson
2010-04-10 2:46 ` Yinghai
2010-04-12 18:54 ` Andy Isaacson
2010-04-12 19:34 ` Yinghai
2010-04-12 19:48 ` Andy Isaacson
2010-04-12 19:55 ` yinghai.lu
2010-04-12 20:02 ` Andy Isaacson
2010-04-12 22:32 ` [PATCH -v2 1/2] x86: Reserve [0xa0000, 0x100000] in e820 map Yinghai
2010-04-13 21:02 ` Bjorn Helgaas
2010-04-13 21:08 ` Yinghai
2010-04-13 21:09 ` H. Peter Anvin
2010-04-13 21:11 ` Yinghai
2010-04-13 21:18 ` H. Peter Anvin
2010-04-13 21:22 ` [PATCH -v3 1/3] " Yinghai
2010-04-23 23:30 ` H. Peter Anvin
2010-04-26 15:35 ` Jesse Barnes
2010-04-13 21:23 ` [PATCH -v3 2/3] x86,pci, acpi: host bridge windows inherit BUSY flag from parent Yinghai
2010-04-13 21:24 ` [PATCH -v3 3/3] pci: don't allocate from a BUSY bus resource Yinghai
2010-04-13 21:42 ` [PATCH -v2 1/2] x86: Reserve [0xa0000, 0x100000] in e820 map Yinghai
2010-04-13 21:58 ` H. Peter Anvin
2010-04-13 22:29 ` Yinghai
2010-04-13 22:39 ` Yinghai
2010-04-13 22:41 ` H. Peter Anvin
2010-04-13 22:58 ` Yinghai
2010-04-13 23:02 ` H. Peter Anvin
2010-04-13 23:03 ` Yinghai
2010-04-13 23:07 ` H. Peter Anvin
2010-04-13 23:09 ` Yinghai
2010-04-21 5:33 ` [PATCH -v4 1/3] " Yinghai
2010-04-21 5:34 ` [PATCH 2/3] x86, resource: Add reserve_region_with_split_check_child() Yinghai
2010-04-21 5:35 ` Yinghai [this message]
2010-04-21 15:21 ` [PATCH 3/3] x86,pci,acpi: Handle invalid _CRS Bjorn Helgaas
2010-04-21 16:45 ` Yinghai Lu
2010-04-21 16:59 ` Bjorn Helgaas
2010-04-21 22:33 ` H. Peter Anvin
2010-04-21 23:04 ` Bjorn Helgaas
2010-04-21 23:10 ` H. Peter Anvin
2010-04-21 23:43 ` Yinghai
2010-04-22 0:02 ` H. Peter Anvin
2010-04-22 0:06 ` Yinghai
2010-04-21 19:31 ` [PATCH -v4 1/3] x86: Reserve [0xa0000, 0x100000] in e820 map Andy Isaacson
2010-04-23 23:05 ` [PATCH] x86/PCI: never allocate PCI MMIO resources below BIOS_END Bjorn Helgaas
2010-04-23 23:44 ` H. Peter Anvin
2010-04-24 0:36 ` Yinghai Lu
2010-04-26 12:50 ` R. Andrew Bailey
2010-04-26 15:40 ` Bjorn Helgaas
2010-04-26 18:34 ` Andy Isaacson
2010-04-26 19:31 ` Jesse Barnes
2010-04-26 20:27 ` Bjorn Helgaas
2010-04-26 20:37 ` Jesse Barnes
2010-04-26 21:07 ` Yinghai
2010-04-26 21:19 ` H. Peter Anvin
2010-04-26 21:12 ` H. Peter Anvin
2010-04-26 21:25 ` Jesse Barnes
2010-04-26 21:44 ` H. Peter Anvin
2010-04-26 21:53 ` Jesse Barnes
2010-04-26 21:59 ` Yinghai Lu
2010-04-26 22:04 ` [PATCH -v5] reserve a0000 - 0x10000 Yinghai
[not found] ` <4BD60CD4.9020708@oracle.com>
2010-04-26 22:04 ` [PATCH -v5 1/3] x86: Reserve [0xa0000, 0x100000] in e820 map Yinghai
2010-04-26 22:04 ` [PATCH -v5 2/3] x86: Remove probe_roms for 32bit Yinghai
2010-04-26 22:04 ` [PATCH -v5 3/3] x86, resource: Add reserve_region_with_split_check_child() Yinghai
2010-04-26 21:44 ` [PATCH] x86/PCI: never allocate PCI MMIO resources below BIOS_END jacob pan
2010-04-13 23:03 ` [PATCH -v2 1/2] x86: Reserve [0xa0000, 0x100000] in e820 map H. Peter Anvin
2010-04-14 0:57 ` Yinghai
2010-04-14 16:55 ` Bjorn Helgaas
2010-04-14 17:21 ` Yinghai Lu
2010-04-14 19:25 ` Andy Isaacson
2010-04-14 19:27 ` Yinghai
2010-04-14 19:43 ` Andy Isaacson
2010-04-14 19:49 ` Yinghai
2010-04-12 22:33 ` [PATCH -v2 2/2] x86,pci, acpi: Inherent BUSY flag when setup_resource for root bus Yinghai
2010-04-12 22:44 ` Jesse Barnes
2010-04-13 21:02 ` Bjorn Helgaas
2010-04-09 20:11 ` [PATCH] x86: Reserve legacy VGA MMIO area for x86_64 as well as x86_32 H. Peter Anvin
2010-04-09 20:31 ` Guenter Roeck
2010-04-09 20:44 ` H. Peter Anvin
2010-04-09 21:01 ` Guenter Roeck
2010-04-09 22:42 ` Alan Cox
2010-04-09 22:42 ` H. Peter Anvin
2010-04-09 22:54 ` Alan Cox
2010-04-09 22:55 ` H. Peter Anvin
2010-04-09 22:51 ` Alan Cox
2010-04-09 22:55 ` H. Peter Anvin
2010-04-07 23:43 ` H. Peter Anvin
2010-04-08 0:19 ` Andy Isaacson
2010-04-08 5:00 ` H. Peter Anvin
2010-04-08 21:40 ` Andy Isaacson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCE8EBF.5050207@oracle.com \
--to=yinghai.lu@oracle.com \
--cc=adi@hexapodia.org \
--cc=bjorn.helgaas@hp.com \
--cc=guenter.roeck@ericsson.com \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=trenn@suse.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.