From: Stephen Boyd <sboyd@codeaurora.org> To: Daniel Walker <dwalker@codeaurora.org>, Tony Lindgren <tony@atomide.com> Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>, Nicolas Pitre <nico@fluxnic.net>, Greg Kroah-Hartman <gregkh@suse.de>, Mike Frysinger <vapier@gentoo.org>, Andrew Morton <akpm@linux-foundation.org>, Alan Cox <alan@lxorguk.ukuu.org.uk>, Randy Dunlap <randy.dunlap@oracle.com>, FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] drivers: char: hvc: add arm JTAG DCC console support Date: Wed, 01 Dec 2010 12:20:20 -0800 [thread overview] Message-ID: <4CF6AE04.6030201@codeaurora.org> (raw) In-Reply-To: <1291229696.14404.39.camel@c-dwalke-linux.qualcomm.com> On 12/01/2010 10:54 AM, Daniel Walker wrote: > Are you talking about __dcc_getstatus only? I don't think adding > volatile is going to hurt anything, if not having it causes problems. > Just marking __dcc_getstatus volatile gives me 00000038 <hvc_dcc_get_chars>: 38: ee10fe11 mrc 14, 0, pc, cr0, cr1, {0} 3c: 1afffffd bne 38 <hvc_dcc_get_chars> 40: ee103e15 mrc 14, 0, r3, cr0, cr5, {0} 44: e3a00000 mov r0, #0 ; 0x0 48: e6ef3073 uxtb r3, r3 4c: ea000004 b 64 <hvc_dcc_get_chars+0x2c> 50: ee10ce11 mrc 14, 0, ip, cr0, cr1, {0} 54: e31c0101 tst ip, #1073741824 ; 0x40000000 58: 012fff1e bxeq lr 5c: e7c13000 strb r3, [r1, r0] 60: e2800001 add r0, r0, #1 ; 0x1 64: e1500002 cmp r0, r2 68: bafffff8 blt 50 <hvc_dcc_get_chars+0x18> 6c: e12fff1e bx lr Seems the compiler keeps the value of __dcc_getchar() in r3 for the duration of the loop. So we need to mark that one volatile too. I don't think __dcc_putchar() needs to be marked volatile but it probably doesn't hurt. > > We could maybe drop the looping for TX, but RX has no C based looping > even tho for v7 it's recommended that we loop (presumably for v6 it's > not recommended). > Definitely for TX since it seems like a redundant loop, but I agree RX code has changed. Instead of If RX buffer full Poll for RX buffer full Read character from RX buffer we would have If RX buffer full Read character from RX buffer which doesn't seem all that different assuming the RX buffer doesn't go from full to empty between the If and Poll steps. Hopefully Tony knows more. > Like this? > > for (i = 0; i < count; ++i) { > > if (__dcc_getstatus() & DCC_STATUS_RX) > buf[i] = __dcc_getchar(); > else > break; > } > > It's a micro clean up I guess .. Yes, it's much clearer that way. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org> To: Daniel Walker <dwalker@codeaurora.org>, Tony Lindgren <tony@atomide.com> Cc: Randy Dunlap <randy.dunlap@oracle.com>, Mike Frysinger <vapier@gentoo.org>, Arnd Bergmann <arnd@arndb.de>, Nicolas Pitre <nico@fluxnic.net>, linux-arm-msm@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>, linux-kernel@vger.kernel.org, FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>, Andrew Morton <akpm@linux-foundation.org>, linuxppc-dev@lists.ozlabs.org, Alan Cox <alan@lxorguk.ukuu.org.uk> Subject: Re: [PATCH] drivers: char: hvc: add arm JTAG DCC console support Date: Wed, 01 Dec 2010 12:20:20 -0800 [thread overview] Message-ID: <4CF6AE04.6030201@codeaurora.org> (raw) In-Reply-To: <1291229696.14404.39.camel@c-dwalke-linux.qualcomm.com> On 12/01/2010 10:54 AM, Daniel Walker wrote: > Are you talking about __dcc_getstatus only? I don't think adding > volatile is going to hurt anything, if not having it causes problems. > Just marking __dcc_getstatus volatile gives me 00000038 <hvc_dcc_get_chars>: 38: ee10fe11 mrc 14, 0, pc, cr0, cr1, {0} 3c: 1afffffd bne 38 <hvc_dcc_get_chars> 40: ee103e15 mrc 14, 0, r3, cr0, cr5, {0} 44: e3a00000 mov r0, #0 ; 0x0 48: e6ef3073 uxtb r3, r3 4c: ea000004 b 64 <hvc_dcc_get_chars+0x2c> 50: ee10ce11 mrc 14, 0, ip, cr0, cr1, {0} 54: e31c0101 tst ip, #1073741824 ; 0x40000000 58: 012fff1e bxeq lr 5c: e7c13000 strb r3, [r1, r0] 60: e2800001 add r0, r0, #1 ; 0x1 64: e1500002 cmp r0, r2 68: bafffff8 blt 50 <hvc_dcc_get_chars+0x18> 6c: e12fff1e bx lr Seems the compiler keeps the value of __dcc_getchar() in r3 for the duration of the loop. So we need to mark that one volatile too. I don't think __dcc_putchar() needs to be marked volatile but it probably doesn't hurt. > > We could maybe drop the looping for TX, but RX has no C based looping > even tho for v7 it's recommended that we loop (presumably for v6 it's > not recommended). > Definitely for TX since it seems like a redundant loop, but I agree RX code has changed. Instead of If RX buffer full Poll for RX buffer full Read character from RX buffer we would have If RX buffer full Read character from RX buffer which doesn't seem all that different assuming the RX buffer doesn't go from full to empty between the If and Poll steps. Hopefully Tony knows more. > Like this? > > for (i = 0; i < count; ++i) { > > if (__dcc_getstatus() & DCC_STATUS_RX) > buf[i] = __dcc_getchar(); > else > break; > } > > It's a micro clean up I guess .. Yes, it's much clearer that way. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2010-12-01 20:20 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-11-30 19:25 [PATCH] drivers: char: hvc: add arm JTAG DCC console support Daniel Walker 2010-11-30 19:25 ` Daniel Walker 2010-11-30 19:57 ` Nicolas Pitre 2010-11-30 19:57 ` Nicolas Pitre 2010-11-30 21:17 ` Arnd Bergmann 2010-11-30 21:17 ` Arnd Bergmann 2010-12-01 5:30 ` Stephen Boyd 2010-12-01 5:30 ` Stephen Boyd 2010-12-01 18:54 ` Daniel Walker 2010-12-01 18:54 ` Daniel Walker 2010-12-01 19:28 ` Greg KH 2010-12-01 19:28 ` Greg KH 2010-12-18 5:16 ` [PATCH] hvc_dcc: Simplify assembly for v6 and v7 ARM Stephen Boyd 2010-12-18 5:16 ` Stephen Boyd 2010-12-20 17:51 ` Daniel Walker 2010-12-20 17:51 ` Daniel Walker 2010-12-20 18:39 ` Stephen Boyd 2010-12-20 18:39 ` Stephen Boyd 2010-12-20 18:46 ` Nicolas Pitre 2010-12-20 18:46 ` Nicolas Pitre 2010-12-20 20:08 ` [PATCH 0/3] hvc_dcc cleanups and fixes Stephen Boyd 2010-12-20 20:08 ` Stephen Boyd 2010-12-20 20:08 ` [PATCH 1/3] hvc_dcc: Fix bad code generation by marking assembly volatile Stephen Boyd 2010-12-20 20:08 ` Stephen Boyd 2010-12-20 21:39 ` Nicolas Pitre 2010-12-20 21:39 ` Nicolas Pitre 2011-01-02 9:00 ` Pavel Machek 2011-01-02 9:00 ` Pavel Machek 2011-01-02 18:49 ` David Brown 2011-01-02 18:49 ` David Brown 2011-01-03 5:50 ` Pavel Machek 2011-01-03 5:50 ` Pavel Machek 2011-01-04 18:49 ` Tony Lindgren 2011-01-04 18:49 ` Tony Lindgren 2010-12-20 21:49 ` Arnaud Lacombe 2010-12-20 21:49 ` Arnaud Lacombe 2010-12-20 21:52 ` Stephen Boyd 2010-12-20 21:52 ` Stephen Boyd 2010-12-20 22:10 ` Nicolas Pitre 2010-12-20 22:10 ` Nicolas Pitre 2010-12-20 20:08 ` [PATCH 2/3] hvc_dcc: Simplify put_chars()/get_chars() loops Stephen Boyd 2010-12-20 20:08 ` Stephen Boyd 2010-12-20 20:08 ` [PATCH 3/3] hvc_dcc: Simplify assembly for v6 and v7 ARM Stephen Boyd 2010-12-20 20:08 ` Stephen Boyd 2010-12-20 21:44 ` Nicolas Pitre 2010-12-20 21:44 ` Nicolas Pitre 2011-01-04 18:52 ` Tony Lindgren 2011-01-04 18:52 ` Tony Lindgren 2011-01-06 1:49 ` [PATCH 0/3] hvc_dcc cleanups and fixes Stephen Boyd 2011-01-06 1:49 ` Stephen Boyd 2011-01-06 3:20 ` Greg KH 2011-01-06 3:20 ` Greg KH 2011-02-03 22:17 ` Greg KH 2011-02-03 22:17 ` Greg KH 2011-02-03 22:17 ` Greg KH 2011-02-03 23:19 ` Stephen Boyd 2011-02-03 23:19 ` Stephen Boyd 2011-02-03 23:30 ` Greg KH 2011-02-03 23:30 ` Greg KH 2011-02-03 23:48 ` [PATCHv2 " Stephen Boyd 2011-02-03 23:48 ` Stephen Boyd 2011-02-03 23:48 ` [PATCHv2 1/3] hvc_dcc: Fix bad code generation by marking assembly volatile Stephen Boyd 2011-02-03 23:48 ` Stephen Boyd 2011-02-03 23:48 ` [PATCHv2 2/3] hvc_dcc: Simplify put_chars()/get_chars() loops Stephen Boyd 2011-02-03 23:48 ` Stephen Boyd 2011-02-03 23:48 ` [PATCHv2 3/3] hvc_dcc: Simplify assembly for v6 and v7 ARM Stephen Boyd 2011-02-03 23:48 ` Stephen Boyd 2010-12-01 20:20 ` Stephen Boyd [this message] 2010-12-01 20:20 ` [PATCH] drivers: char: hvc: add arm JTAG DCC console support Stephen Boyd 2010-12-07 19:10 ` Stephen Boyd 2010-12-07 19:10 ` Stephen Boyd 2011-01-14 19:19 ` Tony Lindgren 2011-01-14 19:19 ` Tony Lindgren 2011-01-14 23:49 ` Stephen Boyd 2011-01-14 23:49 ` Stephen Boyd 2011-04-07 18:39 ` RONETIX - Asen Dimov 2011-04-07 18:39 ` RONETIX - Asen Dimov 2011-04-07 18:57 ` Mike Frysinger 2011-04-07 18:57 ` Mike Frysinger 2020-02-01 5:06 reinaldo rojas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4CF6AE04.6030201@codeaurora.org \ --to=sboyd@codeaurora.org \ --cc=akpm@linux-foundation.org \ --cc=alan@lxorguk.ukuu.org.uk \ --cc=arnd@arndb.de \ --cc=dwalker@codeaurora.org \ --cc=fujita.tomonori@lab.ntt.co.jp \ --cc=gregkh@suse.de \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=nico@fluxnic.net \ --cc=randy.dunlap@oracle.com \ --cc=tony@atomide.com \ --cc=vapier@gentoo.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.