All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Arnaud Lacombe <lacombar@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Tony Lindgren <tony@atomide.com>, Arnd Bergmann <arnd@arndb.de>,
	Nicolas Pitre <nicolas.pitre@linaro.org>,
	Daniel Walker <dwalker@codeaurora.org>
Subject: Re: [PATCH 1/3] hvc_dcc: Fix bad code generation by marking assembly volatile
Date: Mon, 20 Dec 2010 13:52:46 -0800	[thread overview]
Message-ID: <4D0FD02E.3080901@codeaurora.org> (raw)
In-Reply-To: <AANLkTi=8F3keaAQ2o+V8gNncNM02c9k9=DRtd5GyP_LH@mail.gmail.com>

On 12/20/2010 01:49 PM, Arnaud Lacombe wrote:
> Hi,
>
> On Mon, Dec 20, 2010 at 3:08 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>> Without marking the asm __dcc_getstatus() volatile my compiler
>> decides [...]
> What compiler ? That might be a usefull information to know,
> espectially 5 years from now when tracing code history. There has been
> similar issue with gcc 4.5 recently. AFAIK, in the same idea, the
> final change has been to mark the asm volatile.

Sure, we can replace "my compiler" with "my compiler (arm-eabi-gcc (GCC)
4.4.0)".

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] hvc_dcc: Fix bad code generation by marking assembly volatile
Date: Mon, 20 Dec 2010 13:52:46 -0800	[thread overview]
Message-ID: <4D0FD02E.3080901@codeaurora.org> (raw)
In-Reply-To: <AANLkTi=8F3keaAQ2o+V8gNncNM02c9k9=DRtd5GyP_LH@mail.gmail.com>

On 12/20/2010 01:49 PM, Arnaud Lacombe wrote:
> Hi,
>
> On Mon, Dec 20, 2010 at 3:08 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>> Without marking the asm __dcc_getstatus() volatile my compiler
>> decides [...]
> What compiler ? That might be a usefull information to know,
> espectially 5 years from now when tracing code history. There has been
> similar issue with gcc 4.5 recently. AFAIK, in the same idea, the
> final change has been to mark the asm volatile.

Sure, we can replace "my compiler" with "my compiler (arm-eabi-gcc (GCC)
4.4.0)".

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  reply	other threads:[~2010-12-20 21:52 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-30 19:25 [PATCH] drivers: char: hvc: add arm JTAG DCC console support Daniel Walker
2010-11-30 19:25 ` Daniel Walker
2010-11-30 19:57 ` Nicolas Pitre
2010-11-30 19:57   ` Nicolas Pitre
2010-11-30 21:17   ` Arnd Bergmann
2010-11-30 21:17     ` Arnd Bergmann
2010-12-01  5:30 ` Stephen Boyd
2010-12-01  5:30   ` Stephen Boyd
2010-12-01 18:54   ` Daniel Walker
2010-12-01 18:54     ` Daniel Walker
2010-12-01 19:28     ` Greg KH
2010-12-01 19:28       ` Greg KH
2010-12-18  5:16       ` [PATCH] hvc_dcc: Simplify assembly for v6 and v7 ARM Stephen Boyd
2010-12-18  5:16         ` Stephen Boyd
2010-12-20 17:51         ` Daniel Walker
2010-12-20 17:51           ` Daniel Walker
2010-12-20 18:39           ` Stephen Boyd
2010-12-20 18:39             ` Stephen Boyd
2010-12-20 18:46             ` Nicolas Pitre
2010-12-20 18:46               ` Nicolas Pitre
2010-12-20 20:08         ` [PATCH 0/3] hvc_dcc cleanups and fixes Stephen Boyd
2010-12-20 20:08           ` Stephen Boyd
2010-12-20 20:08           ` [PATCH 1/3] hvc_dcc: Fix bad code generation by marking assembly volatile Stephen Boyd
2010-12-20 20:08             ` Stephen Boyd
2010-12-20 21:39             ` Nicolas Pitre
2010-12-20 21:39               ` Nicolas Pitre
2011-01-02  9:00               ` Pavel Machek
2011-01-02  9:00                 ` Pavel Machek
2011-01-02 18:49                 ` David Brown
2011-01-02 18:49                   ` David Brown
2011-01-03  5:50                   ` Pavel Machek
2011-01-03  5:50                     ` Pavel Machek
2011-01-04 18:49               ` Tony Lindgren
2011-01-04 18:49                 ` Tony Lindgren
2010-12-20 21:49             ` Arnaud Lacombe
2010-12-20 21:49               ` Arnaud Lacombe
2010-12-20 21:52               ` Stephen Boyd [this message]
2010-12-20 21:52                 ` Stephen Boyd
2010-12-20 22:10                 ` Nicolas Pitre
2010-12-20 22:10                   ` Nicolas Pitre
2010-12-20 20:08           ` [PATCH 2/3] hvc_dcc: Simplify put_chars()/get_chars() loops Stephen Boyd
2010-12-20 20:08             ` Stephen Boyd
2010-12-20 20:08           ` [PATCH 3/3] hvc_dcc: Simplify assembly for v6 and v7 ARM Stephen Boyd
2010-12-20 20:08             ` Stephen Boyd
2010-12-20 21:44             ` Nicolas Pitre
2010-12-20 21:44               ` Nicolas Pitre
2011-01-04 18:52               ` Tony Lindgren
2011-01-04 18:52                 ` Tony Lindgren
2011-01-06  1:49           ` [PATCH 0/3] hvc_dcc cleanups and fixes Stephen Boyd
2011-01-06  1:49             ` Stephen Boyd
2011-01-06  3:20             ` Greg KH
2011-01-06  3:20               ` Greg KH
2011-02-03 22:17           ` Greg KH
2011-02-03 22:17             ` Greg KH
2011-02-03 22:17             ` Greg KH
2011-02-03 23:19             ` Stephen Boyd
2011-02-03 23:19               ` Stephen Boyd
2011-02-03 23:30               ` Greg KH
2011-02-03 23:30                 ` Greg KH
2011-02-03 23:48             ` [PATCHv2 " Stephen Boyd
2011-02-03 23:48               ` Stephen Boyd
2011-02-03 23:48               ` [PATCHv2 1/3] hvc_dcc: Fix bad code generation by marking assembly volatile Stephen Boyd
2011-02-03 23:48                 ` Stephen Boyd
2011-02-03 23:48               ` [PATCHv2 2/3] hvc_dcc: Simplify put_chars()/get_chars() loops Stephen Boyd
2011-02-03 23:48                 ` Stephen Boyd
2011-02-03 23:48               ` [PATCHv2 3/3] hvc_dcc: Simplify assembly for v6 and v7 ARM Stephen Boyd
2011-02-03 23:48                 ` Stephen Boyd
2010-12-01 20:20     ` [PATCH] drivers: char: hvc: add arm JTAG DCC console support Stephen Boyd
2010-12-01 20:20       ` Stephen Boyd
2010-12-07 19:10       ` Stephen Boyd
2010-12-07 19:10         ` Stephen Boyd
2011-01-14 19:19         ` Tony Lindgren
2011-01-14 19:19           ` Tony Lindgren
2011-01-14 23:49           ` Stephen Boyd
2011-01-14 23:49             ` Stephen Boyd
2011-04-07 18:39 ` RONETIX - Asen Dimov
2011-04-07 18:39   ` RONETIX - Asen Dimov
2011-04-07 18:57   ` Mike Frysinger
2011-04-07 18:57     ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D0FD02E.3080901@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=arnd@arndb.de \
    --cc=dwalker@codeaurora.org \
    --cc=gregkh@suse.de \
    --cc=lacombar@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.pitre@linaro.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.