All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Mallon <ryan@bluewatersys.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Mandeep Singh Baines <msb@chromium.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Randy Dunlap <rdunlap@xenotime.net>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	olofj@chromium.org
Subject: Re: [PATCH] printk: allow setting DEFAULT_MESSAGE_LEVEL via Kconfig
Date: Fri, 28 Jan 2011 09:57:38 +1300	[thread overview]
Message-ID: <4D41DC42.3070603@bluewatersys.com> (raw)
In-Reply-To: <20110127205357.GA4731@p183.telecom.by>

On 01/28/2011 09:53 AM, Alexey Dobriyan wrote:
> On Fri, Jan 28, 2011 at 09:45:23AM +1300, Ryan Mallon wrote:
>> Why not make printk prefix messages that have no log level with
>> "[NO_LOG_LEVEL]" or similar? That way the can easily be grepped out, and
>> it provides and incentive for people to fix them :-).
> 
> Because printk("foo"); ... printk("\n"); is legit.

It should be fixed to KERN_CONT should it not?

~Ryan

-- 
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon         		5 Amuri Park, 404 Barbadoes St
ryan@bluewatersys.com         	PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com	New Zealand
Phone: +64 3 3779127		Freecall: Australia 1800 148 751
Fax:   +64 3 3779135			  USA 1800 261 2934

  reply	other threads:[~2011-01-27 20:57 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-25 23:57 [PATCH] printk: allow setting DEFAULT_MESSAGE_LEVEL via Kconfig Mandeep Singh Baines
2011-01-26  0:40 ` Joe Perches
2011-01-26  1:01   ` Mandeep Singh Baines
2011-01-26  1:15     ` Joe Perches
2011-01-26  4:18 ` WANG Cong
2011-01-26 23:05   ` Mandeep Baines
2011-01-27  5:49     ` WANG Cong
2011-01-26 22:49 ` Andrew Morton
2011-01-26 22:57   ` Randy Dunlap
2011-01-26 23:10     ` Andrew Morton
2011-01-27  7:26       ` WANG Cong
2011-01-27  8:27       ` Alexey Dobriyan
2011-01-27 15:57         ` Mandeep Singh Baines
2011-01-27 20:45           ` Ryan Mallon
2011-01-27 20:53             ` Alexey Dobriyan
2011-01-27 20:57               ` Ryan Mallon [this message]
2011-01-26 23:29 ` [PATCH v1 0/6] Set printk priority level Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines
2011-01-27  7:22   ` WANG Cong
2011-01-27  7:22     ` WANG Cong
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 1/6] mm/page_alloc: use appropriate " Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines
2011-01-27  0:32   ` Ryan Mallon
2011-01-27  0:32   ` Ryan Mallon
2011-01-27  0:32     ` Ryan Mallon
2011-01-27  4:22     ` Mandeep Singh Baines
2011-01-27  4:22     ` Mandeep Singh Baines
2011-01-27  4:22       ` Mandeep Singh Baines
2011-01-27 20:32       ` Ryan Mallon
2011-01-27 20:32       ` Ryan Mallon
2011-01-27 20:32         ` Ryan Mallon
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 2/6] arch/x86: " Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 3/6] PM: " Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines
2011-01-31 10:12   ` Rafael J. Wysocki
2011-01-31 10:12   ` Rafael J. Wysocki
2011-01-31 10:12     ` Rafael J. Wysocki
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 4/6] TTY: " Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines
2011-02-03 22:13   ` Greg KH
2011-02-03 22:13     ` Greg KH
2011-02-06 17:31     ` [PATCH v2] " Mandeep Singh Baines
2011-02-06 17:31     ` Mandeep Singh Baines
2011-02-06 17:31       ` Mandeep Singh Baines
2011-02-03 22:13   ` [PATCH 4/6] " Greg KH
2011-01-26 23:29 ` [PATCH 5/6] fs: " Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 6/6] taskstats: " Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D41DC42.3070603@bluewatersys.com \
    --to=ryan@bluewatersys.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=msb@chromium.org \
    --cc=olofj@chromium.org \
    --cc=rdunlap@xenotime.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.