From: Mandeep Singh Baines <msb@chromium.org> To: gregkh@suse.de, rjw@sisk.pl, mingo@redhat.com, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-pm@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Mandeep Singh Baines <msb@chromium.org> Subject: [PATCH 2/6] arch/x86: use appropriate printk priority level Date: Wed, 26 Jan 2011 15:29:26 -0800 [thread overview] Message-ID: <1296084570-31453-3-git-send-email-msb@chromium.org> (raw) In-Reply-To: <20110125235700.GR8008@google.com> printk()s without a priority level default to KERN_WARNING. To reduce noise at KERN_WARNING, this patch set the priority level appriopriately for unleveled printks()s. This should be useful to folks that look at dmesg warnings closely. Signed-off-by: Mandeep Singh Baines <msb@chromium.org> --- arch/x86/kernel/tsc.c | 9 +++++---- arch/x86/platform/efi/efi.c | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index ffe5755..dbf2cbc 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -373,7 +373,7 @@ static unsigned long quick_pit_calibrate(void) goto success; } } - printk("Fast TSC calibration failed\n"); + printk(KERN_WARNING "Fast TSC calibration failed\n"); return 0; success: @@ -395,7 +395,7 @@ success: delta += (long)(d2 - d1)/2; delta *= PIT_TICK_RATE; do_div(delta, i*256*1000); - printk("Fast TSC calibration using PIT\n"); + printk(KERN_INFO "Fast TSC calibration using PIT\n"); return delta; } @@ -518,7 +518,8 @@ unsigned long native_calibrate_tsc(void) /* We don't have an alternative source, disable TSC */ if (!hpet && !ref1 && !ref2) { - printk("TSC: No reference (HPET/PMTIMER) available\n"); + printk(KERN_WARNING + "TSC: No reference (HPET/PMTIMER) available\n"); return 0; } @@ -1002,7 +1003,7 @@ void __init tsc_init(void) return; } - printk("Detected %lu.%03lu MHz processor.\n", + printk(KERN_INFO "Detected %lu.%03lu MHz processor.\n", (unsigned long)cpu_khz / 1000, (unsigned long)cpu_khz % 1000); diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c index 0fe27d7..0da6907 100644 --- a/arch/x86/platform/efi/efi.c +++ b/arch/x86/platform/efi/efi.c @@ -376,7 +376,7 @@ void __init efi_init(void) if (config_tables == NULL) printk(KERN_ERR "Could not map EFI Configuration Table!\n"); - printk(KERN_INFO); + printk(KERN_INFO " "); for (i = 0; i < efi.systab->nr_tables; i++) { if (!efi_guidcmp(config_tables[i].guid, MPS_TABLE_GUID)) { efi.mps = config_tables[i].table; -- 1.7.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Mandeep Singh Baines <msb@chromium.org> To: gregkh@suse.de, rjw@sisk.pl, mingo@redhat.com, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-pm@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Mandeep Singh Baines <msb@chromium.org> Subject: [PATCH 2/6] arch/x86: use appropriate printk priority level Date: Wed, 26 Jan 2011 15:29:26 -0800 [thread overview] Message-ID: <1296084570-31453-3-git-send-email-msb@chromium.org> (raw) In-Reply-To: <20110125235700.GR8008@google.com> printk()s without a priority level default to KERN_WARNING. To reduce noise at KERN_WARNING, this patch set the priority level appriopriately for unleveled printks()s. This should be useful to folks that look at dmesg warnings closely. Signed-off-by: Mandeep Singh Baines <msb@chromium.org> --- arch/x86/kernel/tsc.c | 9 +++++---- arch/x86/platform/efi/efi.c | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index ffe5755..dbf2cbc 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -373,7 +373,7 @@ static unsigned long quick_pit_calibrate(void) goto success; } } - printk("Fast TSC calibration failed\n"); + printk(KERN_WARNING "Fast TSC calibration failed\n"); return 0; success: @@ -395,7 +395,7 @@ success: delta += (long)(d2 - d1)/2; delta *= PIT_TICK_RATE; do_div(delta, i*256*1000); - printk("Fast TSC calibration using PIT\n"); + printk(KERN_INFO "Fast TSC calibration using PIT\n"); return delta; } @@ -518,7 +518,8 @@ unsigned long native_calibrate_tsc(void) /* We don't have an alternative source, disable TSC */ if (!hpet && !ref1 && !ref2) { - printk("TSC: No reference (HPET/PMTIMER) available\n"); + printk(KERN_WARNING + "TSC: No reference (HPET/PMTIMER) available\n"); return 0; } @@ -1002,7 +1003,7 @@ void __init tsc_init(void) return; } - printk("Detected %lu.%03lu MHz processor.\n", + printk(KERN_INFO "Detected %lu.%03lu MHz processor.\n", (unsigned long)cpu_khz / 1000, (unsigned long)cpu_khz % 1000); diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c index 0fe27d7..0da6907 100644 --- a/arch/x86/platform/efi/efi.c +++ b/arch/x86/platform/efi/efi.c @@ -376,7 +376,7 @@ void __init efi_init(void) if (config_tables == NULL) printk(KERN_ERR "Could not map EFI Configuration Table!\n"); - printk(KERN_INFO); + printk(KERN_INFO " "); for (i = 0; i < efi.systab->nr_tables; i++) { if (!efi_guidcmp(config_tables[i].guid, MPS_TABLE_GUID)) { efi.mps = config_tables[i].table; -- 1.7.3.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-01-26 23:31 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-01-25 23:57 [PATCH] printk: allow setting DEFAULT_MESSAGE_LEVEL via Kconfig Mandeep Singh Baines 2011-01-26 0:40 ` Joe Perches 2011-01-26 1:01 ` Mandeep Singh Baines 2011-01-26 1:15 ` Joe Perches 2011-01-26 4:18 ` WANG Cong 2011-01-26 23:05 ` Mandeep Baines 2011-01-27 5:49 ` WANG Cong 2011-01-26 22:49 ` Andrew Morton 2011-01-26 22:57 ` Randy Dunlap 2011-01-26 23:10 ` Andrew Morton 2011-01-27 7:26 ` WANG Cong 2011-01-27 8:27 ` Alexey Dobriyan 2011-01-27 15:57 ` Mandeep Singh Baines 2011-01-27 20:45 ` Ryan Mallon 2011-01-27 20:53 ` Alexey Dobriyan 2011-01-27 20:57 ` Ryan Mallon 2011-01-26 23:29 ` [PATCH v1 0/6] Set printk priority level Mandeep Singh Baines 2011-01-26 23:29 ` Mandeep Singh Baines 2011-01-27 7:22 ` WANG Cong 2011-01-27 7:22 ` WANG Cong 2011-01-26 23:29 ` Mandeep Singh Baines 2011-01-26 23:29 ` [PATCH 1/6] mm/page_alloc: use appropriate " Mandeep Singh Baines 2011-01-26 23:29 ` Mandeep Singh Baines 2011-01-27 0:32 ` Ryan Mallon 2011-01-27 0:32 ` Ryan Mallon 2011-01-27 0:32 ` Ryan Mallon 2011-01-27 4:22 ` Mandeep Singh Baines 2011-01-27 4:22 ` Mandeep Singh Baines 2011-01-27 4:22 ` Mandeep Singh Baines 2011-01-27 20:32 ` Ryan Mallon 2011-01-27 20:32 ` Ryan Mallon 2011-01-27 20:32 ` Ryan Mallon 2011-01-26 23:29 ` Mandeep Singh Baines 2011-01-26 23:29 ` Mandeep Singh Baines [this message] 2011-01-26 23:29 ` [PATCH 2/6] arch/x86: " Mandeep Singh Baines 2011-01-26 23:29 ` Mandeep Singh Baines 2011-01-26 23:29 ` [PATCH 3/6] PM: " Mandeep Singh Baines 2011-01-26 23:29 ` Mandeep Singh Baines 2011-01-31 10:12 ` Rafael J. Wysocki 2011-01-31 10:12 ` Rafael J. Wysocki 2011-01-31 10:12 ` Rafael J. Wysocki 2011-01-26 23:29 ` Mandeep Singh Baines 2011-01-26 23:29 ` [PATCH 4/6] TTY: " Mandeep Singh Baines 2011-01-26 23:29 ` Mandeep Singh Baines 2011-01-26 23:29 ` Mandeep Singh Baines 2011-02-03 22:13 ` Greg KH 2011-02-03 22:13 ` Greg KH 2011-02-06 17:31 ` [PATCH v2] " Mandeep Singh Baines 2011-02-06 17:31 ` Mandeep Singh Baines 2011-02-06 17:31 ` Mandeep Singh Baines 2011-02-03 22:13 ` [PATCH 4/6] " Greg KH 2011-01-26 23:29 ` [PATCH 5/6] fs: " Mandeep Singh Baines 2011-01-26 23:29 ` Mandeep Singh Baines 2011-01-26 23:29 ` Mandeep Singh Baines 2011-01-26 23:29 ` [PATCH 6/6] taskstats: " Mandeep Singh Baines 2011-01-26 23:29 ` Mandeep Singh Baines 2011-01-26 23:29 ` Mandeep Singh Baines
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1296084570-31453-3-git-send-email-msb@chromium.org \ --to=msb@chromium.org \ --cc=akpm@linux-foundation.org \ --cc=gregkh@suse.de \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-pm@lists.linux-foundation.org \ --cc=mingo@redhat.com \ --cc=rjw@sisk.pl \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.