All of lore.kernel.org
 help / color / mirror / Atom feed
From: WANG Cong <xiyou.wangcong@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: allow setting DEFAULT_MESSAGE_LEVEL via Kconfig
Date: Thu, 27 Jan 2011 05:49:04 +0000 (UTC)	[thread overview]
Message-ID: <ihr10g$qmm$2@dough.gmane.org> (raw)
In-Reply-To: AANLkTikaDpZ=Pjb+m7ixCepywtO1bUN02sfimWBSTha3@mail.gmail.com

On Wed, 26 Jan 2011 15:05:48 -0800, Mandeep Baines wrote:

> On Tue, Jan 25, 2011 at 8:18 PM, WANG Cong <xiyou.wangcong@gmail.com>
> wrote:
>>
>> On Tue, 25 Jan 2011 15:57:00 -0800, Mandeep Singh Baines wrote:
>>
>> > We've been burned by regressions/bugs which we later realized could
>> > have been triaged quicker if only we'd paid closer attention to
>> > dmesg. To make it easier to audit dmesg, we'd like to make
>> > DEFAULT_MESSAGE_LEVEL Kconfig-settable. That way we can set it to
>> > KERN_NOTICE and audit any messages <= KERN_WARNING.
>> >
>> >
>> Why? We already have "loglevel=" kernel parameter.
>>
>>
> loglevel allows you to control which messages go to the console.
> 
> DEFAULT_MESSAGE_LEVEL selects the default message levels for printk()s
> which don't specify a message level.


I think you should fix them instead.

> 
> Most printks()s without a message level aren't really warnings and just
> create noise
> if you're trying to look closely at all warnings. Some of this is just
> old code but new
> printk()s without a message level do get committed from time to time.
> 

IIRC, checkpatch.pl will complain about this.



  reply	other threads:[~2011-01-27  5:49 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-25 23:57 [PATCH] printk: allow setting DEFAULT_MESSAGE_LEVEL via Kconfig Mandeep Singh Baines
2011-01-26  0:40 ` Joe Perches
2011-01-26  1:01   ` Mandeep Singh Baines
2011-01-26  1:15     ` Joe Perches
2011-01-26  4:18 ` WANG Cong
2011-01-26 23:05   ` Mandeep Baines
2011-01-27  5:49     ` WANG Cong [this message]
2011-01-26 22:49 ` Andrew Morton
2011-01-26 22:57   ` Randy Dunlap
2011-01-26 23:10     ` Andrew Morton
2011-01-27  7:26       ` WANG Cong
2011-01-27  8:27       ` Alexey Dobriyan
2011-01-27 15:57         ` Mandeep Singh Baines
2011-01-27 20:45           ` Ryan Mallon
2011-01-27 20:53             ` Alexey Dobriyan
2011-01-27 20:57               ` Ryan Mallon
2011-01-26 23:29 ` [PATCH v1 0/6] Set printk priority level Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines
2011-01-27  7:22   ` WANG Cong
2011-01-27  7:22     ` WANG Cong
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 1/6] mm/page_alloc: use appropriate " Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines
2011-01-27  0:32   ` Ryan Mallon
2011-01-27  0:32   ` Ryan Mallon
2011-01-27  0:32     ` Ryan Mallon
2011-01-27  4:22     ` Mandeep Singh Baines
2011-01-27  4:22     ` Mandeep Singh Baines
2011-01-27  4:22       ` Mandeep Singh Baines
2011-01-27 20:32       ` Ryan Mallon
2011-01-27 20:32       ` Ryan Mallon
2011-01-27 20:32         ` Ryan Mallon
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 2/6] arch/x86: " Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 3/6] PM: " Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines
2011-01-31 10:12   ` Rafael J. Wysocki
2011-01-31 10:12   ` Rafael J. Wysocki
2011-01-31 10:12     ` Rafael J. Wysocki
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 4/6] TTY: " Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines
2011-02-03 22:13   ` Greg KH
2011-02-03 22:13     ` Greg KH
2011-02-06 17:31     ` [PATCH v2] " Mandeep Singh Baines
2011-02-06 17:31     ` Mandeep Singh Baines
2011-02-06 17:31       ` Mandeep Singh Baines
2011-02-03 22:13   ` [PATCH 4/6] " Greg KH
2011-01-26 23:29 ` [PATCH 5/6] fs: " Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 6/6] taskstats: " Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='ihr10g$qmm$2@dough.gmane.org' \
    --to=xiyou.wangcong@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.