[PATCH] xl: fix xl cpupool-list <poolid>

[PATCH] xl: fix xl cpupool-list <poolid>

[Andre Przywara]

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

Hi,

the help screen of xl cpupool-list promises to allow a CPU pool to
be named on the command line, which will then be listed only.
Probably caused by a "DeMorgan brain twist" this specific CPU pool
is _omitted_ instead. The patch fixes this, so single CPU pools
can be explicitly listed again.

Signed-off-by: Andre Przywara <andre.przywara@amd.com>

Regards,
Andre.

-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany


[-- Attachment #2: xl_fix_cpupool_list_poolid.patch --]
[-- Type: text/plain, Size: 1166 bytes --]

commit 94738f94d02714624a6aa1a66b3af23cc7941ef3
Author: Andre Przywara <andre.przywara@amd.com>
Date:   Thu Jan 27 23:55:40 2011 +0100

    fix xl cpupool-list <poolid>
    
    The help screen of cpupool-list promises to allow a CPU pool to
    be named on the command line, which will then be listed only.
    Probably caused by a "DeMorgan brain twist" this specific CPU pool
    is _omitted_ instead. The patch fixes this, so single CPU pools
    can be explicitly listed again.
    
    Signed-off-by: Andre Przywara <andre.przywara@amd.com>

diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index e0aa93d..6341767 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -5427,7 +5427,7 @@ int main_cpupoollist(int argc, char **argv)
         printf("CPUs   Sched     Active   Domain count\n");
 
     for (p = 0; p < n_pools; p++) {
-        if (!ret && (!pool || (poolinfo[p].poolid != poolid))) {
+        if (!ret && (!pool || (poolinfo[p].poolid == poolid))) {
             name = libxl_cpupoolid_to_name(&ctx, poolinfo[p].poolid);
             if (!name) {
                 fprintf(stderr, "error getting cpupool info\n");

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] xl: fix xl cpupool-list <poolid>

[Juergen Gross]

On 01/28/11 00:34, Andre Przywara wrote:
> Hi,
>
> the help screen of xl cpupool-list promises to allow a CPU pool to
> be named on the command line, which will then be listed only.
> Probably caused by a "DeMorgan brain twist" this specific CPU pool
> is _omitted_ instead. The patch fixes this, so single CPU pools
> can be explicitly listed again.
>
> Signed-off-by: Andre Przywara <andre.przywara@amd.com>

Nice catch!
Acked-by: juergen.gross@ts.fujitsu.com

-- 
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

Re: [PATCH] xl: fix xl cpupool-list <poolid>

[Ian Jackson]

Juergen Gross writes ("Re: [Xen-devel] [PATCH] xl: fix xl cpupool-list <poolid>"):
> On 01/28/11 00:34, Andre Przywara wrote:
> > the help screen of xl cpupool-list promises to allow a CPU pool to
> > be named on the command line, which will then be listed only.
> > Probably caused by a "DeMorgan brain twist" this specific CPU pool
> > is _omitted_ instead. The patch fixes this, so single CPU pools
> > can be explicitly listed again.
> 
> Nice catch!
> Acked-by: juergen.gross@ts.fujitsu.com

Thanks, applied.

Ian.