All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: "ext Bensaid, Selma" <selma.bensaid@intel.com>
Cc: ext Mauro Carvalho Chehab <mchehab@redhat.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"sameo@linux.intel.com" <sameo@linux.intel.com>,
	ext Mark Brown <broonie@opensource.wolfsonmicro.com>,
	"hverkuil@xs4all.nl" <hverkuil@xs4all.nl>,
	"matti.j.aaltonen@nokia.com" <matti.j.aaltonen@nokia.com>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>
Subject: Re: [alsa-devel] WL1273 FM Radio driver...
Date: Tue, 08 Feb 2011 13:02:39 +0200	[thread overview]
Message-ID: <4D5122CF.3010403@nokia.com> (raw)
In-Reply-To: <2A84145621092446B6659B8A0F28E26F47010C29F1@irsmsx501.ger.corp.intel.com>

On 02/08/11 12:09, ext Bensaid, Selma wrote:
> 2 Digital interfaces are possible for FM WL1273:
> - the external connection: the I2S lines are used for the FM PCM samples
> - the internal connection: the BT PCM interface is used for the FM PCM samples

Yes, that is correct, I just did not wanted to go into details.
Currently the ASoC codec driver only supports the BT/FM PCM interface.
Adding the dedicated I2S interface for the FM radio should not be a big
effort, we just need to add another dai to the codec driver, and connect
that to the host processor.
As I said before, we only implemented the BT/FM PCM interface support,
since we do not have HW, where we could verify the dedicated FM I2S
lines. But adding the support should not be a big deal IMHO (and can be
done even without any means of testing it).

> For both configuration we have a set of HCI commands to configure the FM audio 
> path and one of my concerns is to know if the wl1273_codec should handle the audio path configuration 
> and the switch between FM and BT SCO?

It would be better if the codec could handle the configuration,
depending on which DAI is in use. If we can send HCI commands from
kernel, I think that would be the cleanest way.

-- 
Péter

WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: "ext Bensaid, Selma" <selma.bensaid@intel.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	ext Mauro Carvalho Chehab <mchehab@redhat.com>,
	ext Mark Brown <broonie@opensource.wolfsonmicro.com>,
	"hverkuil@xs4all.nl" <hverkuil@xs4all.nl>,
	"matti.j.aaltonen@nokia.com" <matti.j.aaltonen@nokia.com>,
	"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"sameo@linux.intel.com" <sameo@linux.intel.com>
Subject: Re: WL1273 FM Radio driver...
Date: Tue, 08 Feb 2011 13:02:39 +0200	[thread overview]
Message-ID: <4D5122CF.3010403@nokia.com> (raw)
In-Reply-To: <2A84145621092446B6659B8A0F28E26F47010C29F1@irsmsx501.ger.corp.intel.com>

On 02/08/11 12:09, ext Bensaid, Selma wrote:
> 2 Digital interfaces are possible for FM WL1273:
> - the external connection: the I2S lines are used for the FM PCM samples
> - the internal connection: the BT PCM interface is used for the FM PCM samples

Yes, that is correct, I just did not wanted to go into details.
Currently the ASoC codec driver only supports the BT/FM PCM interface.
Adding the dedicated I2S interface for the FM radio should not be a big
effort, we just need to add another dai to the codec driver, and connect
that to the host processor.
As I said before, we only implemented the BT/FM PCM interface support,
since we do not have HW, where we could verify the dedicated FM I2S
lines. But adding the support should not be a big deal IMHO (and can be
done even without any means of testing it).

> For both configuration we have a set of HCI commands to configure the FM audio 
> path and one of my concerns is to know if the wl1273_codec should handle the audio path configuration 
> and the switch between FM and BT SCO?

It would be better if the codec could handle the configuration,
depending on which DAI is in use. If we can send HCI commands from
kernel, I think that would be the cleanest way.

-- 
Péter

  reply	other threads:[~2011-02-08 11:03 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-07 10:52 WL1273 FM Radio driver Matti J. Aaltonen
2011-02-07 12:00 ` Mauro Carvalho Chehab
2011-02-07 12:02   ` Mark Brown
2011-02-07 12:48     ` Mauro Carvalho Chehab
2011-02-07 13:10       ` Mark Brown
2011-02-07 13:48         ` Mauro Carvalho Chehab
2011-02-07 13:52           ` Mark Brown
2011-02-07 14:17             ` Matti J. Aaltonen
2011-02-07 14:17               ` Matti J. Aaltonen
2011-02-07 16:00               ` Mauro Carvalho Chehab
2011-02-08  9:15                 ` [alsa-devel] " Peter Ujfalusi
2011-02-08  9:15                   ` Peter Ujfalusi
2011-02-08 10:09                   ` [alsa-devel] " Bensaid, Selma
2011-02-08 11:02                     ` Peter Ujfalusi [this message]
2011-02-08 11:02                       ` Peter Ujfalusi
2011-02-08 13:47                       ` [alsa-devel] " Bensaid, Selma
2011-02-09  7:14                         ` Matti J. Aaltonen
2011-02-09  7:14                           ` Matti J. Aaltonen
2011-02-09  7:22                       ` [alsa-devel] " Matti J. Aaltonen
2011-02-09  7:22                         ` Matti J. Aaltonen
2011-02-10  9:35                         ` [alsa-devel] " Bensaid, Selma
2011-02-10  9:35                           ` Bensaid, Selma
2011-02-10 10:03                           ` [alsa-devel] " Matti J. Aaltonen
2011-02-10 10:03                             ` Matti J. Aaltonen
2011-02-10 11:02                             ` [alsa-devel] " Mark Brown
2011-02-10 12:10                               ` Matti J. Aaltonen
2011-02-10 12:10                                 ` Matti J. Aaltonen
2011-02-10 12:28                                 ` [alsa-devel] " Mark Brown
2011-02-10 12:28                                   ` Mark Brown
2011-02-10 12:57                                   ` [alsa-devel] " Matti J. Aaltonen
2011-02-10 12:57                                     ` Matti J. Aaltonen
2011-02-10 13:23                                     ` [alsa-devel] " Mark Brown
2011-02-09  7:27                   ` Matti J. Aaltonen
2011-02-09  7:27                     ` Matti J. Aaltonen
2011-02-09  8:47                 ` Matti J. Aaltonen
2011-02-09  8:47                   ` Matti J. Aaltonen
2011-02-07 14:09           ` Matti J. Aaltonen
2011-02-07 14:09             ` Matti J. Aaltonen
2011-02-07 15:57             ` Mauro Carvalho Chehab
2011-02-07 16:01               ` Mark Brown
2011-02-07 13:27       ` Matti J. Aaltonen
2011-02-07 13:27         ` Matti J. Aaltonen
2011-02-07 13:28         ` Mark Brown
2011-02-07 13:34           ` Matti J. Aaltonen
2011-02-07 13:34             ` Matti J. Aaltonen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5122CF.3010403@nokia.com \
    --to=peter.ujfalusi@nokia.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=matti.j.aaltonen@nokia.com \
    --cc=mchehab@redhat.com \
    --cc=sameo@linux.intel.com \
    --cc=selma.bensaid@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.