All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Lyon <christophe.lyon@st.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3] Softfloat: Add support to softfloat to return floatxx_default_nan when, the corresponding target status flag is set.
Date: Tue, 8 Feb 2011 18:51:59 +0100	[thread overview]
Message-ID: <4D5182BF.9050002@st.com> (raw)
In-Reply-To: <AANLkTim_TSvJVnyHFzmOiu52bmMu3_d=4Uz690S15o=1@mail.gmail.com>

On 08.02.2011 16:59, Peter Maydell wrote:
> Your subject is a bit long, which can make it wrap annoyingly in git logs.
> I'd suggest something like:
OK.

 

> This is float32_to_float16() but it looks like you've missed
> float16_to_float32() ?

Well, actually I somewhat managed to persuade myself that it was not necessary to patch float16_to_float32(), but looking at it again it seems there are more bugs in that function:
- the ieee parameter shouldn't be used (my ARM ARM does not mention a different behaviour when AH bit is set)
- it calls float32ToCommonNaN(a) where 'a' is a float16 instead of a float32
- this means implementing float16ToCommonNaN, thus float16_is_signaling_nan()

> 
> Otherwise, looks good, and I can confirm that it fixes
> behaviour of VCVT.F32.F64 and VCVT.F64.F32 when
> the FPSCR.DN bit is set.

Thanks for the confirmation.

Christophe.

  reply	other threads:[~2011-02-08 17:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-07 17:00 [Qemu-devel] [PATCH v3] Softfloat: Add support to softfloat to return floatxx_default_nan when, the corresponding target status flag is set Christophe Lyon
2011-02-08 15:59 ` Peter Maydell
2011-02-08 17:51   ` Christophe Lyon [this message]
2011-02-08 18:53     ` Peter Maydell
2011-02-08 20:06       ` Peter Maydell
2011-02-09 18:35         ` Aurelien Jarno
2011-02-09 18:56           ` Peter Maydell
2011-02-21 16:44             ` Aurelien Jarno
2011-02-21 17:52               ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5182BF.9050002@st.com \
    --to=christophe.lyon@st.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.