All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>, XFS <xfs@oss.sgi.com>,
	Dave Chinner <david@fromorbit.com>,
	Christoph Hellwig <hch@infradead.org>,
	Johannes Weiner <jweiner@redhat.com>,
	Wu Fengguang <fengguang.wu@intel.com>, Jan Kara <jack@suse.cz>,
	Minchan Kim <minchan.kim@gmail.com>
Subject: Re: [PATCH 7/7] mm: vmscan: Immediately reclaim end-of-LRU dirty pages when writeback completes
Date: Fri, 12 Aug 2011 11:27:18 -0400	[thread overview]
Message-ID: <4E454656.9010608@redhat.com> (raw)
In-Reply-To: <1312973240-32576-8-git-send-email-mgorman@suse.de>

On 08/10/2011 06:47 AM, Mel Gorman wrote:
> When direct reclaim encounters a dirty page, it gets recycled around
> the LRU for another cycle. This patch marks the page PageReclaim
> similar to deactivate_page() so that the page gets reclaimed almost
> immediately after the page gets cleaned. This is to avoid reclaiming
> clean pages that are younger than a dirty page encountered at the
> end of the LRU that might have been something like a use-once page.
>
> Signed-off-by: Mel Gorman<mgorman@suse.de>
> Acked-by: Johannes Weiner<jweiner@redhat.com>

I'm thinking we may need to add some code to
ClearPageReclaim to mark_page_accessed, but
that would be completely independent of these
patches, so ...

Reviewed-by: Rik van Riel <riel@redhat.com>

-- 
All rights reversed

WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Jan Kara <jack@suse.cz>, LKML <linux-kernel@vger.kernel.org>,
	XFS <xfs@oss.sgi.com>, Christoph Hellwig <hch@infradead.org>,
	Linux-MM <linux-mm@kvack.org>,
	Minchan Kim <minchan.kim@gmail.com>,
	Wu Fengguang <fengguang.wu@intel.com>,
	Johannes Weiner <jweiner@redhat.com>
Subject: Re: [PATCH 7/7] mm: vmscan: Immediately reclaim end-of-LRU dirty pages when writeback completes
Date: Fri, 12 Aug 2011 11:27:18 -0400	[thread overview]
Message-ID: <4E454656.9010608@redhat.com> (raw)
In-Reply-To: <1312973240-32576-8-git-send-email-mgorman@suse.de>

On 08/10/2011 06:47 AM, Mel Gorman wrote:
> When direct reclaim encounters a dirty page, it gets recycled around
> the LRU for another cycle. This patch marks the page PageReclaim
> similar to deactivate_page() so that the page gets reclaimed almost
> immediately after the page gets cleaned. This is to avoid reclaiming
> clean pages that are younger than a dirty page encountered at the
> end of the LRU that might have been something like a use-once page.
>
> Signed-off-by: Mel Gorman<mgorman@suse.de>
> Acked-by: Johannes Weiner<jweiner@redhat.com>

I'm thinking we may need to add some code to
ClearPageReclaim to mark_page_accessed, but
that would be completely independent of these
patches, so ...

Reviewed-by: Rik van Riel <riel@redhat.com>

-- 
All rights reversed

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>, XFS <xfs@oss.sgi.com>,
	Dave Chinner <david@fromorbit.com>,
	Christoph Hellwig <hch@infradead.org>,
	Johannes Weiner <jweiner@redhat.com>,
	Wu Fengguang <fengguang.wu@intel.com>, Jan Kara <jack@suse.cz>,
	Minchan Kim <minchan.kim@gmail.com>
Subject: Re: [PATCH 7/7] mm: vmscan: Immediately reclaim end-of-LRU dirty pages when writeback completes
Date: Fri, 12 Aug 2011 11:27:18 -0400	[thread overview]
Message-ID: <4E454656.9010608@redhat.com> (raw)
In-Reply-To: <1312973240-32576-8-git-send-email-mgorman@suse.de>

On 08/10/2011 06:47 AM, Mel Gorman wrote:
> When direct reclaim encounters a dirty page, it gets recycled around
> the LRU for another cycle. This patch marks the page PageReclaim
> similar to deactivate_page() so that the page gets reclaimed almost
> immediately after the page gets cleaned. This is to avoid reclaiming
> clean pages that are younger than a dirty page encountered at the
> end of the LRU that might have been something like a use-once page.
>
> Signed-off-by: Mel Gorman<mgorman@suse.de>
> Acked-by: Johannes Weiner<jweiner@redhat.com>

I'm thinking we may need to add some code to
ClearPageReclaim to mark_page_accessed, but
that would be completely independent of these
patches, so ...

Reviewed-by: Rik van Riel <riel@redhat.com>

-- 
All rights reversed

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2011-08-12 15:27 UTC|newest]

Thread overview: 120+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10 10:47 [PATCH 0/7] Reduce filesystem writeback from page reclaim v3 Mel Gorman
2011-08-10 10:47 ` Mel Gorman
2011-08-10 10:47 ` Mel Gorman
2011-08-10 10:47 ` [PATCH 1/7] mm: vmscan: Do not writeback filesystem pages in direct reclaim Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 12:40   ` Johannes Weiner
2011-08-10 12:40     ` Johannes Weiner
2011-08-10 12:40     ` Johannes Weiner
2011-08-11  9:03   ` KAMEZAWA Hiroyuki
2011-08-11  9:03     ` KAMEZAWA Hiroyuki
2011-08-11  9:03     ` KAMEZAWA Hiroyuki
2011-08-11 15:57   ` Rik van Riel
2011-08-11 15:57     ` Rik van Riel
2011-08-11 15:57     ` Rik van Riel
2011-08-10 10:47 ` [PATCH 2/7] mm: vmscan: Remove dead code related to lumpy reclaim waiting on pages under writeback Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 12:41   ` Johannes Weiner
2011-08-10 12:41     ` Johannes Weiner
2011-08-10 12:41     ` Johannes Weiner
2011-08-10 23:19   ` Minchan Kim
2011-08-10 23:19     ` Minchan Kim
2011-08-10 23:19     ` Minchan Kim
2011-08-11  9:05   ` KAMEZAWA Hiroyuki
2011-08-11  9:05     ` KAMEZAWA Hiroyuki
2011-08-11  9:05     ` KAMEZAWA Hiroyuki
2011-08-11 16:52   ` Rik van Riel
2011-08-11 16:52     ` Rik van Riel
2011-08-11 16:52     ` Rik van Riel
2011-08-10 10:47 ` [PATCH 3/7] xfs: Warn if direct reclaim tries to writeback pages Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-11 16:53   ` Rik van Riel
2011-08-11 16:53     ` Rik van Riel
2011-08-11 16:53     ` Rik van Riel
2011-08-10 10:47 ` [PATCH 4/7] ext4: " Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-11 17:07   ` Rik van Riel
2011-08-11 17:07     ` Rik van Riel
2011-08-11 17:07     ` Rik van Riel
2011-08-10 10:47 ` [PATCH 5/7] mm: vmscan: Do not writeback filesystem pages in kswapd except in high priority Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 12:44   ` Johannes Weiner
2011-08-10 12:44     ` Johannes Weiner
2011-08-10 12:44     ` Johannes Weiner
2011-08-11  9:10   ` KAMEZAWA Hiroyuki
2011-08-11  9:10     ` KAMEZAWA Hiroyuki
2011-08-11  9:10     ` KAMEZAWA Hiroyuki
2011-08-11 20:25     ` Mel Gorman
2011-08-11 20:25       ` Mel Gorman
2011-08-11 20:25       ` Mel Gorman
2011-08-17  1:06       ` KAMEZAWA Hiroyuki
2011-08-17  1:06         ` KAMEZAWA Hiroyuki
2011-08-17  1:06         ` KAMEZAWA Hiroyuki
2011-08-11 18:18   ` Rik van Riel
2011-08-11 18:18     ` Rik van Riel
2011-08-11 18:18     ` Rik van Riel
2011-08-11 20:38     ` Mel Gorman
2011-08-11 20:38       ` Mel Gorman
2011-08-11 20:38       ` Mel Gorman
2011-08-10 10:47 ` [PATCH 6/7] mm: vmscan: Throttle reclaim if encountering too many dirty pages under writeback Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-11  9:18   ` KAMEZAWA Hiroyuki
2011-08-11  9:18     ` KAMEZAWA Hiroyuki
2011-08-11  9:18     ` KAMEZAWA Hiroyuki
2011-08-12  2:47   ` Rik van Riel
2011-08-12  2:47     ` Rik van Riel
2011-08-12  2:47     ` Rik van Riel
2011-08-16 14:06   ` Wu Fengguang
2011-08-16 14:06     ` Wu Fengguang
2011-08-16 14:06     ` Wu Fengguang
2011-08-16 15:02     ` Mel Gorman
2011-08-16 15:02       ` Mel Gorman
2011-08-16 15:02       ` Mel Gorman
2011-08-18 14:02       ` Wu Fengguang
2011-08-18 14:02         ` Wu Fengguang
2011-08-18 14:02         ` Wu Fengguang
2011-08-18 23:54   ` Andrew Morton
2011-08-18 23:54     ` Andrew Morton
2011-08-18 23:54     ` Andrew Morton
2011-08-30 13:49     ` Mel Gorman
2011-08-30 13:49       ` Mel Gorman
2011-08-30 13:49       ` Mel Gorman
2011-08-31  9:53     ` Mel Gorman
2011-08-31  9:53       ` Mel Gorman
2011-08-31  9:53       ` Mel Gorman
2011-08-10 10:47 ` [PATCH 7/7] mm: vmscan: Immediately reclaim end-of-LRU dirty pages when writeback completes Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 10:47   ` Mel Gorman
2011-08-10 23:22   ` Minchan Kim
2011-08-10 23:22     ` Minchan Kim
2011-08-10 23:22     ` Minchan Kim
2011-08-11  9:19   ` KAMEZAWA Hiroyuki
2011-08-11  9:19     ` KAMEZAWA Hiroyuki
2011-08-11  9:19     ` KAMEZAWA Hiroyuki
2011-08-12 15:27   ` Rik van Riel [this message]
2011-08-12 15:27     ` Rik van Riel
2011-08-12 15:27     ` Rik van Riel
2011-08-10 11:00 ` [PATCH 0/7] Reduce filesystem writeback from page reclaim v3 Christoph Hellwig
2011-08-10 11:00   ` Christoph Hellwig
2011-08-10 11:00   ` Christoph Hellwig
2011-08-10 11:15   ` Mel Gorman
2011-08-10 11:15     ` Mel Gorman
2011-08-10 11:15     ` Mel Gorman
2011-08-11 23:45     ` Christoph Hellwig
2011-08-11 23:45       ` Christoph Hellwig
2011-08-11 23:45       ` Christoph Hellwig
2011-08-18 23:54 ` Andrew Morton
2011-08-18 23:54   ` Andrew Morton
2011-08-18 23:54   ` Andrew Morton
2011-08-20 19:33   ` Mel Gorman
2011-08-20 19:33     ` Mel Gorman
2011-08-20 19:33     ` Mel Gorman
2011-08-30 13:19   ` Mel Gorman
2011-08-30 13:19     ` Mel Gorman
2011-08-30 13:19     ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E454656.9010608@redhat.com \
    --to=riel@redhat.com \
    --cc=david@fromorbit.com \
    --cc=fengguang.wu@intel.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=jweiner@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=minchan.kim@gmail.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.