From: Clemens Ladisch <clemens@ladisch.de> To: Takashi Iwai <tiwai@suse.de> Cc: Yong Zhang <yong.zhang0@gmail.com>, linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>, alsa-devel@alsa-project.org Subject: Re: [RFC] [PATCH 02/62] mpu401:snd_mpu401_uart_new(): split semantic of irq_flags Date: Mon, 12 Sep 2011 15:16:14 +0200 [thread overview] Message-ID: <4E6E061E.2010000@ladisch.de> (raw) In-Reply-To: <s5hvcsy6nr2.wl%tiwai@suse.de> Takashi Iwai wrote: > Clemens Ladisch wrote: > > --- a/sound/isa/als100.c > > +++ b/sound/isa/als100.c > > @@ -245,18 +245,22 @@ static int __devinit snd_card_als100_probe(int dev, > > > > if (mpu_port[dev] > 0 && mpu_port[dev] != SNDRV_AUTO_PORT) { > > int mpu_type = MPU401_HW_ALS100; > > + int mpu_flags = 0; > > > > - if (mpu_irq[dev] == SNDRV_AUTO_IRQ) > > + if (mpu_irq[dev] == SNDRV_AUTO_IRQ) { > > mpu_irq[dev] = -1; > > + mpu_flags = MPU401_INFO_RX_POLL; > > + } > > When mpu_irq[dev] is set to -1, it won't work. Thanks for noticing this! > Instead of setting mpu_flag in this if block, you'd need another check > of mpu_irq[], i.e. > > if (mpu_irq[dev] == SNDRV_AUTO_IRQ) > mpu_irq[dev] = -1; > if (mpu_irq[dev] < 0) > mpu_flags = MPU401_INFO_RX_POLL; I didn't like all the duplicated code I added to the ISA drivers, and the more code it becomes, the less I like it. But it should be possible to avoid this duplication: snd_mpu401_uart_new() needs to differentiate between three cases: 1) allocate a separate interrupt; 2) do not allocate, use the callback from the driver's interrupt handler; 3) do not allocate, use a timer for polling. Case 1) is indicated by a valid irq number, the other two cases need a flag. All drivers that might use polling switch between 1) or 3), while 2) is always used unconditionally. So if we have this flag for 2) instead of 3), no additional logic is needed in the drivers. (Furthermore, snd_mpu401_uart_new() could check for SNDRV_AUTO_IRQ instead of letting all drivers do this, and the hardware and info_flags parameters could be merged. But this can wait for later.) I'll have a new patch until tomorrow. Regards, Clemens
WARNING: multiple messages have this Message-ID (diff)
From: Clemens Ladisch <clemens@ladisch.de> To: Takashi Iwai <tiwai@suse.de> Cc: Yong Zhang <yong.zhang0@gmail.com>, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [RFC] [PATCH 02/62] mpu401:snd_mpu401_uart_new(): split semantic of irq_flags Date: Mon, 12 Sep 2011 15:16:14 +0200 [thread overview] Message-ID: <4E6E061E.2010000@ladisch.de> (raw) In-Reply-To: <s5hvcsy6nr2.wl%tiwai@suse.de> Takashi Iwai wrote: > Clemens Ladisch wrote: > > --- a/sound/isa/als100.c > > +++ b/sound/isa/als100.c > > @@ -245,18 +245,22 @@ static int __devinit snd_card_als100_probe(int dev, > > > > if (mpu_port[dev] > 0 && mpu_port[dev] != SNDRV_AUTO_PORT) { > > int mpu_type = MPU401_HW_ALS100; > > + int mpu_flags = 0; > > > > - if (mpu_irq[dev] == SNDRV_AUTO_IRQ) > > + if (mpu_irq[dev] == SNDRV_AUTO_IRQ) { > > mpu_irq[dev] = -1; > > + mpu_flags = MPU401_INFO_RX_POLL; > > + } > > When mpu_irq[dev] is set to -1, it won't work. Thanks for noticing this! > Instead of setting mpu_flag in this if block, you'd need another check > of mpu_irq[], i.e. > > if (mpu_irq[dev] == SNDRV_AUTO_IRQ) > mpu_irq[dev] = -1; > if (mpu_irq[dev] < 0) > mpu_flags = MPU401_INFO_RX_POLL; I didn't like all the duplicated code I added to the ISA drivers, and the more code it becomes, the less I like it. But it should be possible to avoid this duplication: snd_mpu401_uart_new() needs to differentiate between three cases: 1) allocate a separate interrupt; 2) do not allocate, use the callback from the driver's interrupt handler; 3) do not allocate, use a timer for polling. Case 1) is indicated by a valid irq number, the other two cases need a flag. All drivers that might use polling switch between 1) or 3), while 2) is always used unconditionally. So if we have this flag for 2) instead of 3), no additional logic is needed in the drivers. (Furthermore, snd_mpu401_uart_new() could check for SNDRV_AUTO_IRQ instead of letting all drivers do this, and the hardware and info_flags parameters could be merged. But this can wait for later.) I'll have a new patch until tomorrow. Regards, Clemens
next prev parent reply other threads:[~2011-09-12 13:15 UTC|newest] Thread overview: 153+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <1315383059-3673-9-git-send-email-yong.zhang0@gmail.com> [not found] ` <1315383059-3673-1-git-send-email-yong.zhang0@gmail.com> 2011-09-07 8:10 ` [PATCH 12/62] m64k: irq: Remove IRQF_DISABLED Yong Zhang 2011-09-08 3:18 ` Greg Ungerer 2011-09-08 3:18 ` Greg Ungerer 2011-09-09 15:05 ` Geert Uytterhoeven 2011-09-10 2:01 ` Yong Zhang 2011-09-10 2:01 ` Yong Zhang 2011-09-09 15:05 ` Geert Uytterhoeven 2011-09-07 8:10 ` [PATCH 13/62] microblaze: " Yong Zhang 2011-09-07 8:10 ` [PATCH 14/62] MIPS: " Yong Zhang 2011-09-07 9:22 ` Ralf Baechle 2011-09-07 8:10 ` [PATCH 17/62] powerpc: " Yong Zhang 2011-09-07 8:10 ` Yong Zhang 2011-09-08 16:41 ` Arnd Bergmann 2011-09-08 16:41 ` Arnd Bergmann 2011-09-07 8:10 ` [PATCH 18/62] score: " Yong Zhang 2011-09-07 8:10 ` [uml-devel] [PATCH 21/62] um: " Yong Zhang 2011-09-07 8:10 ` [PATCH 23/62] x86: " Yong Zhang 2011-09-07 8:10 ` [PATCH 24/62] xtensa: " Yong Zhang 2011-09-07 8:10 ` [PATCH 27/62] [SCSI] " Yong Zhang 2011-09-07 8:10 ` Yong Zhang 2011-09-07 8:10 ` [PATCH 33/62] dmaengine: " Yong Zhang 2011-09-07 15:02 ` Vinod Koul 2011-09-07 15:02 ` Vinod Koul 2011-09-11 21:38 ` Linus Walleij 2011-09-11 21:38 ` Linus Walleij 2011-09-07 8:10 ` [PATCH 36/62] i2c: " Yong Zhang 2011-09-07 8:10 ` Yong Zhang 2011-09-09 7:59 ` Wolfram Sang 2011-09-09 7:59 ` Wolfram Sang 2011-09-11 21:36 ` Linus Walleij 2011-09-11 21:36 ` Linus Walleij 2011-09-11 21:36 ` Linus Walleij 2011-09-19 8:44 ` Barry Song 2011-09-19 8:44 ` Barry Song 2011-09-19 8:44 ` Barry Song 2011-09-07 8:10 ` [PATCH 38/62] Input: " Yong Zhang 2011-09-07 8:10 ` Yong Zhang 2011-09-07 8:10 ` Yong Zhang 2011-09-07 23:21 ` Dmitry Torokhov 2011-09-07 23:21 ` Dmitry Torokhov 2011-09-07 23:21 ` Dmitry Torokhov 2011-09-07 8:10 ` [PATCH 39/62] ISDN: " Yong Zhang 2011-09-07 8:10 ` [PATCH 44/62] mtd: " Yong Zhang 2011-09-09 8:03 ` Wolfram Sang 2011-09-09 8:03 ` Wolfram Sang 2011-09-07 8:10 ` [PATCH 45/62] net: " Yong Zhang 2011-09-07 8:10 ` Yong Zhang 2011-09-07 17:13 ` David Miller 2011-09-07 17:13 ` David Miller 2011-09-07 17:32 ` Thomas Gleixner 2011-09-07 17:32 ` Thomas Gleixner 2011-09-07 17:52 ` David Miller 2011-09-07 17:52 ` David Miller 2011-09-07 18:03 ` Thomas Gleixner 2011-09-07 18:03 ` Thomas Gleixner 2011-09-08 13:41 ` Yong Zhang 2011-09-08 13:41 ` Yong Zhang 2011-09-07 8:10 ` [PATCH 51/62] powerpc/ps3: " Yong Zhang 2011-09-07 17:04 ` Geoff Levand 2011-09-07 17:04 ` Geoff Levand 2011-09-07 8:10 ` [PATCH 52/62] rtc: " Yong Zhang 2011-09-11 21:38 ` Linus Walleij 2011-09-11 21:38 ` Linus Walleij [not found] ` <1315383059-3673-1-git-send-email-yong.zhang0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2011-09-07 8:10 ` [PATCH 53/62] spi: " Yong Zhang 2011-09-07 17:37 ` Grant Likely 2011-09-07 8:10 ` [PATCH 54/62] TTY: " Yong Zhang 2011-09-09 9:49 ` Tobias Klauser 2011-09-09 9:49 ` Tobias Klauser 2011-09-22 23:04 ` Greg KH 2011-09-22 23:04 ` Greg KH 2011-09-22 23:08 ` Greg KH 2011-09-22 23:08 ` Greg KH 2011-09-07 8:10 ` [PATCH 55/62] USB: " Yong Zhang 2011-09-07 8:10 ` Yong Zhang 2011-09-07 8:10 ` Yong Zhang 2011-09-07 8:10 ` [PATCH 56/62] video: " Yong Zhang 2011-09-07 8:10 ` Yong Zhang 2011-09-07 8:10 ` [PATCH 58/62] watchdog: " Yong Zhang 2011-09-09 8:01 ` Wolfram Sang 2011-09-09 8:01 ` Wolfram Sang 2011-09-11 21:37 ` Linus Walleij 2011-09-11 21:37 ` Linus Walleij 2011-09-07 8:10 ` [PATCH 59/62] xen: " Yong Zhang 2011-09-07 8:10 ` [PATCH 60/62] sound: " Yong Zhang 2011-09-07 8:10 ` Yong Zhang 2011-09-07 8:10 ` Yong Zhang 2011-09-07 8:36 ` Péter Ujfalusi 2011-09-07 8:36 ` Péter Ujfalusi 2011-09-07 8:36 ` Péter Ujfalusi 2011-09-07 17:12 ` Mark Brown 2011-09-07 17:12 ` Mark Brown 2011-09-07 17:12 ` Mark Brown 2011-09-07 17:12 ` Mark Brown [not found] ` <1315383059-3673-30-git-send-email-yong.zhang0@gmail.com> 2011-09-07 14:26 ` [PATCH 29/62] block: " Miller, Mike (OS Dev) [not found] ` <1315383059-3673-21-git-send-email-yong.zhang0@gmail.com> 2011-09-07 17:12 ` [PATCH 20/62] sparc: " David Miller 2011-09-07 17:12 ` David Miller 2011-09-07 17:31 ` Thomas Gleixner 2011-09-07 17:31 ` Thomas Gleixner 2011-09-07 17:33 ` Thomas Gleixner 2011-09-07 17:33 ` Thomas Gleixner 2011-09-07 17:51 ` David Miller 2011-09-07 17:51 ` David Miller 2011-09-07 17:57 ` Thomas Gleixner 2011-09-07 17:57 ` Thomas Gleixner 2011-09-07 18:14 ` David Miller 2011-09-07 18:14 ` David Miller 2011-09-07 18:43 ` Thomas Gleixner 2011-09-07 18:43 ` Thomas Gleixner 2011-09-08 3:15 ` Yong Zhang 2011-09-08 3:15 ` Yong Zhang [not found] ` <1315383059-3673-6-git-send-email-yong.zhang0@gmail.com> 2011-09-07 20:29 ` [PATCH 05/62] avr32: " Hans-Christian Egtvedt [not found] ` <1315383059-3673-7-git-send-email-yong.zhang0@gmail.com> 2011-09-08 8:12 ` [uclinux-dist-devel] [PATCH 06/62] Blackfin: " Bob Liu [not found] ` <1315383059-3673-26-git-send-email-yong.zhang0@gmail.com> 2011-09-08 10:40 ` [PATCH 25/62] staging: " Marc Dietich 2011-09-08 13:58 ` Yong Zhang 2011-09-08 14:52 ` Greg KH 2011-09-09 1:12 ` Yong Zhang [not found] ` <1315383059-3673-3-git-send-email-yong.zhang0@gmail.com> 2011-09-08 10:53 ` [RFC] [PATCH 02/62] mpu401:snd_mpu401_uart_new(): split semantic of irq_flags Clemens Ladisch 2011-09-08 10:53 ` Clemens Ladisch 2011-09-08 13:37 ` Yong Zhang 2011-09-08 13:58 ` Clemens Ladisch 2011-09-08 13:58 ` Clemens Ladisch 2011-09-08 14:45 ` Yong Zhang 2011-09-08 20:27 ` Clemens Ladisch 2011-09-08 20:27 ` Clemens Ladisch 2011-09-09 1:31 ` Yong Zhang 2011-09-11 15:10 ` Clemens Ladisch 2011-09-11 15:10 ` Clemens Ladisch 2011-09-12 10:47 ` Takashi Iwai 2011-09-12 10:47 ` Takashi Iwai 2011-09-12 13:16 ` Clemens Ladisch [this message] 2011-09-12 13:16 ` Clemens Ladisch 2011-09-12 20:23 ` Clemens Ladisch 2011-09-12 20:23 ` Clemens Ladisch 2011-09-13 7:12 ` Takashi Iwai 2011-09-13 8:17 ` Clemens Ladisch 2011-09-13 8:17 ` Clemens Ladisch 2011-09-13 9:24 ` Clemens Ladisch 2011-09-14 8:49 ` Yong Zhang 2011-09-14 9:06 ` Takashi Iwai 2011-09-14 9:15 ` Yong Zhang [not found] ` <1315383059-3673-32-git-send-email-yong.zhang0@gmail.com> 2011-09-08 10:55 ` [PATCH 31/62] driver/char: irq: Remove IRQF_DISABLED Clemens Ladisch 2011-09-08 15:29 ` Corey Minyard 2011-09-08 16:04 ` Arnd Bergmann [not found] ` <1315383059-3673-62-git-send-email-yong.zhang0@gmail.com> 2011-09-08 21:38 ` [PATCH 61/62] Documentation: irq: Change documents related to IRQF_DISABLED Randy Dunlap 2011-09-09 1:38 ` Yong Zhang 2011-09-09 1:48 ` [UPDATED] " Yong Zhang 2011-09-09 8:25 ` Rolf Eike Beer 2011-09-09 8:41 ` Yong Zhang [not found] ` <1315383059-3673-48-git-send-email-yong.zhang0@gmail.com> 2011-09-09 8:04 ` [PATCH 47/62] pcmcia: irq: Remove IRQF_DISABLED Wolfram Sang [not found] ` <1315383059-3673-8-git-send-email-yong.zhang0@gmail.com> 2011-09-09 15:10 ` [PATCH 07/62] cris: " Jesper Nilsson [not found] ` <1315383059-3673-42-git-send-email-yong.zhang0@gmail.com> 2011-09-15 19:57 ` [PATCH 41/62] mfd: " Samuel Ortiz 2011-09-20 15:03 ` [PATCH 08/62] frv: " David Howells 2011-09-20 15:04 ` [PATCH 15/62] mn10300: " David Howells
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4E6E061E.2010000@ladisch.de \ --to=clemens@ladisch.de \ --cc=alsa-devel@alsa-project.org \ --cc=linux-kernel@vger.kernel.org \ --cc=perex@perex.cz \ --cc=tiwai@suse.de \ --cc=yong.zhang0@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.