From: Thomas Gleixner <tglx@linutronix.de>
To: David Miller <davem@davemloft.net>
Cc: perex@perex.cz, dhowells@redhat.com, prakity@marvell.com,
netdev@vger.kernel.org, chunkeey@googlemail.com,
sonic.zhang@analog.com, klaus.kudielka@ieee.org,
t.sailer@alumni.ethz.ch, khilman@ti.com, eric.dumazet@gmail.com,
jhovold@gmail.com, cyril@ti.com, rmk+kernel@arm.linux.org.uk,
mingo@elte.hu, jpr@f6fbb.org, adobriyan@gmail.com,
jreuter@yaina.de, cbe-oss-dev@lists.ozlabs.org,
martinez.javier@gmail.com, samuel@sortiz.org, vapier@gentoo.org,
grundler@parisc-linux.org, yong.zhang0@gmail.com,
tklauser@distanz.ch, lucas.demarchi@profusion.mobi,
u.kleine-koenig@pengutronix.de, olof@lixom.net,
uclinux-dist-devel@blackfin.uclinux.org,
linux-hams@vger.kernel.org, leitao@linux.vnet.ibm.com,
blogic@openwrt.org, shawn.guo@linaro.org, nico@fluxnic.net,
geoff@infradead.org, jkosina@suse.cz,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
ralf@linux-mips.org, ralph.
Subject: Re: [PATCH 45/62] net: irq: Remove IRQF_DISABLED
Date: Wed, 7 Sep 2011 20:03:14 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1109072000290.2723@ionos> (raw)
In-Reply-To: <20110907.135234.17759197083710999.davem@davemloft.net>
On Wed, 7 Sep 2011, David Miller wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> Date: Wed, 7 Sep 2011 19:32:39 +0200 (CEST)
>
> > On Wed, 7 Sep 2011, David Miller wrote:
> >
> >> From: Yong Zhang <yong.zhang0@gmail.com>
> >> Date: Wed, 7 Sep 2011 16:10:42 +0800
> >>
> >> > This flag is a NOOP and can be removed now.
> >> >
> >> > Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
> >>
> >> I have the same concerns here as I had for the sparc case.
> >>
> >> Some of these drivers might be using IRQF_DISABLED to make sure the
> >> IRQ cannot be delivered until it is explicitly enabled via an
> >> enable_irq() call.
> >>
> >> How is that being accomodated now?
> >
> > Again IRQF_DISABLED never ever had that functionality.
>
> My bad.
>
> But what if these interrupts want interrupts disabled during their
> interrupt handler, for other reasons?
We run ALL interrupt handlers with irqs disabled always.
> This has the potential to break tons of stuff, especially on the
> really old chips which almost no developers have any more but some
> user might try to use.
It won't. We removed IRQF_DISABLED from kernel/irq/* long ago
Thanks,
tglx
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: David Miller <davem@davemloft.net>
Cc: perex@perex.cz, dhowells@redhat.com, prakity@marvell.com,
netdev@vger.kernel.org, chunkeey@googlemail.com,
sonic.zhang@analog.com, klaus.kudielka@ieee.org,
t.sailer@alumni.ethz.ch, khilman@ti.com, eric.dumazet@gmail.com,
jhovold@gmail.com, cyril@ti.com, rmk+kernel@arm.linux.org.uk,
mingo@elte.hu, jpr@f6fbb.org, adobriyan@gmail.com,
jreuter@yaina.de, cbe-oss-dev@lists.ozlabs.org,
martinez.javier@gmail.com, samuel@sortiz.org, vapier@gentoo.org,
grundler@parisc-linux.org, yong.zhang0@gmail.com,
tklauser@distanz.ch, lucas.demarchi@profusion.mobi,
u.kleine-koenig@pengutronix.de, olof@lixom.net,
uclinux-dist-devel@blackfin.uclinux.org,
linux-hams@vger.kernel.org, leitao@linux.vnet.ibm.com,
blogic@openwrt.org, shawn.guo@linaro.org, nico@fluxnic.net,
geoff@infradead.org, jkosina@suse.cz,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
ralf@linux-mips.org, ralph.hempel@lantiq.com, jdmason@kudzu.us,
joe@perches.com, steve.glendinning@smsc.com,
richard.cochran@omicron.at, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 45/62] net: irq: Remove IRQF_DISABLED
Date: Wed, 7 Sep 2011 20:03:14 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1109072000290.2723@ionos> (raw)
In-Reply-To: <20110907.135234.17759197083710999.davem@davemloft.net>
On Wed, 7 Sep 2011, David Miller wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> Date: Wed, 7 Sep 2011 19:32:39 +0200 (CEST)
>
> > On Wed, 7 Sep 2011, David Miller wrote:
> >
> >> From: Yong Zhang <yong.zhang0@gmail.com>
> >> Date: Wed, 7 Sep 2011 16:10:42 +0800
> >>
> >> > This flag is a NOOP and can be removed now.
> >> >
> >> > Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
> >>
> >> I have the same concerns here as I had for the sparc case.
> >>
> >> Some of these drivers might be using IRQF_DISABLED to make sure the
> >> IRQ cannot be delivered until it is explicitly enabled via an
> >> enable_irq() call.
> >>
> >> How is that being accomodated now?
> >
> > Again IRQF_DISABLED never ever had that functionality.
>
> My bad.
>
> But what if these interrupts want interrupts disabled during their
> interrupt handler, for other reasons?
We run ALL interrupt handlers with irqs disabled always.
> This has the potential to break tons of stuff, especially on the
> really old chips which almost no developers have any more but some
> user might try to use.
It won't. We removed IRQF_DISABLED from kernel/irq/* long ago
Thanks,
tglx
next prev parent reply other threads:[~2011-09-07 18:03 UTC|newest]
Thread overview: 153+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1315383059-3673-9-git-send-email-yong.zhang0@gmail.com>
[not found] ` <1315383059-3673-1-git-send-email-yong.zhang0@gmail.com>
2011-09-07 8:10 ` [PATCH 12/62] m64k: irq: Remove IRQF_DISABLED Yong Zhang
2011-09-08 3:18 ` Greg Ungerer
2011-09-08 3:18 ` Greg Ungerer
2011-09-09 15:05 ` Geert Uytterhoeven
2011-09-10 2:01 ` Yong Zhang
2011-09-10 2:01 ` Yong Zhang
2011-09-09 15:05 ` Geert Uytterhoeven
2011-09-07 8:10 ` [PATCH 13/62] microblaze: " Yong Zhang
2011-09-07 8:10 ` [PATCH 14/62] MIPS: " Yong Zhang
2011-09-07 9:22 ` Ralf Baechle
2011-09-07 8:10 ` [PATCH 17/62] powerpc: " Yong Zhang
2011-09-07 8:10 ` Yong Zhang
2011-09-08 16:41 ` Arnd Bergmann
2011-09-08 16:41 ` Arnd Bergmann
2011-09-07 8:10 ` [PATCH 18/62] score: " Yong Zhang
2011-09-07 8:10 ` [uml-devel] [PATCH 21/62] um: " Yong Zhang
2011-09-07 8:10 ` [PATCH 23/62] x86: " Yong Zhang
2011-09-07 8:10 ` [PATCH 24/62] xtensa: " Yong Zhang
2011-09-07 8:10 ` [PATCH 27/62] [SCSI] " Yong Zhang
2011-09-07 8:10 ` Yong Zhang
2011-09-07 8:10 ` [PATCH 33/62] dmaengine: " Yong Zhang
2011-09-07 15:02 ` Vinod Koul
2011-09-07 15:02 ` Vinod Koul
2011-09-11 21:38 ` Linus Walleij
2011-09-11 21:38 ` Linus Walleij
2011-09-07 8:10 ` [PATCH 36/62] i2c: " Yong Zhang
2011-09-07 8:10 ` Yong Zhang
2011-09-09 7:59 ` Wolfram Sang
2011-09-09 7:59 ` Wolfram Sang
2011-09-11 21:36 ` Linus Walleij
2011-09-11 21:36 ` Linus Walleij
2011-09-11 21:36 ` Linus Walleij
2011-09-19 8:44 ` Barry Song
2011-09-19 8:44 ` Barry Song
2011-09-19 8:44 ` Barry Song
2011-09-07 8:10 ` [PATCH 38/62] Input: " Yong Zhang
2011-09-07 8:10 ` Yong Zhang
2011-09-07 8:10 ` Yong Zhang
2011-09-07 23:21 ` Dmitry Torokhov
2011-09-07 23:21 ` Dmitry Torokhov
2011-09-07 23:21 ` Dmitry Torokhov
2011-09-07 8:10 ` [PATCH 39/62] ISDN: " Yong Zhang
2011-09-07 8:10 ` [PATCH 44/62] mtd: " Yong Zhang
2011-09-09 8:03 ` Wolfram Sang
2011-09-09 8:03 ` Wolfram Sang
2011-09-07 8:10 ` [PATCH 45/62] net: " Yong Zhang
2011-09-07 8:10 ` Yong Zhang
2011-09-07 17:13 ` David Miller
2011-09-07 17:13 ` David Miller
2011-09-07 17:32 ` Thomas Gleixner
2011-09-07 17:32 ` Thomas Gleixner
2011-09-07 17:52 ` David Miller
2011-09-07 17:52 ` David Miller
2011-09-07 18:03 ` Thomas Gleixner [this message]
2011-09-07 18:03 ` Thomas Gleixner
2011-09-08 13:41 ` Yong Zhang
2011-09-08 13:41 ` Yong Zhang
2011-09-07 8:10 ` [PATCH 51/62] powerpc/ps3: " Yong Zhang
2011-09-07 17:04 ` Geoff Levand
2011-09-07 17:04 ` Geoff Levand
2011-09-07 8:10 ` [PATCH 52/62] rtc: " Yong Zhang
2011-09-11 21:38 ` Linus Walleij
2011-09-11 21:38 ` Linus Walleij
[not found] ` <1315383059-3673-1-git-send-email-yong.zhang0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-09-07 8:10 ` [PATCH 53/62] spi: " Yong Zhang
2011-09-07 17:37 ` Grant Likely
2011-09-07 8:10 ` [PATCH 54/62] TTY: " Yong Zhang
2011-09-09 9:49 ` Tobias Klauser
2011-09-09 9:49 ` Tobias Klauser
2011-09-22 23:04 ` Greg KH
2011-09-22 23:04 ` Greg KH
2011-09-22 23:08 ` Greg KH
2011-09-22 23:08 ` Greg KH
2011-09-07 8:10 ` [PATCH 55/62] USB: " Yong Zhang
2011-09-07 8:10 ` Yong Zhang
2011-09-07 8:10 ` Yong Zhang
2011-09-07 8:10 ` [PATCH 56/62] video: " Yong Zhang
2011-09-07 8:10 ` Yong Zhang
2011-09-07 8:10 ` [PATCH 58/62] watchdog: " Yong Zhang
2011-09-09 8:01 ` Wolfram Sang
2011-09-09 8:01 ` Wolfram Sang
2011-09-11 21:37 ` Linus Walleij
2011-09-11 21:37 ` Linus Walleij
2011-09-07 8:10 ` [PATCH 59/62] xen: " Yong Zhang
2011-09-07 8:10 ` [PATCH 60/62] sound: " Yong Zhang
2011-09-07 8:10 ` Yong Zhang
2011-09-07 8:10 ` Yong Zhang
2011-09-07 8:36 ` Péter Ujfalusi
2011-09-07 8:36 ` Péter Ujfalusi
2011-09-07 8:36 ` Péter Ujfalusi
2011-09-07 17:12 ` Mark Brown
2011-09-07 17:12 ` Mark Brown
2011-09-07 17:12 ` Mark Brown
2011-09-07 17:12 ` Mark Brown
[not found] ` <1315383059-3673-30-git-send-email-yong.zhang0@gmail.com>
2011-09-07 14:26 ` [PATCH 29/62] block: " Miller, Mike (OS Dev)
[not found] ` <1315383059-3673-21-git-send-email-yong.zhang0@gmail.com>
2011-09-07 17:12 ` [PATCH 20/62] sparc: " David Miller
2011-09-07 17:12 ` David Miller
2011-09-07 17:31 ` Thomas Gleixner
2011-09-07 17:31 ` Thomas Gleixner
2011-09-07 17:33 ` Thomas Gleixner
2011-09-07 17:33 ` Thomas Gleixner
2011-09-07 17:51 ` David Miller
2011-09-07 17:51 ` David Miller
2011-09-07 17:57 ` Thomas Gleixner
2011-09-07 17:57 ` Thomas Gleixner
2011-09-07 18:14 ` David Miller
2011-09-07 18:14 ` David Miller
2011-09-07 18:43 ` Thomas Gleixner
2011-09-07 18:43 ` Thomas Gleixner
2011-09-08 3:15 ` Yong Zhang
2011-09-08 3:15 ` Yong Zhang
[not found] ` <1315383059-3673-6-git-send-email-yong.zhang0@gmail.com>
2011-09-07 20:29 ` [PATCH 05/62] avr32: " Hans-Christian Egtvedt
[not found] ` <1315383059-3673-7-git-send-email-yong.zhang0@gmail.com>
2011-09-08 8:12 ` [uclinux-dist-devel] [PATCH 06/62] Blackfin: " Bob Liu
[not found] ` <1315383059-3673-26-git-send-email-yong.zhang0@gmail.com>
2011-09-08 10:40 ` [PATCH 25/62] staging: " Marc Dietich
2011-09-08 13:58 ` Yong Zhang
2011-09-08 14:52 ` Greg KH
2011-09-09 1:12 ` Yong Zhang
[not found] ` <1315383059-3673-3-git-send-email-yong.zhang0@gmail.com>
2011-09-08 10:53 ` [RFC] [PATCH 02/62] mpu401:snd_mpu401_uart_new(): split semantic of irq_flags Clemens Ladisch
2011-09-08 10:53 ` Clemens Ladisch
2011-09-08 13:37 ` Yong Zhang
2011-09-08 13:58 ` Clemens Ladisch
2011-09-08 13:58 ` Clemens Ladisch
2011-09-08 14:45 ` Yong Zhang
2011-09-08 20:27 ` Clemens Ladisch
2011-09-08 20:27 ` Clemens Ladisch
2011-09-09 1:31 ` Yong Zhang
2011-09-11 15:10 ` Clemens Ladisch
2011-09-11 15:10 ` Clemens Ladisch
2011-09-12 10:47 ` Takashi Iwai
2011-09-12 10:47 ` Takashi Iwai
2011-09-12 13:16 ` Clemens Ladisch
2011-09-12 13:16 ` Clemens Ladisch
2011-09-12 20:23 ` Clemens Ladisch
2011-09-12 20:23 ` Clemens Ladisch
2011-09-13 7:12 ` Takashi Iwai
2011-09-13 8:17 ` Clemens Ladisch
2011-09-13 8:17 ` Clemens Ladisch
2011-09-13 9:24 ` Clemens Ladisch
2011-09-14 8:49 ` Yong Zhang
2011-09-14 9:06 ` Takashi Iwai
2011-09-14 9:15 ` Yong Zhang
[not found] ` <1315383059-3673-32-git-send-email-yong.zhang0@gmail.com>
2011-09-08 10:55 ` [PATCH 31/62] driver/char: irq: Remove IRQF_DISABLED Clemens Ladisch
2011-09-08 15:29 ` Corey Minyard
2011-09-08 16:04 ` Arnd Bergmann
[not found] ` <1315383059-3673-62-git-send-email-yong.zhang0@gmail.com>
2011-09-08 21:38 ` [PATCH 61/62] Documentation: irq: Change documents related to IRQF_DISABLED Randy Dunlap
2011-09-09 1:38 ` Yong Zhang
2011-09-09 1:48 ` [UPDATED] " Yong Zhang
2011-09-09 8:25 ` Rolf Eike Beer
2011-09-09 8:41 ` Yong Zhang
[not found] ` <1315383059-3673-48-git-send-email-yong.zhang0@gmail.com>
2011-09-09 8:04 ` [PATCH 47/62] pcmcia: irq: Remove IRQF_DISABLED Wolfram Sang
[not found] ` <1315383059-3673-8-git-send-email-yong.zhang0@gmail.com>
2011-09-09 15:10 ` [PATCH 07/62] cris: " Jesper Nilsson
[not found] ` <1315383059-3673-42-git-send-email-yong.zhang0@gmail.com>
2011-09-15 19:57 ` [PATCH 41/62] mfd: " Samuel Ortiz
2011-09-20 15:03 ` [PATCH 08/62] frv: " David Howells
2011-09-20 15:04 ` [PATCH 15/62] mn10300: " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1109072000290.2723@ionos \
--to=tglx@linutronix.de \
--cc=adobriyan@gmail.com \
--cc=blogic@openwrt.org \
--cc=cbe-oss-dev@lists.ozlabs.org \
--cc=chunkeey@googlemail.com \
--cc=cyril@ti.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=geoff@infradead.org \
--cc=grundler@parisc-linux.org \
--cc=jhovold@gmail.com \
--cc=jkosina@suse.cz \
--cc=jpr@f6fbb.org \
--cc=jreuter@yaina.de \
--cc=khilman@ti.com \
--cc=klaus.kudielka@ieee.org \
--cc=leitao@linux.vnet.ibm.com \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=martinez.javier@gmail.com \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=olof@lixom.net \
--cc=perex@perex.cz \
--cc=prakity@marvell.com \
--cc=ralf@linux-mips.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=samuel@sortiz.org \
--cc=shawn.guo@linaro.org \
--cc=sonic.zhang@analog.com \
--cc=t.sailer@alumni.ethz.ch \
--cc=tklauser@distanz.ch \
--cc=u.kleine-koenig@pengutronix.de \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.