* [PATCH] mmc: dw_mmc: fix wrong SDMMC_GET_FCNT macro
@ 2011-09-26 5:41 Jaehoon Chung
2011-09-26 8:05 ` James Hogan
0 siblings, 1 reply; 3+ messages in thread
From: Jaehoon Chung @ 2011-09-26 5:41 UTC (permalink / raw)
To: linux-mmc; +Cc: Chris Ball, James Hogan, Will Newton, Kyungmin Park
I understood that SDMMC_GET_FCNT is used to get fifo_count.
In status register, fifo_count is bit[17:29].
But this macro is control with bit[17:25].
i think right that change 0x1FFF instead of 0x1FF.
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.Park@samsung.com>
---
drivers/mmc/host/dw_mmc.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
index bfa3c1c..193ec94 100644
--- a/drivers/mmc/host/dw_mmc.h
+++ b/drivers/mmc/host/dw_mmc.h
@@ -117,7 +117,7 @@
#define SDMMC_CMD_RESP_EXP BIT(6)
#define SDMMC_CMD_INDX(n) ((n) & 0x1F)
/* Status register defines */
-#define SDMMC_GET_FCNT(x) (((x)>>17) & 0x1FF)
+#define SDMMC_GET_FCNT(x) (((x)>>17) & 0x1FFF)
/* Internal DMAC interrupt defines */
#define SDMMC_IDMAC_INT_AI BIT(9)
#define SDMMC_IDMAC_INT_NI BIT(8)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: dw_mmc: fix wrong SDMMC_GET_FCNT macro
2011-09-26 5:41 [PATCH] mmc: dw_mmc: fix wrong SDMMC_GET_FCNT macro Jaehoon Chung
@ 2011-09-26 8:05 ` James Hogan
2011-09-26 9:30 ` Will Newton
0 siblings, 1 reply; 3+ messages in thread
From: James Hogan @ 2011-09-26 8:05 UTC (permalink / raw)
To: Jaehoon Chung; +Cc: linux-mmc, Chris Ball, Will Newton, Kyungmin Park
On 09/26/2011 06:41 AM, Jaehoon Chung wrote:
> I understood that SDMMC_GET_FCNT is used to get fifo_count.
> In status register, fifo_count is bit[17:29].
> But this macro is control with bit[17:25].
>
> i think right that change 0x1FFF instead of 0x1FF.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.Park@samsung.com>
nice catch.
Reviewed-by: James Hogan <james.hogan@imgtec.com>
> ---
> drivers/mmc/host/dw_mmc.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
> index bfa3c1c..193ec94 100644
> --- a/drivers/mmc/host/dw_mmc.h
> +++ b/drivers/mmc/host/dw_mmc.h
> @@ -117,7 +117,7 @@
> #define SDMMC_CMD_RESP_EXP BIT(6)
> #define SDMMC_CMD_INDX(n) ((n) & 0x1F)
> /* Status register defines */
> -#define SDMMC_GET_FCNT(x) (((x)>>17) & 0x1FF)
> +#define SDMMC_GET_FCNT(x) (((x)>>17) & 0x1FFF)
> /* Internal DMAC interrupt defines */
> #define SDMMC_IDMAC_INT_AI BIT(9)
> #define SDMMC_IDMAC_INT_NI BIT(8)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: dw_mmc: fix wrong SDMMC_GET_FCNT macro
2011-09-26 8:05 ` James Hogan
@ 2011-09-26 9:30 ` Will Newton
0 siblings, 0 replies; 3+ messages in thread
From: Will Newton @ 2011-09-26 9:30 UTC (permalink / raw)
To: James Hogan
Cc: Jaehoon Chung, linux-mmc, Chris Ball, Will Newton, Kyungmin Park
On Mon, Sep 26, 2011 at 9:05 AM, James Hogan <james.hogan@imgtec.com> wrote:
> On 09/26/2011 06:41 AM, Jaehoon Chung wrote:
>> I understood that SDMMC_GET_FCNT is used to get fifo_count.
>> In status register, fifo_count is bit[17:29].
>> But this macro is control with bit[17:25].
>>
>> i think right that change 0x1FFF instead of 0x1FF.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.Park@samsung.com>
>
> nice catch.
>
> Reviewed-by: James Hogan <james.hogan@imgtec.com>
Yes, looks correct.
Acked-by: Will Newton <will.newton@imgtec.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-26 9:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-26 5:41 [PATCH] mmc: dw_mmc: fix wrong SDMMC_GET_FCNT macro Jaehoon Chung
2011-09-26 8:05 ` James Hogan
2011-09-26 9:30 ` Will Newton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.