From: "Cousson, Benoit" <b-cousson@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"paul@pwsan.com" <paul@pwsan.com>,
"Hilman, Kevin" <khilman@ti.com>,
"Nayak, Rajendra" <rnayak@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Subject: Re: [PATCH 10/11] arm/dts: OMAP4: Add a main ocp entry bound to l3-noc driver
Date: Mon, 26 Sep 2011 14:13:04 +0200 [thread overview]
Message-ID: <4E806C50.80300@ti.com> (raw)
In-Reply-To: <20110923225825.GB6324@atomide.com>
On 9/24/2011 12:58 AM, Tony Lindgren wrote:
> * Benoit Cousson<b-cousson@ti.com> [110923 12:50]:
>> Used the main OCP node to add bindings with the l3_noc driver.
>> Remove l3_noc static device creation if DT is populated.
>> --- a/arch/arm/mach-omap2/devices.c
>> +++ b/arch/arm/mach-omap2/devices.c
>> @@ -16,6 +16,7 @@
>> #include<linux/clk.h>
>> #include<linux/err.h>
>> #include<linux/slab.h>
>> +#include<linux/of.h>
>>
>> #include<mach/hardware.h>
>> #include<mach/irqs.h>
>> @@ -77,6 +78,10 @@ static int __init omap4_l3_init(void)
>> struct platform_device *pdev;
>> char oh_name[L3_MODULES_MAX_LEN];
>>
>> + /* If dtb is there, the devices will be created dynamically */
>> + if (of_have_populated_dt())
>> + return -ENODEV;
>> +
>> /*
>> * To avoid code running on other OMAPs in
>> * multi-omap builds
>
> How about just remove omap3_l3_init and omap4_l3_init completely
> instead?
>
> There should not be any need for the platform glue code if the
> driver, it's OK for us to require that either DT is passed from
> the bootloader or as appended DT as soon as the appended DT patches
> are merged.
Yeah, but we should still allow the others board files to work in case
DT is not passed by the bootloader. Otherwise the DT support need to be
added to every other boards, and in that case that generic board become
useless. The effort / duplication will be much important if we start
hacking every boards with some DT code in them.
Whereas that code is simple and will be removed easily when the DT
migration will be completed.
Regards,
Benoit
WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Cousson, Benoit)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/11] arm/dts: OMAP4: Add a main ocp entry bound to l3-noc driver
Date: Mon, 26 Sep 2011 14:13:04 +0200 [thread overview]
Message-ID: <4E806C50.80300@ti.com> (raw)
In-Reply-To: <20110923225825.GB6324@atomide.com>
On 9/24/2011 12:58 AM, Tony Lindgren wrote:
> * Benoit Cousson<b-cousson@ti.com> [110923 12:50]:
>> Used the main OCP node to add bindings with the l3_noc driver.
>> Remove l3_noc static device creation if DT is populated.
>> --- a/arch/arm/mach-omap2/devices.c
>> +++ b/arch/arm/mach-omap2/devices.c
>> @@ -16,6 +16,7 @@
>> #include<linux/clk.h>
>> #include<linux/err.h>
>> #include<linux/slab.h>
>> +#include<linux/of.h>
>>
>> #include<mach/hardware.h>
>> #include<mach/irqs.h>
>> @@ -77,6 +78,10 @@ static int __init omap4_l3_init(void)
>> struct platform_device *pdev;
>> char oh_name[L3_MODULES_MAX_LEN];
>>
>> + /* If dtb is there, the devices will be created dynamically */
>> + if (of_have_populated_dt())
>> + return -ENODEV;
>> +
>> /*
>> * To avoid code running on other OMAPs in
>> * multi-omap builds
>
> How about just remove omap3_l3_init and omap4_l3_init completely
> instead?
>
> There should not be any need for the platform glue code if the
> driver, it's OK for us to require that either DT is passed from
> the bootloader or as appended DT as soon as the appended DT patches
> are merged.
Yeah, but we should still allow the others board files to work in case
DT is not passed by the bootloader. Otherwise the DT support need to be
added to every other boards, and in that case that generic board become
useless. The effort / duplication will be much important if we start
hacking every boards with some DT code in them.
Whereas that code is simple and will be removed easily when the DT
migration will be completed.
Regards,
Benoit
next prev parent reply other threads:[~2011-09-26 12:13 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 20:23 [PATCH 00/11] OMAP: Add initial support for DT on OMAP3 & OMAP4 Benoit Cousson
2011-09-23 20:23 ` Benoit Cousson
2011-09-23 20:23 ` [PATCH 01/11] OMAP2+: Add SoC specific map_io functions Benoit Cousson
2011-09-23 20:23 ` Benoit Cousson
2011-09-23 23:00 ` Tony Lindgren
2011-09-23 23:00 ` Tony Lindgren
2011-09-26 23:15 ` Tony Lindgren
2011-09-26 23:15 ` Tony Lindgren
2011-09-26 23:16 ` [PATCH] ARM: OMAP2+: Use SoC specifc map_io Tony Lindgren
2011-09-26 23:16 ` Tony Lindgren
2011-09-26 23:18 ` [PATCH] ARM: OMAP2+: Remove custom init_irq for remaining boards Tony Lindgren
2011-09-26 23:18 ` Tony Lindgren
2012-05-04 15:59 ` [PATCH 01/11] OMAP2+: Add SoC specific map_io functions Thomas Petazzoni
2012-05-04 15:59 ` Thomas Petazzoni
2012-05-14 15:06 ` Cousson, Benoit
2012-05-14 15:06 ` Cousson, Benoit
2012-05-14 19:55 ` Nicolas Pitre
2012-05-14 19:55 ` Nicolas Pitre
2011-09-23 20:23 ` [PATCH 02/11] arm/dts: Add initial device tree support for OMAP4 SoC Benoit Cousson
2011-09-23 20:23 ` Benoit Cousson
2011-09-23 20:23 ` [PATCH 03/11] arm/dts: Add support for OMAP4 PandaBoard Benoit Cousson
2011-09-23 20:23 ` Benoit Cousson
2011-09-23 23:21 ` Grant Likely
2011-09-23 23:21 ` Grant Likely
2011-09-26 12:38 ` Cousson, Benoit
2011-09-26 12:38 ` Cousson, Benoit
2011-09-23 20:23 ` [PATCH 04/11] arm/dts: Add support for OMAP4 SDP board Benoit Cousson
2011-09-23 20:23 ` Benoit Cousson
2011-09-23 20:23 ` [PATCH 05/11] arm/dts: Add initial device tree support for OMAP3 SoC Benoit Cousson
2011-09-23 20:23 ` Benoit Cousson
2011-09-23 20:23 ` [PATCH 06/11] arm/dts: Add support for OMAP3 Beagle board Benoit Cousson
2011-09-23 20:23 ` Benoit Cousson
2011-09-23 20:23 ` [PATCH 07/11] OMAP2+: board-generic: Add DT support to generic board Benoit Cousson
2011-09-23 20:23 ` Benoit Cousson
2011-09-23 23:08 ` Tony Lindgren
2011-09-23 23:08 ` Tony Lindgren
2011-09-26 12:35 ` Cousson, Benoit
2011-09-26 12:35 ` Cousson, Benoit
2011-09-26 21:37 ` Tony Lindgren
2011-09-26 21:37 ` Tony Lindgren
2011-09-26 6:32 ` Rajendra Nayak
2011-09-26 6:32 ` Rajendra Nayak
[not found] ` <4E801C62.5020700-l0cyMroinI0@public.gmane.org>
2011-09-26 9:00 ` Cousson, Benoit
2011-09-26 9:00 ` Cousson, Benoit
2011-09-23 20:23 ` [PATCH 08/11] OMAP2+: board-generic: Add i2c static init Benoit Cousson
2011-09-23 20:23 ` Benoit Cousson
2011-09-23 23:12 ` Tony Lindgren
2011-09-23 23:12 ` Tony Lindgren
2011-09-23 23:47 ` Grant Likely
2011-09-23 23:47 ` Grant Likely
2011-09-26 16:45 ` Tony Lindgren
2011-09-26 16:45 ` Tony Lindgren
2011-09-23 20:23 ` [PATCH 09/11] OMAP2+: l3-noc: Add support for device-tree Benoit Cousson
2011-09-23 20:23 ` Benoit Cousson
2011-09-23 20:23 ` [PATCH 10/11] arm/dts: OMAP4: Add a main ocp entry bound to l3-noc driver Benoit Cousson
2011-09-23 20:23 ` Benoit Cousson
2011-09-23 22:58 ` Tony Lindgren
2011-09-23 22:58 ` Tony Lindgren
2011-09-26 12:13 ` Cousson, Benoit [this message]
2011-09-26 12:13 ` Cousson, Benoit
2011-09-26 21:44 ` Tony Lindgren
2011-09-26 21:44 ` Tony Lindgren
2011-09-23 20:23 ` [PATCH 11/11] arm/dts: OMAP3+: Add mpu, dsp and iva nodes Benoit Cousson
2011-09-23 20:23 ` Benoit Cousson
2011-09-23 23:26 ` Grant Likely
2011-09-23 23:26 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E806C50.80300@ti.com \
--to=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.