Re: [PATCH] Don't build Intel DRM if $CHOST is not i?86-* or x86_64-*

[Alan Coopersmith <alan.coopersmith@oracle.com>]

On 02/ 1/12 01:56 PM, Julien Cristau wrote:
> On Wed, Feb  1, 2012 at 13:01:58 -0800, Jeremy Huddleston wrote:
>
>> yeah, that's probably cleaner (I guess it'll avoid the -*), but it should have the same effect.
>>
> I get host_os=linux-gnu here afaict, so not really the same effect, no.

Jeremy was probably thinking of $host, which has both the os & cpu in,
but this was already fixed in libdrm git last night when people on IRC
noticed that the Intel drm module stopped building on x86 systems.

commit 82c6938d232327233caac743a07639ac91bceb7e
Author: Paul Berry <stereotype441@gmail.com>
Date:   Tue Jan 31 14:44:14 2012 -0800

     intel: Fix build of Intel DRM on x86 systems

     Commit efd6e81e inadvertently broke the build by looking for "i?86" or
     "x86_64" in $host_os.  The correct variable to check is $host_cpu.

     This was preventing libdrm_intel.so from being built.

     Reviewed-by: Chad Versace <chad.versace@linux.intel.com>

diff --git a/configure.ac b/configure.ac
index f5ebc1d..b59bc54 100644
--- a/configure.ac
+++ b/configure.ac
@@ -250,8 +250,8 @@ if test "x$INTEL" != "xno" -o "x$RADEON" != "xno"; then

      else
             if test "x$INTEL" != "xno"; then
-                   case $host_os in
-                           i?86-*|x86_64-*) INTEL=yes ;;
+                   case $host_cpu in
+                           i?86|x86_64) INTEL=yes ;;
                             *) INTEL=no ;;
                     esac
             fi


-- 
	-Alan Coopersmith-        alan.coopersmith@oracle.com
	 Oracle Solaris Platform Engineering: X Window System