All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Huddleston <jeremyhu@freedesktop.org>
To: Julien Cristau <jcristau@debian.org>
Cc: dri-devel@lists.freedesktop.org, daniel.vetter@ffwll.ch
Subject: Re: [PATCH] Don't build Intel DRM if $CHOST is not i?86-* or x86_64-*
Date: Wed, 01 Feb 2012 13:01:58 -0800	[thread overview]
Message-ID: <59101C6A-2C7E-47D0-BE89-0FAC63240533@freedesktop.org> (raw)
In-Reply-To: <20120201204316.GN19118@radis.cristau.org>

yeah, that's probably cleaner (I guess it'll avoid the -*), but it should have the same effect.

I'll make the change.

On Feb 1, 2012, at 12:43 PM, Julien Cristau wrote:

> On Mon, Jan 30, 2012 at 15:25:20 -0800, Jeremy Huddleston wrote:
> 
>> This fixes a failure in 'make check' found by the tinderbox when trying to
>> build this code on Linux/ppc.  This code is only designed to run on
>> Intel platforms, so don't even bother building it if we're not in that set.
>> 
>> Found-by: Tinderbox
>> Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
>> ---
>> 
>> It now causes the intel bits to not build on my Linux/ppc tinderbox, but I'd
>> appreciate someone verifying that it does the right thing on intel boxes as
>> well.
>> 
>> configure.ac |    5 ++++-
>> 1 files changed, 4 insertions(+), 1 deletions(-)
>> 
>> diff --git a/configure.ac b/configure.ac
>> index 773167f..f5ebc1d 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -250,7 +250,10 @@ if test "x$INTEL" != "xno" -o "x$RADEON" != "xno"; then
>> 
>>     else
>>            if test "x$INTEL" != "xno"; then
>> -                   INTEL=yes
>> +                   case $host_os in
>> +                           i?86-*|x86_64-*) INTEL=yes ;;
>> +                           *) INTEL=no ;;
>> +                   esac
>>            fi
> 
> don't you want to check host_cpu rather than host_os?
> 
> Cheers,
> Julien
> 

  reply	other threads:[~2012-02-01 21:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-06 16:54 libdrm 2.4.30 Eric Anholt
2012-01-07 19:22 ` [ANNOUNCE] " Jeremy Huddleston
2012-01-08  2:49   ` Eric Anholt
2012-01-08  8:48     ` Jeremy Huddleston
2012-01-09 16:15       ` Eric Anholt
2012-01-28 20:57   ` libdrm fails 'make check' in tinderbox (was Re: [ANNOUNCE] libdrm 2.4.30) Jeremy Huddleston
2012-01-29  1:55     ` Eric Anholt
2012-01-29  3:30       ` Jeremy Huddleston
2012-01-29 12:16         ` Daniel Vetter
2012-01-29 17:58           ` Jeremy Huddleston
2012-01-30 16:26         ` Eric Anholt
2012-01-30 23:25           ` [PATCH] Don't build Intel DRM if $CHOST is not i?86-* or x86_64-* Jeremy Huddleston
2012-01-31 16:59             ` Eric Anholt
2012-01-31 18:34               ` Jeremy Huddleston
2012-01-31 21:12                 ` Eric Anholt
2012-02-01 20:43             ` Julien Cristau
2012-02-01 21:01               ` Jeremy Huddleston [this message]
2012-02-01 21:56                 ` Julien Cristau
2012-02-01 21:59                   ` Jeremy Huddleston
2012-02-01 22:04                   ` Alan Coopersmith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59101C6A-2C7E-47D0-BE89-0FAC63240533@freedesktop.org \
    --to=jeremyhu@freedesktop.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jcristau@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.