All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Huddleston <jeremyhu@freedesktop.org>
To: Eric Anholt <eric@anholt.net>
Cc: daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] Don't build Intel DRM if $CHOST is not i?86-* or x86_64-*
Date: Tue, 31 Jan 2012 10:34:38 -0800	[thread overview]
Message-ID: <EDDCDB46-B75D-4A8A-ACC3-4561A71A04B0@freedesktop.org> (raw)
In-Reply-To: <8739avu7tz.fsf@eliezer.anholt.net>


On Jan 31, 2012, at 8:59 AM, Eric Anholt wrote:

> On Mon, 30 Jan 2012 15:25:20 -0800, Jeremy Huddleston <jeremyhu@freedesktop.org> wrote:
>> This fixes a failure in 'make check' found by the tinderbox when trying to
>> build this code on Linux/ppc.  This code is only designed to run on
>> Intel platforms, so don't even bother building it if we're not in that set.
> 
> Looks reasonable to me, except it should probably be checking $target_os
> (cross-compile target) rather than $host_os (cross compile build host).

I think you are misunderstanding the variables (or perhaps you are following Mozilla's usage of the variables, which is wrong but internally consistent).

CBUILD - The platform of the machine being built on.
CHOST  - The platform that the delivered product will run on.
CTARGET- The platform that the delivered product will generate code for.

CTARGET is only really relevant for toolchain packages.

eg.  I want to build a gcc that builds mips code and runs on my intel box:
CTARGET=mips-*
CHOST=i686-*

If I want to do the building of that compiler on my ppc box:
CBUILD=powerpc-*
CTARGET=mips-*
CHOST=i686-*

--Jeremy

  reply	other threads:[~2012-01-31 18:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-06 16:54 libdrm 2.4.30 Eric Anholt
2012-01-07 19:22 ` [ANNOUNCE] " Jeremy Huddleston
2012-01-08  2:49   ` Eric Anholt
2012-01-08  8:48     ` Jeremy Huddleston
2012-01-09 16:15       ` Eric Anholt
2012-01-28 20:57   ` libdrm fails 'make check' in tinderbox (was Re: [ANNOUNCE] libdrm 2.4.30) Jeremy Huddleston
2012-01-29  1:55     ` Eric Anholt
2012-01-29  3:30       ` Jeremy Huddleston
2012-01-29 12:16         ` Daniel Vetter
2012-01-29 17:58           ` Jeremy Huddleston
2012-01-30 16:26         ` Eric Anholt
2012-01-30 23:25           ` [PATCH] Don't build Intel DRM if $CHOST is not i?86-* or x86_64-* Jeremy Huddleston
2012-01-31 16:59             ` Eric Anholt
2012-01-31 18:34               ` Jeremy Huddleston [this message]
2012-01-31 21:12                 ` Eric Anholt
2012-02-01 20:43             ` Julien Cristau
2012-02-01 21:01               ` Jeremy Huddleston
2012-02-01 21:56                 ` Julien Cristau
2012-02-01 21:59                   ` Jeremy Huddleston
2012-02-01 22:04                   ` Alan Coopersmith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EDDCDB46-B75D-4A8A-ACC3-4561A71A04B0@freedesktop.org \
    --to=jeremyhu@freedesktop.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.