* [PATCH 1/5] Split xcb-util into separate packages.
@ 2012-03-10 15:49 Marko Katić
2012-03-12 21:06 ` Saul Wold
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Marko Katić @ 2012-03-10 15:49 UTC (permalink / raw)
To: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]
xcb-util was split into separate packages during the 0.3.6 -> 0.3.8
transition.
Change xcb-util.inc to reflect that.
diff --git a/meta/recipes-graphics/xcb/xcb-util.inc
b/meta/recipes-graphics/xcb/xcb-util.inc
index cd9923d..5e77a22 100644
--- a/meta/recipes-graphics/xcb/xcb-util.inc
+++ b/meta/recipes-graphics/xcb/xcb-util.inc
@@ -18,20 +18,6 @@ DEPENDS += "gperf-native"
PARALLEL_MAKE = ""
-SRC_URI = "http://xcb.freedesktop.org/dist/xcb-util-${PV}.tar.bz2"
-
-PACKAGES =+ "libxcbatom libxcbaux libxcbevent libxcbicccm \
- libxcbimage libxcbkeysyms libxcbproperty \
- libxcbreply libxcbwm"
-
-FILES_libxcbatom = "${libdir}/libXCBAtom.so.*"
-FILES_libxcbaux = "${libdir}/libXCBAux.so.*"
-FILES_libxcbevent = "${libdir}/libXCBEvent.so.*"
-FILES_libxcbicccm = "${libdir}/libXCBICCCM.so.*"
-FILES_libxcbimage = "${libdir}/libXCBImage.so.*"
-FILES_libxcbkeysyms = "${libdir}/libXCBKeysyms.so.*"
-FILES_libxcbproperty = "${libdir}/libXCBProperty.so.*"
-FILES_libxcbreply = "${libdir}/libXCBReply.so.*"
-FILES_libxcbwm = "${libdir}/libXCBWM.so.*"
+SRC_URI = "http://xcb.freedesktop.org/dist/${PN}-${PV}.tar.bz2"
inherit autotools pkgconfig
[-- Attachment #2: Type: text/html, Size: 1799 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/5] Split xcb-util into separate packages.
2012-03-10 15:49 [PATCH 1/5] Split xcb-util into separate packages Marko Katić
@ 2012-03-12 21:06 ` Saul Wold
2012-03-13 0:18 ` Saul Wold
2012-03-13 18:51 ` Yury Bushmelev
2 siblings, 0 replies; 4+ messages in thread
From: Saul Wold @ 2012-03-12 21:06 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 03/10/2012 07:49 AM, Marko Katić wrote:
> xcb-util was split into separate packages during the 0.3.6 -> 0.3.8
> transition.
> Change xcb-util.inc to reflect that.
>
This patch series looks OK, but the comment need refining.
First it's best to have correctly Subjects that list the file or recipe
area being addressed and then what's the summary
For example in this case:
xcb-util: Remove packaging and modify SRC_URI for multiple ${PN} names
xcb-util was split into separate packages during the 0.3.6 -> 0.3.8
transition, so update the .inc file to reflect that by removing the
older packaging.
The reset of this series needs similar updates to commit messages.
Also, if possible can you use a git repo (request an oe-core or poky
branch).
>
>
> diff --git a/meta/recipes-graphics/xcb/xcb-util.inc
> b/meta/recipes-graphics/xcb/xcb-util.inc
> index cd9923d..5e77a22 100644
> --- a/meta/recipes-graphics/xcb/xcb-util.inc
> +++ b/meta/recipes-graphics/xcb/xcb-util.inc
> @@ -18,20 +18,6 @@ DEPENDS += "gperf-native"
> PARALLEL_MAKE = ""
> -SRC_URI = "http://xcb.freedesktop.org/dist/xcb-util-${PV}.tar.bz2"
> -
> -PACKAGES =+ "libxcbatom libxcbaux libxcbevent libxcbicccm \
> - libxcbimage libxcbkeysyms libxcbproperty \
> - libxcbreply libxcbwm"
> -
> -FILES_libxcbatom = "${libdir}/libXCBAtom.so.*"
> -FILES_libxcbaux = "${libdir}/libXCBAux.so.*"
> -FILES_libxcbevent = "${libdir}/libXCBEvent.so.*"
> -FILES_libxcbicccm = "${libdir}/libXCBICCCM.so.*"
> -FILES_libxcbimage = "${libdir}/libXCBImage.so.*"
> -FILES_libxcbkeysyms = "${libdir}/libXCBKeysyms.so.*"
> -FILES_libxcbproperty = "${libdir}/libXCBProperty.so.*"
> -FILES_libxcbreply = "${libdir}/libXCBReply.so.*"
> -FILES_libxcbwm = "${libdir}/libXCBWM.so.*"
> +SRC_URI = "http://xcb.freedesktop.org/dist/${PN}-${PV}.tar.bz2"
> inherit autotools pkgconfig
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/5] Split xcb-util into separate packages.
2012-03-10 15:49 [PATCH 1/5] Split xcb-util into separate packages Marko Katić
2012-03-12 21:06 ` Saul Wold
@ 2012-03-13 0:18 ` Saul Wold
2012-03-13 18:51 ` Yury Bushmelev
2 siblings, 0 replies; 4+ messages in thread
From: Saul Wold @ 2012-03-13 0:18 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 03/10/2012 07:49 AM, Marko Katić wrote:
> xcb-util was split into separate packages during the 0.3.6 -> 0.3.8
> transition.
> Change xcb-util.inc to reflect that.
>
>
>
> diff --git a/meta/recipes-graphics/xcb/xcb-util.inc
> b/meta/recipes-graphics/xcb/xcb-util.inc
> index cd9923d..5e77a22 100644
> --- a/meta/recipes-graphics/xcb/xcb-util.inc
> +++ b/meta/recipes-graphics/xcb/xcb-util.inc
> @@ -18,20 +18,6 @@ DEPENDS += "gperf-native"
> PARALLEL_MAKE = ""
> -SRC_URI = "http://xcb.freedesktop.org/dist/xcb-util-${PV}.tar.bz2"
> -
> -PACKAGES =+ "libxcbatom libxcbaux libxcbevent libxcbicccm \
> - libxcbimage libxcbkeysyms libxcbproperty \
> - libxcbreply libxcbwm"
> -
> -FILES_libxcbatom = "${libdir}/libXCBAtom.so.*"
> -FILES_libxcbaux = "${libdir}/libXCBAux.so.*"
> -FILES_libxcbevent = "${libdir}/libXCBEvent.so.*"
> -FILES_libxcbicccm = "${libdir}/libXCBICCCM.so.*"
> -FILES_libxcbimage = "${libdir}/libXCBImage.so.*"
> -FILES_libxcbkeysyms = "${libdir}/libXCBKeysyms.so.*"
> -FILES_libxcbproperty = "${libdir}/libXCBProperty.so.*"
> -FILES_libxcbreply = "${libdir}/libXCBReply.so.*"
> -FILES_libxcbwm = "${libdir}/libXCBWM.so.*"
> +SRC_URI = "http://xcb.freedesktop.org/dist/${PN}-${PV}.tar.bz2"
> inherit autotools pkgconfig
>
This should be ${BPN} instead of ${PN}.
Also, your email came as HTML and that messed up the git am.
Sau!
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/5] Split xcb-util into separate packages.
2012-03-10 15:49 [PATCH 1/5] Split xcb-util into separate packages Marko Katić
2012-03-12 21:06 ` Saul Wold
2012-03-13 0:18 ` Saul Wold
@ 2012-03-13 18:51 ` Yury Bushmelev
2 siblings, 0 replies; 4+ messages in thread
From: Yury Bushmelev @ 2012-03-13 18:51 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
2012/3/10 Marko Katić <dromede@gmail.com>:
> xcb-util was split into separate packages during the 0.3.6 -> 0.3.8
> transition.
> Change xcb-util.inc to reflect that.
>
>
>
> diff --git a/meta/recipes-graphics/xcb/xcb-util.inc
> b/meta/recipes-graphics/xcb/xcb-util.inc
> index cd9923d..5e77a22 100644
> --- a/meta/recipes-graphics/xcb/xcb-util.inc
> +++ b/meta/recipes-graphics/xcb/xcb-util.inc
> @@ -18,20 +18,6 @@ DEPENDS += "gperf-native"
>
> PARALLEL_MAKE = ""
BTW, I haven't seen any trouble with PARALLEL_MAKE and
xcb-util_0.3.8.bb. So we may try to remove this line.
>
> -SRC_URI = "http://xcb.freedesktop.org/dist/xcb-util-${PV}.tar.bz2"
> -
> -PACKAGES =+ "libxcbatom libxcbaux libxcbevent libxcbicccm \
> - libxcbimage libxcbkeysyms libxcbproperty \
> - libxcbreply libxcbwm"
> -
> -FILES_libxcbatom = "${libdir}/libXCBAtom.so.*"
> -FILES_libxcbaux = "${libdir}/libXCBAux.so.*"
> -FILES_libxcbevent = "${libdir}/libXCBEvent.so.*"
> -FILES_libxcbicccm = "${libdir}/libXCBICCCM.so.*"
> -FILES_libxcbimage = "${libdir}/libXCBImage.so.*"
> -FILES_libxcbkeysyms = "${libdir}/libXCBKeysyms.so.*"
> -FILES_libxcbproperty = "${libdir}/libXCBProperty.so.*"
> -FILES_libxcbreply = "${libdir}/libXCBReply.so.*"
> -FILES_libxcbwm = "${libdir}/libXCBWM.so.*"
> +SRC_URI = "http://xcb.freedesktop.org/dist/${PN}-${PV}.tar.bz2"
>
> inherit autotools pkgconfig
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
--
Yury Bushmelev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-13 19:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-10 15:49 [PATCH 1/5] Split xcb-util into separate packages Marko Katić
2012-03-12 21:06 ` Saul Wold
2012-03-13 0:18 ` Saul Wold
2012-03-13 18:51 ` Yury Bushmelev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.