Re: [PATCH 3/3] powerpc: define TUNE_PKGARCH for powerpc/powerpc-nf

[Mark Hatle <mark.hatle@windriver.com>]

On 3/27/12 4:05 PM, Chris Larson wrote:
> On Tue, Mar 27, 2012 at 1:22 PM, Mark Hatle<mark.hatle@windriver.com>  wrote:
>> Patch 1 and 2 look fine, but I have questions on this one....
>>
>>
>> On 3/27/12 2:51 PM, Christopher Larson wrote:
>>>
>>> From: Christopher Larson<chris_larson@mentor.com>
>>>
>>> This allows setting DEFAULTTUNE to powerpc or powerpc-nf rather than just
>>> the
>>> more specific cpu/machine tuning.
>>>
>>> Signed-off-by: Christopher Larson<chris_larson@mentor.com>
>>> ---
>>>   meta/conf/machine/include/powerpc/arch-powerpc.inc |    2 ++
>>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/meta/conf/machine/include/powerpc/arch-powerpc.inc
>>> b/meta/conf/machine/include/powerpc/arch-powerpc.inc
>>> index c5fd6b7..3438b46 100644
>>> --- a/meta/conf/machine/include/powerpc/arch-powerpc.inc
>>> +++ b/meta/conf/machine/include/powerpc/arch-powerpc.inc
>>> @@ -26,6 +26,8 @@ AVAILTUNES += "powerpc powerpc-nf"
>>>   TUNE_FEATURES_tune-powerpc-nf ?= "m32 fpu-soft"
>>>   BASE_LIB_tune-powerpc-nf = "lib"
>>>   PACKAGE_EXTRA_ARCHS_tune-powerpc-nf = "powerpc-nf"
>>> +TUNE_PKGARCH_tune-powerpc-nf = "powerpc-nf"
>>>   TUNE_FEATURES_tune-powerpc ?= "m32 fpu-hard"
>>>   BASE_LIB_tune-powerpc = "lib"
>>>   PACKAGE_EXTRA_ARCHS_tune-powerpc = "powerpc"
>>> +TUNE_PKGARCH_tune-powerpc = "powerpc"
>>
>>
>> Why is the above necessary?
>>
>> TUNE_PKGARCH_append is set to "${PPCPKGSFX_FPU}"
>>
>> PPCPKGSFX_FP is set to either '' or '-nf' based on the existance of
>> fpu-soft.
>>
>> TUNE_PKGARCH is set by a number of the PowerPC tuning files...  If you are
>> looking for generic PowerPC there should be something setting TUNE_PKGARCH
>> to "powerpc" (or "powerpc64" in the default cases...)
>
> This is what I'm saying. If you want to target generic powerpc, you
> have to force TUNE_PKGARCH, as the generic don't have
> TUNE_PKGARCH_tune- definitions. It seems to me in most cases you can
> set DEFAULTTUNE and include an appropriate tune file and not need to
> set TUNE_PKGARCH directly, which is not the case for the generic ones.
> Was it not the intent that this was the case? Should every MACHINE
> have to override TUNE_PKGARCH?

On PowerPC TUNE_PKGARCH should be set to powerpc (or overriden by the machines). 
  On PowerPC64, it should be set to powerpc64.  If this is not happening that is 
the bug, lack of the default TUNE_PKGARCH.  (based on the original implementation.)

It was intended that having to have multiple TUNE_PKGARCH one for powerpc and 
one for powerpc-nf was not the intention.

I'm open to changing it, but I took a lot of "feedback" over the initial 
implementation and that is what ended up in it.

--Mark