All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Larson <kergoth@gmail.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 3/3] powerpc: define TUNE_PKGARCH for powerpc/powerpc-nf
Date: Tue, 27 Mar 2012 14:57:44 -0700	[thread overview]
Message-ID: <F4FE715B8B374104BDAF129362EBDD00@gmail.com> (raw)
In-Reply-To: <4F723618.6060104@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]

On Tuesday, March 27, 2012 at 2:50 PM, Mark Hatle wrote:
> On 3/27/12 4:05 PM, Chris Larson wrote:
> 
> 
> 
> 
> On PowerPC TUNE_PKGARCH should be set to powerpc (or overriden by the machines).
> On PowerPC64, it should be set to powerpc64. If this is not happening that is
> the bug, lack of the default TUNE_PKGARCH. (based on the original implementation.)


I don't think your point of view is covering all the issues. 

The default TUNE_PKGARCH is TUNE_PKGARCH_${TUNE_PKGARCH_tune-${DEFAULTTUNE}. If arch-powerpc.inc sets TUNE_PKGARCH directly, as it used to, then all the more specific tunings won't have their TUNE_PKGARCH_tune-<tune> obeyed, which was the behavior prior to my submitting a patch which removed the explicit TUNE_PKGARCH override in arch-powerpc.inc.

So we have two options. Either we override TUNE_PKGARCH directly in arch-powerpc.inc again, thereby making powerpc tune- files like tune-ppce500v2 not have their TUNE_PKGARCH_tune-<tune> obeyed (or those tune- files have to override TUNE_PKGARCH as well, which seems counter to the whole design of the tuning implementation), or we add TUNE_PKGARCH_tune-<tune> definitions for the generic tunings also.

-Chris

[-- Attachment #2: Type: text/html, Size: 2892 bytes --]

  reply	other threads:[~2012-03-27 22:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27 19:51 [PATCH 1/3] external-csl: add mapping for powerpc-nf Christopher Larson
2012-03-27 19:51 ` [PATCH 2/3] powerpc e500: set -mfloat-gprs=double Christopher Larson
2012-04-07  5:40   ` Khem Raj
2012-04-07 16:12     ` Chris Larson
2012-03-27 19:51 ` [PATCH 3/3] powerpc: define TUNE_PKGARCH for powerpc/powerpc-nf Christopher Larson
2012-03-27 20:22   ` Mark Hatle
2012-03-27 21:05     ` Chris Larson
2012-03-27 21:50       ` Mark Hatle
2012-03-27 21:57         ` Christopher Larson [this message]
2012-03-27 22:13           ` Mark Hatle
2012-03-27 22:16             ` Chris Larson
2012-03-29  4:47               ` McClintock Matthew-B29882
2012-03-29  4:54                 ` Chris Larson
2012-03-29  5:07                   ` McClintock Matthew-B29882
2012-03-29 15:38                   ` Mark Hatle
2012-03-29 15:54                     ` Chris Larson
2012-03-29 15:58                     ` McClintock Matthew-B29882
2012-03-29 16:40                       ` Mark Hatle
2012-03-29 18:38                         ` Chris Larson
2012-03-29 18:50                           ` McClintock Matthew-B29882

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F4FE715B8B374104BDAF129362EBDD00@gmail.com \
    --to=kergoth@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.