All of lore.kernel.org
 help / color / mirror / Atom feed
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Greg KH <greg@kroah.com>
Cc: Paul Walmsley <paul@pwsan.com>, Aneesh V <aneesh@ti.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	mgreer@animalcreek.com, msalter@redhat.com
Subject: Re: [PATCH v4 0/7] Add TI EMIF SDRAM controller driver
Date: Thu, 12 Apr 2012 12:17:49 +0530	[thread overview]
Message-ID: <4F867A95.9030104@ti.com> (raw)
In-Reply-To: <20120412030044.GA26236@kroah.com>

On Thursday 12 April 2012 08:30 AM, Greg KH wrote:
> On Wed, Apr 11, 2012 at 08:44:39PM -0600, Paul Walmsley wrote:
>> Cc Mark Greer, Mark Salter
>>
>> Hi Greg, Aneesh,
>>
>> On Sat, 17 Mar 2012, Aneesh V wrote:
>>
>>> Add a driver for the EMIF SDRAM controller used in TI SoCs
>>>
>>> EMIF is an SDRAM controller that supports, based on its revision,
>>> one or more of LPDDR2/DDR2/DDR3 protocols.This driver adds support
>>> for LPDDR2.
>>
>> Just checking to see what the current state of this series is.  Greg, are 
>> you considering this for merging, or are there remaining issues?  Aneesh, 
>> do you have any remaining issues to resolve with this set?
> 
> What about the review comment about devfreq?
>
Devfreq is not suitable for this driver. I already replied on this
thread [1]

Acting on frequency change is just one function of the controller
driver and that too need not bed to attached with devfreq. The driver
has features like temperature handling as per JDEC specs, active power
managements modes, system wide suspend power management like self
refresh and also configuration which can help memory hotplug for
power savings and initialising the DDR timings to avoid boot-loader
defaults.The controller IP works in conjunction with PRCM (OMAP Power
IP) block to achieve some of this functionality.

I was hoping that we will have some thing like drivers/memory/*
but since it doesn't exist, we used drivers/misc.

Regards
Santosh
[1] https://lkml.org/lkml/2012/3/19/178

>> This is useful not only for OMAP4 and AM3517/3505, but also will probably 
>> be useful for the C6x chips that Mark Salter is working on.
> 
> It's still in my "to-review" queue, that I'm slowly making my way
> through.  So it's not lost, but I would like to get the devfreq
> interface question cleared up first.
> 
Let us know if you need more clarification on devfreq part.
Thanks for looking into it.

Regards
Santosh

WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 0/7] Add TI EMIF SDRAM controller driver
Date: Thu, 12 Apr 2012 12:17:49 +0530	[thread overview]
Message-ID: <4F867A95.9030104@ti.com> (raw)
In-Reply-To: <20120412030044.GA26236@kroah.com>

On Thursday 12 April 2012 08:30 AM, Greg KH wrote:
> On Wed, Apr 11, 2012 at 08:44:39PM -0600, Paul Walmsley wrote:
>> Cc Mark Greer, Mark Salter
>>
>> Hi Greg, Aneesh,
>>
>> On Sat, 17 Mar 2012, Aneesh V wrote:
>>
>>> Add a driver for the EMIF SDRAM controller used in TI SoCs
>>>
>>> EMIF is an SDRAM controller that supports, based on its revision,
>>> one or more of LPDDR2/DDR2/DDR3 protocols.This driver adds support
>>> for LPDDR2.
>>
>> Just checking to see what the current state of this series is.  Greg, are 
>> you considering this for merging, or are there remaining issues?  Aneesh, 
>> do you have any remaining issues to resolve with this set?
> 
> What about the review comment about devfreq?
>
Devfreq is not suitable for this driver. I already replied on this
thread [1]

Acting on frequency change is just one function of the controller
driver and that too need not bed to attached with devfreq. The driver
has features like temperature handling as per JDEC specs, active power
managements modes, system wide suspend power management like self
refresh and also configuration which can help memory hotplug for
power savings and initialising the DDR timings to avoid boot-loader
defaults.The controller IP works in conjunction with PRCM (OMAP Power
IP) block to achieve some of this functionality.

I was hoping that we will have some thing like drivers/memory/*
but since it doesn't exist, we used drivers/misc.

Regards
Santosh
[1] https://lkml.org/lkml/2012/3/19/178

>> This is useful not only for OMAP4 and AM3517/3505, but also will probably 
>> be useful for the C6x chips that Mark Salter is working on.
> 
> It's still in my "to-review" queue, that I'm slowly making my way
> through.  So it's not lost, but I would like to get the devfreq
> interface question cleared up first.
> 
Let us know if you need more clarification on devfreq part.
Thanks for looking into it.

Regards
Santosh

  parent reply	other threads:[~2012-04-12  6:47 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-16 21:51 [PATCH v4 0/7] Add TI EMIF SDRAM controller driver Aneesh V
2012-03-16 21:51 ` Aneesh V
2012-03-16 21:51 ` [PATCH v4 1/7] misc: ddr: add LPDDR2 data from JESD209-2 Aneesh V
2012-03-16 21:51   ` Aneesh V
2012-03-16 21:51 ` [PATCH v4 2/7] misc: emif: add register definitions for EMIF Aneesh V
2012-03-16 21:51   ` Aneesh V
2012-03-16 21:51 ` [PATCH v4 3/7] misc: emif: add basic infrastructure for EMIF driver Aneesh V
2012-03-16 21:51   ` Aneesh V
2012-03-16 21:51 ` [PATCH v4 4/7] misc: emif: handle frequency and voltage change events Aneesh V
2012-03-16 21:51   ` Aneesh V
2012-03-16 21:51 ` [PATCH v4 5/7] misc: emif: add interrupt and temperature handling Aneesh V
2012-03-16 21:51   ` Aneesh V
2012-03-16 21:51 ` [PATCH v4 6/7] misc: emif: add one-time settings Aneesh V
2012-03-16 21:51   ` Aneesh V
2012-03-16 21:51 ` [PATCH v4 7/7] misc: emif: add debugfs entries for emif Aneesh V
2012-03-16 21:51   ` Aneesh V
2012-03-17  6:10 ` [PATCH v4 0/7] Add TI EMIF SDRAM controller driver Kyungmin Park
2012-03-17  6:10   ` Kyungmin Park
2012-03-17  6:10   ` Kyungmin Park
2012-04-12  2:44 ` Paul Walmsley
2012-04-12  2:44   ` Paul Walmsley
2012-04-12  2:57   ` Aneesh V
2012-04-12  2:57     ` Aneesh V
2012-04-12  2:57     ` Aneesh V
2012-04-12  3:00   ` Greg KH
2012-04-12  3:00     ` Greg KH
2012-04-12  3:12     ` Paul Walmsley
2012-04-12  3:12       ` Paul Walmsley
2012-04-12  6:47     ` Santosh Shilimkar [this message]
2012-04-12  6:47       ` Santosh Shilimkar
2012-04-12 13:10       ` Greg KH
2012-04-12 13:10         ` Greg KH
2012-04-12 13:34         ` Mohammed, Afzal
2012-04-12 13:34           ` Mohammed, Afzal
2012-04-12 13:34           ` Mohammed, Afzal
2012-04-12 14:10           ` Greg KH
2012-04-12 14:10             ` Greg KH
2012-04-12 14:10             ` Greg KH
2012-04-12 14:15             ` Mohammed, Afzal
2012-04-12 14:15               ` Mohammed, Afzal
2012-04-12 14:15               ` Mohammed, Afzal
2012-04-12 14:21           ` Kevin Hilman
2012-04-12 14:21             ` Kevin Hilman
2012-04-12 14:21             ` Kevin Hilman
2012-04-12 17:00           ` Paul Walmsley
2012-04-12 17:00             ` Paul Walmsley
2012-04-12 17:00             ` Paul Walmsley
2012-04-12 18:50             ` Cousson, Benoit
2012-04-12 18:50               ` Cousson, Benoit
2012-04-12 18:50               ` Cousson, Benoit
2012-04-12 19:15               ` Paul Walmsley
2012-04-12 19:15                 ` Paul Walmsley
2012-04-12 19:15                 ` Paul Walmsley
2012-04-12 19:24                 ` Cousson, Benoit
2012-04-12 19:24                   ` Cousson, Benoit
2012-04-12 19:24                   ` Cousson, Benoit
2012-04-13  9:07               ` Felipe Balbi
2012-04-13  9:07                 ` Felipe Balbi
2012-04-13  9:07                 ` Felipe Balbi
2012-04-12 14:14         ` Shilimkar, Santosh
2012-04-12 14:14           ` Shilimkar, Santosh
2012-04-12 19:58     ` V, Aneesh
2012-04-12 19:58       ` V, Aneesh
2012-04-23 10:56       ` Mohammed, Afzal
2012-04-23 10:56         ` Mohammed, Afzal
2012-04-23 10:56         ` Mohammed, Afzal
2012-04-23 11:04         ` Shilimkar, Santosh
2012-04-23 11:04           ` Shilimkar, Santosh
2012-04-23 11:04           ` Shilimkar, Santosh
2012-04-23 11:09           ` Mohammed, Afzal
2012-04-23 11:09             ` Mohammed, Afzal
2012-04-23 11:09             ` Mohammed, Afzal
2012-04-23 14:27           ` Greg KH
2012-04-23 14:27             ` Greg KH
2012-04-23 14:27             ` Greg KH
2012-04-23 14:44             ` Shilimkar, Santosh
2012-04-23 14:44               ` Shilimkar, Santosh
2012-04-23 14:44               ` Shilimkar, Santosh
2012-04-27 13:16               ` Santosh Shilimkar
2012-04-27 13:16                 ` Santosh Shilimkar
2012-04-27 13:16                 ` Santosh Shilimkar
2012-04-13 14:15   ` Mark Salter
2012-04-13 14:15     ` Mark Salter
2012-03-19  1:08 함명주
2012-03-19  7:07 ` Shilimkar, Santosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F867A95.9030104@ti.com \
    --to=santosh.shilimkar@ti.com \
    --cc=aneesh@ti.com \
    --cc=greg@kroah.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mgreer@animalcreek.com \
    --cc=msalter@redhat.com \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.