From: Marc Zyngier <marc.zyngier@arm.com>
To: viresh kumar <viresh.linux@gmail.com>
Cc: "wim@iguana.be" <wim@iguana.be>,
"spear-devel@list.st.com" <spear-devel@list.st.com>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Pawel Moll <Pawel.Moll@arm.com>,
Viresh Kumar <viresh.kumar@st.com>
Subject: Re: [PATCH V2] watchdog: mpcore: Add DT probing support for ARM mpcore watchdog
Date: Mon, 23 Apr 2012 13:15:31 +0100 [thread overview]
Message-ID: <4F9547E3.4000709@arm.com> (raw)
In-Reply-To: <CAOh2x=kroSi8MZBhYVOhrDm08q1B9LS_9P7NPAfHC01-MHaOCQ@mail.gmail.com>
On 23/04/12 12:35, viresh kumar wrote:
> On Mon, Apr 23, 2012 at 2:06 PM, Marc Zyngier <marc.zyngier@arm.com> wrote:
>> Irk! Have you actually tested this?
>
> Yes. But with incorrect base address. I passed timers address by mistake.
Ah, that explains why it worked. I suppose you do have additional
patches that fix the IRQ request bit?
>> The DT binding indicates:
>> - reg : Specify the base address and the size of the TWD watchdog
>> register window.
>>
>> while all the offsets in smp_twd.h are expressed in bytes from the TWD
>> *timer* base. So you have to either fix these offsets (which breaks
>> potential users of the non-DT version of the driver), or correct the
>> base when using DT.
>
> You are correct. Which one do you prefer:
> - Change bindings to pass timers base address
No. We already discussed this on LAK, and the outcome was the current
binding, so let's not change that again.
> - subtract 0x20 from base address for DT case
That's a possibility.
> - something else.
Given that no in-tree platform seem to be using this watchdog (at least
a quick grep didn't reveal anything), I'd be inclined to simply change
the offset in smp_twd.h and let them break.
M.
--
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] watchdog: mpcore: Add DT probing support for ARM mpcore watchdog
Date: Mon, 23 Apr 2012 13:15:31 +0100 [thread overview]
Message-ID: <4F9547E3.4000709@arm.com> (raw)
In-Reply-To: <CAOh2x=kroSi8MZBhYVOhrDm08q1B9LS_9P7NPAfHC01-MHaOCQ@mail.gmail.com>
On 23/04/12 12:35, viresh kumar wrote:
> On Mon, Apr 23, 2012 at 2:06 PM, Marc Zyngier <marc.zyngier@arm.com> wrote:
>> Irk! Have you actually tested this?
>
> Yes. But with incorrect base address. I passed timers address by mistake.
Ah, that explains why it worked. I suppose you do have additional
patches that fix the IRQ request bit?
>> The DT binding indicates:
>> - reg : Specify the base address and the size of the TWD watchdog
>> register window.
>>
>> while all the offsets in smp_twd.h are expressed in bytes from the TWD
>> *timer* base. So you have to either fix these offsets (which breaks
>> potential users of the non-DT version of the driver), or correct the
>> base when using DT.
>
> You are correct. Which one do you prefer:
> - Change bindings to pass timers base address
No. We already discussed this on LAK, and the outcome was the current
binding, so let's not change that again.
> - subtract 0x20 from base address for DT case
That's a possibility.
> - something else.
Given that no in-tree platform seem to be using this watchdog (at least
a quick grep didn't reveal anything), I'd be inclined to simply change
the offset in smp_twd.h and let them break.
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2012-04-23 12:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 14:42 [PATCH] watchdog: mpcore: Add DT bindings for ARM mpcore watchdog Viresh Kumar
2012-04-20 14:42 ` Viresh Kumar
2012-04-21 8:32 ` Pawel Moll
2012-04-21 8:32 ` Pawel Moll
2012-04-21 11:41 ` [PATCH V2] watchdog: mpcore: Add DT probing support " Viresh Kumar
2012-04-21 11:41 ` Viresh Kumar
2012-04-23 8:36 ` Marc Zyngier
2012-04-23 8:36 ` Marc Zyngier
2012-04-23 11:35 ` viresh kumar
2012-04-23 11:35 ` viresh kumar
2012-04-23 12:15 ` Marc Zyngier [this message]
2012-04-23 12:15 ` Marc Zyngier
2012-04-23 12:21 ` viresh kumar
2012-04-23 12:21 ` viresh kumar
2012-04-23 14:21 ` viresh kumar
2012-04-23 14:21 ` viresh kumar
2012-04-23 15:22 ` Marc Zyngier
2012-04-23 15:22 ` Marc Zyngier
2012-04-23 15:33 ` viresh kumar
2012-04-23 15:33 ` viresh kumar
2012-04-23 15:49 ` Marc Zyngier
2012-04-23 15:49 ` Marc Zyngier
2012-04-23 16:01 ` viresh kumar
2012-04-23 16:01 ` viresh kumar
2012-04-23 16:12 ` Marc Zyngier
2012-04-23 16:12 ` Marc Zyngier
2012-04-23 16:16 ` viresh kumar
2012-04-23 16:16 ` viresh kumar
2012-04-23 16:26 ` Marc Zyngier
2012-04-23 16:26 ` Marc Zyngier
2012-04-24 10:25 ` Viresh Kumar
2012-04-24 10:25 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9547E3.4000709@arm.com \
--to=marc.zyngier@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=viresh.kumar@st.com \
--cc=viresh.linux@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.