From: Rik van Riel <riel@redhat.com>
To: lwoodman@redhat.com
Cc: KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
linux-mm@kvack.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Lameter <cl@linux.com>,
Motohiro Kosaki <mkosaki@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -mm V2] do_migrate_pages() calls migrate_to_node() even if task is already on a correct node
Date: Tue, 24 Apr 2012 13:21:06 -0400 [thread overview]
Message-ID: <4F96E102.9000904@redhat.com> (raw)
In-Reply-To: <4F96DFE0.6040306@redhat.com>
On 04/24/2012 01:16 PM, Larry Woodman wrote:
> On 04/24/2012 12:19 PM, KOSAKI Motohiro wrote:
>> Please use
>>
>> /*
>> * foo bar
>> */
>>
>> style comment. and this comment only explain how code work but don't
>> explain why.
>> I hope the comment describe HPC usecase require to migrate if src and
>> dest have the
>> same weight.
> How does this look:
Still does not explain the "why"...
--
All rights reversed
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: lwoodman@redhat.com
Cc: KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
linux-mm@kvack.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Lameter <cl@linux.com>,
Motohiro Kosaki <mkosaki@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -mm V2] do_migrate_pages() calls migrate_to_node() even if task is already on a correct node
Date: Tue, 24 Apr 2012 13:21:06 -0400 [thread overview]
Message-ID: <4F96E102.9000904@redhat.com> (raw)
In-Reply-To: <4F96DFE0.6040306@redhat.com>
On 04/24/2012 01:16 PM, Larry Woodman wrote:
> On 04/24/2012 12:19 PM, KOSAKI Motohiro wrote:
>> Please use
>>
>> /*
>> * foo bar
>> */
>>
>> style comment. and this comment only explain how code work but don't
>> explain why.
>> I hope the comment describe HPC usecase require to migrate if src and
>> dest have the
>> same weight.
> How does this look:
Still does not explain the "why"...
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-04-24 17:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 15:59 [PATCH -mm V2] do_migrate_pages() calls migrate_to_node() even if task is already on a correct node Larry Woodman
2012-04-24 16:08 ` Christoph Lameter
2012-04-24 16:08 ` Christoph Lameter
2012-04-24 16:19 ` KOSAKI Motohiro
2012-04-24 16:19 ` KOSAKI Motohiro
2012-04-24 17:16 ` Larry Woodman
2012-04-24 17:17 ` KOSAKI Motohiro
2012-04-24 17:17 ` KOSAKI Motohiro
2012-04-24 17:21 ` Rik van Riel [this message]
2012-04-24 17:21 ` Rik van Riel
2012-04-24 18:17 ` Christoph Lameter
2012-04-24 18:17 ` Christoph Lameter
2012-04-24 20:08 ` Larry Woodman
2012-04-24 20:08 ` Larry Woodman
2012-04-24 20:11 ` Rik van Riel
2012-04-24 20:11 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F96E102.9000904@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lwoodman@redhat.com \
--cc=mkosaki@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.