From: Christoph Lameter <cl@linux.com>
To: Larry Woodman <lwoodman@redhat.com>
Cc: linux-mm@kvack.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Motohiro Kosaki <mkosaki@redhat.com>,
Rik van Riel <riel@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -mm V2] do_migrate_pages() calls migrate_to_node() even if task is already on a correct node
Date: Tue, 24 Apr 2012 11:08:25 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1204241106240.26005@router.home> (raw)
In-Reply-To: <4F96CDE1.5000909@redhat.com>
On Tue, 24 Apr 2012, Larry Woodman wrote:
> While moving tasks between cpusets we noticed some strange behavior.
> Specifically if the nodes of the destination
> cpuset are a subset of the nodes of the source cpuset do_migrate_pages() will
> move pages that are already on a node
> in the destination cpuset. The reason for this is do_migrate_pages() does not
> check whether each node in the source
> nodemask is in the destination nodemask before calling migrate_to_node(). If
> we simply do this check and skip them
> when the source is in the destination moving we wont move nodes that dont need
> to be moved.
Acked-by: Christoph Lameter <cl@linux.com>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Lameter <cl@linux.com>
To: Larry Woodman <lwoodman@redhat.com>
Cc: linux-mm@kvack.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Motohiro Kosaki <mkosaki@redhat.com>,
Rik van Riel <riel@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -mm V2] do_migrate_pages() calls migrate_to_node() even if task is already on a correct node
Date: Tue, 24 Apr 2012 11:08:25 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1204241106240.26005@router.home> (raw)
In-Reply-To: <4F96CDE1.5000909@redhat.com>
On Tue, 24 Apr 2012, Larry Woodman wrote:
> While moving tasks between cpusets we noticed some strange behavior.
> Specifically if the nodes of the destination
> cpuset are a subset of the nodes of the source cpuset do_migrate_pages() will
> move pages that are already on a node
> in the destination cpuset. The reason for this is do_migrate_pages() does not
> check whether each node in the source
> nodemask is in the destination nodemask before calling migrate_to_node(). If
> we simply do this check and skip them
> when the source is in the destination moving we wont move nodes that dont need
> to be moved.
Acked-by: Christoph Lameter <cl@linux.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-04-24 16:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 15:59 [PATCH -mm V2] do_migrate_pages() calls migrate_to_node() even if task is already on a correct node Larry Woodman
2012-04-24 16:08 ` Christoph Lameter [this message]
2012-04-24 16:08 ` Christoph Lameter
2012-04-24 16:19 ` KOSAKI Motohiro
2012-04-24 16:19 ` KOSAKI Motohiro
2012-04-24 17:16 ` Larry Woodman
2012-04-24 17:17 ` KOSAKI Motohiro
2012-04-24 17:17 ` KOSAKI Motohiro
2012-04-24 17:21 ` Rik van Riel
2012-04-24 17:21 ` Rik van Riel
2012-04-24 18:17 ` Christoph Lameter
2012-04-24 18:17 ` Christoph Lameter
2012-04-24 20:08 ` Larry Woodman
2012-04-24 20:08 ` Larry Woodman
2012-04-24 20:11 ` Rik van Riel
2012-04-24 20:11 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1204241106240.26005@router.home \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lwoodman@redhat.com \
--cc=mkosaki@redhat.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.