All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] binutils-cross-canadian: Allow ld-is-gold
@ 2012-01-04  1:23 Derek Buitenhuis
  2012-01-04  1:23 ` [PATCH 2/2] binutils: Allow plugins Derek Buitenhuis
                   ` (2 more replies)
  0 siblings, 3 replies; 17+ messages in thread
From: Derek Buitenhuis @ 2012-01-04  1:23 UTC (permalink / raw)
  To: poky

In order to actually generate a toolchain (with
bitbake meta-toolchain) that supports gold, binutils-
cross-canadian also needs to be built this way.

Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
---
 .../binutils/binutils-cross-canadian.inc           |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-devtools/binutils/binutils-cross-canadian.inc b/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
index b1cee67..00648a6 100644
--- a/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
+++ b/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
@@ -7,7 +7,8 @@ BPN = "binutils"
 DEPENDS = "flex-native bison-native virtual/${HOST_PREFIX}gcc-crosssdk virtual/libc-nativesdk zlib-nativesdk gettext-nativesdk"
 EXTRA_OECONF = "--with-sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-${TARGET_OS} \
                 --program-prefix=${TARGET_PREFIX} \
-                --disable-werror"
+                --disable-werror \
+                ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)}"
 
 do_install () {
 	autotools_do_install
-- 
1.7.7.3



^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 2/2] binutils: Allow plugins
  2012-01-04  1:23 [PATCH 1/2] binutils-cross-canadian: Allow ld-is-gold Derek Buitenhuis
@ 2012-01-04  1:23 ` Derek Buitenhuis
  2012-01-06 21:48   ` Derek Buitenhuis
                     ` (2 more replies)
  2012-01-05 20:15 ` [PATCH 1/2] binutils-cross-canadian: Allow ld-is-gold Saul Wold
  2012-01-22 18:41 ` [PATCH 2/2 v2] binutils: Always enable plugins Derek Buitenhuis
  2 siblings, 3 replies; 17+ messages in thread
From: Derek Buitenhuis @ 2012-01-04  1:23 UTC (permalink / raw)
  To: poky

Make sure it's possible to build binutils with
plugin support.

Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
---
 .../binutils/binutils-cross-canadian.inc           |    3 ++-
 meta/recipes-devtools/binutils/binutils-cross.inc  |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/binutils/binutils-cross-canadian.inc b/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
index 00648a6..4f20ad7 100644
--- a/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
+++ b/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
@@ -8,7 +8,8 @@ DEPENDS = "flex-native bison-native virtual/${HOST_PREFIX}gcc-crosssdk virtual/l
 EXTRA_OECONF = "--with-sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-${TARGET_OS} \
                 --program-prefix=${TARGET_PREFIX} \
                 --disable-werror \
-                ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)}"
+                ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)} \
+                ${@base_contains('DISTRO_FEATURES', 'binutils-plugins', '--enable-plugins', '', d)}"
 
 do_install () {
 	autotools_do_install
diff --git a/meta/recipes-devtools/binutils/binutils-cross.inc b/meta/recipes-devtools/binutils/binutils-cross.inc
index 80152a9..0af913d 100644
--- a/meta/recipes-devtools/binutils/binutils-cross.inc
+++ b/meta/recipes-devtools/binutils/binutils-cross.inc
@@ -10,7 +10,8 @@ EXTRA_OECONF = "--with-sysroot=${STAGING_DIR_TARGET} \
                 --disable-werror \
                 --enable-poison-system-directories \
                 ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)} \
-                ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)}"
+                ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
+                ${@base_contains('DISTRO_FEATURES', 'binutils-plugins', '--enable-plugins', '', d)}"
 
 do_install () {
 	oe_runmake 'DESTDIR=${D}' install
-- 
1.7.7.3



^ permalink raw reply related	[flat|nested] 17+ messages in thread

* Re: [PATCH 1/2] binutils-cross-canadian: Allow ld-is-gold
  2012-01-04  1:23 [PATCH 1/2] binutils-cross-canadian: Allow ld-is-gold Derek Buitenhuis
  2012-01-04  1:23 ` [PATCH 2/2] binutils: Allow plugins Derek Buitenhuis
@ 2012-01-05 20:15 ` Saul Wold
  2012-01-05 20:33   ` Derek Buitenhuis
  2012-01-22 18:41 ` [PATCH 2/2 v2] binutils: Always enable plugins Derek Buitenhuis
  2 siblings, 1 reply; 17+ messages in thread
From: Saul Wold @ 2012-01-05 20:15 UTC (permalink / raw)
  To: Derek Buitenhuis; +Cc: poky

On 01/03/2012 05:23 PM, Derek Buitenhuis wrote:
> In order to actually generate a toolchain (with
> bitbake meta-toolchain) that supports gold, binutils-
> cross-canadian also needs to be built this way.
>
> Signed-off-by: Derek Buitenhuis<derek.buitenhuis@gmail.com>
> ---
>   .../binutils/binutils-cross-canadian.inc           |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-devtools/binutils/binutils-cross-canadian.inc b/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
> index b1cee67..00648a6 100644
> --- a/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
> +++ b/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
> @@ -7,7 +7,8 @@ BPN = "binutils"
>   DEPENDS = "flex-native bison-native virtual/${HOST_PREFIX}gcc-crosssdk virtual/libc-nativesdk zlib-nativesdk gettext-nativesdk"
>   EXTRA_OECONF = "--with-sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-${TARGET_OS} \
>                   --program-prefix=${TARGET_PREFIX} \
> -                --disable-werror"
> +                --disable-werror \
> +                ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)}"
>
>   do_install () {
>   	autotools_do_install

Merged into OE-Core

In the future for OE-Core (meta/*) changes please send them to 
openembedded-core@lists.openembedded.org

Thanks
	Sau!


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 1/2] binutils-cross-canadian: Allow ld-is-gold
  2012-01-05 20:15 ` [PATCH 1/2] binutils-cross-canadian: Allow ld-is-gold Saul Wold
@ 2012-01-05 20:33   ` Derek Buitenhuis
  0 siblings, 0 replies; 17+ messages in thread
From: Derek Buitenhuis @ 2012-01-05 20:33 UTC (permalink / raw)
  To: Saul Wold; +Cc: poky

On 05/01/2012 3:15 PM, Saul Wold wrote:
>
> Merged into OE-Core
>
> In the future for OE-Core (meta/*) changes please send them to
> openembedded-core@lists.openembedded.org
>
> Thanks
>      Sau!

Thanks, and noted for future reference.

Cheers,

- Derek


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2] binutils: Allow plugins
  2012-01-04  1:23 ` [PATCH 2/2] binutils: Allow plugins Derek Buitenhuis
@ 2012-01-06 21:48   ` Derek Buitenhuis
  2012-01-06 22:31   ` Saul Wold
  2012-01-21 22:58   ` Khem Raj
  2 siblings, 0 replies; 17+ messages in thread
From: Derek Buitenhuis @ 2012-01-06 21:48 UTC (permalink / raw)
  To: poky

Should I send this patch to oe-core (ML and/or github pull req) instead?

- Derek


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2] binutils: Allow plugins
  2012-01-04  1:23 ` [PATCH 2/2] binutils: Allow plugins Derek Buitenhuis
  2012-01-06 21:48   ` Derek Buitenhuis
@ 2012-01-06 22:31   ` Saul Wold
  2012-01-21 22:58   ` Khem Raj
  2 siblings, 0 replies; 17+ messages in thread
From: Saul Wold @ 2012-01-06 22:31 UTC (permalink / raw)
  To: Derek Buitenhuis; +Cc: poky

On 01/03/2012 05:23 PM, Derek Buitenhuis wrote:
> Make sure it's possible to build binutils with
> plugin support.
>
> Signed-off-by: Derek Buitenhuis<derek.buitenhuis@gmail.com>
> ---
>   .../binutils/binutils-cross-canadian.inc           |    3 ++-
>   meta/recipes-devtools/binutils/binutils-cross.inc  |    3 ++-
>   2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/binutils/binutils-cross-canadian.inc b/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
> index 00648a6..4f20ad7 100644
> --- a/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
> +++ b/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
> @@ -8,7 +8,8 @@ DEPENDS = "flex-native bison-native virtual/${HOST_PREFIX}gcc-crosssdk virtual/l
>   EXTRA_OECONF = "--with-sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-${TARGET_OS} \
>                   --program-prefix=${TARGET_PREFIX} \
>                   --disable-werror \
> -                ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)}"
> +                ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)} \
> +                ${@base_contains('DISTRO_FEATURES', 'binutils-plugins', '--enable-plugins', '', d)}"
>
>   do_install () {
>   	autotools_do_install
> diff --git a/meta/recipes-devtools/binutils/binutils-cross.inc b/meta/recipes-devtools/binutils/binutils-cross.inc
> index 80152a9..0af913d 100644
> --- a/meta/recipes-devtools/binutils/binutils-cross.inc
> +++ b/meta/recipes-devtools/binutils/binutils-cross.inc
> @@ -10,7 +10,8 @@ EXTRA_OECONF = "--with-sysroot=${STAGING_DIR_TARGET} \
>                   --disable-werror \
>                   --enable-poison-system-directories \
>                   ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)} \
> -                ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)}"
> +                ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
> +                ${@base_contains('DISTRO_FEATURES', 'binutils-plugins', '--enable-plugins', '', d)}"
>
>   do_install () {
>   	oe_runmake 'DESTDIR=${D}' install

I think that the DISTRO_FEATURE here is too much, you this be changed to 
be a PACKAGECONFIG instead?

Sau!


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2] binutils: Allow plugins
  2012-01-04  1:23 ` [PATCH 2/2] binutils: Allow plugins Derek Buitenhuis
  2012-01-06 21:48   ` Derek Buitenhuis
  2012-01-06 22:31   ` Saul Wold
@ 2012-01-21 22:58   ` Khem Raj
  2012-01-22 18:41     ` Derek Buitenhuis
  2 siblings, 1 reply; 17+ messages in thread
From: Khem Raj @ 2012-01-21 22:58 UTC (permalink / raw)
  To: Derek Buitenhuis; +Cc: poky

On (03/01/12 20:23), Derek Buitenhuis wrote:
> Make sure it's possible to build binutils with
> plugin support.
> 
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
> ---
>  .../binutils/binutils-cross-canadian.inc           |    3 ++-
>  meta/recipes-devtools/binutils/binutils-cross.inc  |    3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/binutils/binutils-cross-canadian.inc b/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
> index 00648a6..4f20ad7 100644
> --- a/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
> +++ b/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
> @@ -8,7 +8,8 @@ DEPENDS = "flex-native bison-native virtual/${HOST_PREFIX}gcc-crosssdk virtual/l
>  EXTRA_OECONF = "--with-sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-${TARGET_OS} \
>                  --program-prefix=${TARGET_PREFIX} \
>                  --disable-werror \
> -                ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)}"
> +                ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)} \
> +                ${@base_contains('DISTRO_FEATURES', 'binutils-plugins', '--enable-plugins', '', d)}"

enabling plugins regardless is a good thing and since we use binutils
2.22+ now a days in oe-core plugins are well supported. Please submit the patch
where you add this option (--enable-plugins) to binutils common configure
that will be add to EXTRA_OECONF in binutils.inc

-Khem



^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH 2/2 v2] binutils: Always enable plugins
  2012-01-04  1:23 [PATCH 1/2] binutils-cross-canadian: Allow ld-is-gold Derek Buitenhuis
  2012-01-04  1:23 ` [PATCH 2/2] binutils: Allow plugins Derek Buitenhuis
  2012-01-05 20:15 ` [PATCH 1/2] binutils-cross-canadian: Allow ld-is-gold Saul Wold
@ 2012-01-22 18:41 ` Derek Buitenhuis
  2012-01-22 18:57   ` Khem Raj
  2 siblings, 1 reply; 17+ messages in thread
From: Derek Buitenhuis @ 2012-01-22 18:41 UTC (permalink / raw)
  To: poky

Since oe-core now uses binutils 2.22+, plugins should be
well supported. Enable them by default.

Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
---
 .../binutils/binutils-cross-canadian.inc           |    1 +
 meta/recipes-devtools/binutils/binutils-cross.inc  |    1 +
 meta/recipes-devtools/binutils/binutils.inc        |    1 +
 3 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/meta/recipes-devtools/binutils/binutils-cross-canadian.inc b/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
index 15b9abb..c902c51 100644
--- a/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
+++ b/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
@@ -8,6 +8,7 @@ DEPENDS = "flex-native bison-native virtual/${HOST_PREFIX}gcc-crosssdk virtual/l
 EXTRA_OECONF = "--with-sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-${TARGET_OS} \
                 --program-prefix=${TARGET_PREFIX} \
                 --disable-werror \
+                --enable-plugins \
                 ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)}"
 
 do_install () {
diff --git a/meta/recipes-devtools/binutils/binutils-cross.inc b/meta/recipes-devtools/binutils/binutils-cross.inc
index 80152a9..38457e8 100644
--- a/meta/recipes-devtools/binutils/binutils-cross.inc
+++ b/meta/recipes-devtools/binutils/binutils-cross.inc
@@ -9,6 +9,7 @@ EXTRA_OECONF = "--with-sysroot=${STAGING_DIR_TARGET} \
                 --disable-install-libbfd \
                 --disable-werror \
                 --enable-poison-system-directories \
+                --enable-plugins \
                 ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)} \
                 ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)}"
 
diff --git a/meta/recipes-devtools/binutils/binutils.inc b/meta/recipes-devtools/binutils/binutils.inc
index 30a0416..5449e1a 100644
--- a/meta/recipes-devtools/binutils/binutils.inc
+++ b/meta/recipes-devtools/binutils/binutils.inc
@@ -52,6 +52,7 @@ B = "${S}/build.${HOST_SYS}.${TARGET_SYS}"
 EXTRA_OECONF = "--program-prefix=${TARGET_PREFIX} \
                 --enable-install-libbfd \
                 --enable-shared \
+                --enable-plugins \
                 ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)}"
 
 EXTRA_OECONF_virtclass-native = "--enable-target=all --enable-64-bit-bfd --enable-install-libbfd"
-- 
1.7.8.3



^ permalink raw reply related	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2] binutils: Allow plugins
  2012-01-21 22:58   ` Khem Raj
@ 2012-01-22 18:41     ` Derek Buitenhuis
  0 siblings, 0 replies; 17+ messages in thread
From: Derek Buitenhuis @ 2012-01-22 18:41 UTC (permalink / raw)
  To: raj.khem; +Cc: poky

On 21/01/2012 5:58 PM, Khem Raj wrote:
> enabling plugins regardless is a good thing and since we use binutils
> 2.22+ now a days in oe-core plugins are well supported. Please submit the patch
> where you add this option (--enable-plugins) to binutils common configure
> that will be add to EXTRA_OECONF in binutils.inc
>
> -Khem

Sweet! Sorry I've been MIA for a bit. I've sent in the new patch,
which patches all 3 includes. From a look, this seemed necessary,
but if it isn't, let me know.

Patch is sent in reply to the original patch set, titled:

     [PATCH 2/2 v2] binutils: Always enable plugins

Enjoy.

- Derek


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2 v2] binutils: Always enable plugins
  2012-01-22 18:41 ` [PATCH 2/2 v2] binutils: Always enable plugins Derek Buitenhuis
@ 2012-01-22 18:57   ` Khem Raj
  2012-01-22 19:01     ` Derek Buitenhuis
  2012-02-02  2:08     ` Derek Buitenhuis
  0 siblings, 2 replies; 17+ messages in thread
From: Khem Raj @ 2012-01-22 18:57 UTC (permalink / raw)
  To: Derek Buitenhuis; +Cc: poky

On Sun, Jan 22, 2012 at 10:41 AM, Derek Buitenhuis
<derek.buitenhuis@gmail.com> wrote:
> Since oe-core now uses binutils 2.22+, plugins should be
> well supported. Enable them by default.
>
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
> ---
>  .../binutils/binutils-cross-canadian.inc           |    1 +
>  meta/recipes-devtools/binutils/binutils-cross.inc  |    1 +
>  meta/recipes-devtools/binutils/binutils.inc        |    1 +
>  3 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/meta/recipes-devtools/binutils/binutils-cross-canadian.inc b/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
> index 15b9abb..c902c51 100644
> --- a/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
> +++ b/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
> @@ -8,6 +8,7 @@ DEPENDS = "flex-native bison-native virtual/${HOST_PREFIX}gcc-crosssdk virtual/l
>  EXTRA_OECONF = "--with-sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-${TARGET_OS} \
>                 --program-prefix=${TARGET_PREFIX} \
>                 --disable-werror \
> +                --enable-plugins \
>                 ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)}"
>
>  do_install () {
> diff --git a/meta/recipes-devtools/binutils/binutils-cross.inc b/meta/recipes-devtools/binutils/binutils-cross.inc
> index 80152a9..38457e8 100644
> --- a/meta/recipes-devtools/binutils/binutils-cross.inc
> +++ b/meta/recipes-devtools/binutils/binutils-cross.inc
> @@ -9,6 +9,7 @@ EXTRA_OECONF = "--with-sysroot=${STAGING_DIR_TARGET} \
>                 --disable-install-libbfd \
>                 --disable-werror \
>                 --enable-poison-system-directories \
> +                --enable-plugins \
>                 ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)} \
>                 ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)}"
>
> diff --git a/meta/recipes-devtools/binutils/binutils.inc b/meta/recipes-devtools/binutils/binutils.inc
> index 30a0416..5449e1a 100644
> --- a/meta/recipes-devtools/binutils/binutils.inc
> +++ b/meta/recipes-devtools/binutils/binutils.inc
> @@ -52,6 +52,7 @@ B = "${S}/build.${HOST_SYS}.${TARGET_SYS}"
>  EXTRA_OECONF = "--program-prefix=${TARGET_PREFIX} \
>                 --enable-install-libbfd \
>                 --enable-shared \
> +                --enable-plugins \
>                 ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)}"
>
>  EXTRA_OECONF_virtclass-native = "--enable-target=all --enable-64-bit-bfd --enable-install-libbfd"
> --
> 1.7.8.3



while this patch is ok. It occurs to me that we might have to find an
easier way to specify common options once for all binutils recipes
>


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2 v2] binutils: Always enable plugins
  2012-01-22 18:57   ` Khem Raj
@ 2012-01-22 19:01     ` Derek Buitenhuis
  2012-01-22 19:05       ` Khem Raj
  2012-02-02  2:08     ` Derek Buitenhuis
  1 sibling, 1 reply; 17+ messages in thread
From: Derek Buitenhuis @ 2012-01-22 19:01 UTC (permalink / raw)
  To: Khem Raj; +Cc: poky

On 22/01/2012 1:57 PM, Khem Raj wrote:
> while this patch is ok. It occurs to me that we might have to find an
> easier way to specify common options once for all binutils recipes

A singular EXTRA_OECONF = ... in binutils.inc, and use EXTRA_OECONF +=
elsewhere after including it, perhaps? :/

- Derek


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2 v2] binutils: Always enable plugins
  2012-01-22 19:01     ` Derek Buitenhuis
@ 2012-01-22 19:05       ` Khem Raj
  0 siblings, 0 replies; 17+ messages in thread
From: Khem Raj @ 2012-01-22 19:05 UTC (permalink / raw)
  To: Derek Buitenhuis; +Cc: poky

On Sun, Jan 22, 2012 at 11:01 AM, Derek Buitenhuis
<derek.buitenhuis@gmail.com> wrote:
> On 22/01/2012 1:57 PM, Khem Raj wrote:
>>
>> while this patch is ok. It occurs to me that we might have to find an
>> easier way to specify common options once for all binutils recipes
>
>
> A singular EXTRA_OECONF = ... in binutils.inc, and use EXTRA_OECONF +=
> elsewhere after including it, perhaps? :/
>


yes we can refactor binutils.inc into binutils-common.inc and binutils.inc
where the former holds the shareable parts
> - Derek


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2 v2] binutils: Always enable plugins
  2012-01-22 18:57   ` Khem Raj
  2012-01-22 19:01     ` Derek Buitenhuis
@ 2012-02-02  2:08     ` Derek Buitenhuis
  2012-02-02  5:04       ` Khem Raj
  1 sibling, 1 reply; 17+ messages in thread
From: Derek Buitenhuis @ 2012-02-02  2:08 UTC (permalink / raw)
  To: Khem Raj; +Cc: poky

On 22/01/2012 1:57 PM, Khem Raj wrote:
> while this patch is ok. It occurs to me that we might have to find an
> easier way to specify common options once for all binutils recipes

So uh, I am not clear if this patch will be pushed or if you're
waiting for a refactor of binutils...

- Derek


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2 v2] binutils: Always enable plugins
  2012-02-02  2:08     ` Derek Buitenhuis
@ 2012-02-02  5:04       ` Khem Raj
  2012-04-29 17:56         ` Derek Buitenhuis
  0 siblings, 1 reply; 17+ messages in thread
From: Khem Raj @ 2012-02-02  5:04 UTC (permalink / raw)
  To: Derek Buitenhuis; +Cc: poky

On Wed, Feb 1, 2012 at 6:08 PM, Derek Buitenhuis
<derek.buitenhuis@gmail.com> wrote:
> On 22/01/2012 1:57 PM, Khem Raj wrote:
>>
>> while this patch is ok. It occurs to me that we might have to find an
>> easier way to specify common options once for all binutils recipes
>
>
> So uh, I am not clear if this patch will be pushed or if you're
> waiting for a refactor of binutils...

this is ok to go in. cleanup can happen at later times

>
> - Derek


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2 v2] binutils: Always enable plugins
  2012-02-02  5:04       ` Khem Raj
@ 2012-04-29 17:56         ` Derek Buitenhuis
  2012-04-30 14:36           ` Saul Wold
  2012-04-30 15:52           ` Koen Kooi
  0 siblings, 2 replies; 17+ messages in thread
From: Derek Buitenhuis @ 2012-04-29 17:56 UTC (permalink / raw)
  To: poky

On 02/02/2012 12:04 AM, Khem Raj wrote:
> On Wed, Feb 1, 2012 at 6:08 PM, Derek Buitenhuis
> <derek.buitenhuis@gmail.com> wrote:
>> On 22/01/2012 1:57 PM, Khem Raj wrote:
>>>
>>> while this patch is ok. It occurs to me that we might have to find an
>>> easier way to specify common options once for all binutils recipes
>>
>>
>> So uh, I am not clear if this patch will be pushed or if you're
>> waiting for a refactor of binutils...
> 
> this is ok to go in. cleanup can happen at later times

Ping! Resurrecting an old thread!

Is this going to be pushed?

- Derek


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2 v2] binutils: Always enable plugins
  2012-04-29 17:56         ` Derek Buitenhuis
@ 2012-04-30 14:36           ` Saul Wold
  2012-04-30 15:52           ` Koen Kooi
  1 sibling, 0 replies; 17+ messages in thread
From: Saul Wold @ 2012-04-30 14:36 UTC (permalink / raw)
  To: Derek Buitenhuis; +Cc: poky

On 04/29/2012 10:56 AM, Derek Buitenhuis wrote:
> On 02/02/2012 12:04 AM, Khem Raj wrote:
>> On Wed, Feb 1, 2012 at 6:08 PM, Derek Buitenhuis
>> <derek.buitenhuis@gmail.com>  wrote:
>>> On 22/01/2012 1:57 PM, Khem Raj wrote:
>>>>
>>>> while this patch is ok. It occurs to me that we might have to find an
>>>> easier way to specify common options once for all binutils recipes
>>>
>>>
>>> So uh, I am not clear if this patch will be pushed or if you're
>>> waiting for a refactor of binutils...
>>
>> this is ok to go in. cleanup can happen at later times
>
> Ping! Resurrecting an old thread!
>
> Is this going to be pushed?
>
Any reason to not do the refactor now?  It's early in 1.3, this would be 
good to have, let's do it right once.

Thanks
	Sau!


> - Derek
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 2/2 v2] binutils: Always enable plugins
  2012-04-29 17:56         ` Derek Buitenhuis
  2012-04-30 14:36           ` Saul Wold
@ 2012-04-30 15:52           ` Koen Kooi
  1 sibling, 0 replies; 17+ messages in thread
From: Koen Kooi @ 2012-04-30 15:52 UTC (permalink / raw)
  To: Derek Buitenhuis; +Cc: poky


Op 29 apr. 2012, om 19:56 heeft Derek Buitenhuis het volgende geschreven:

> On 02/02/2012 12:04 AM, Khem Raj wrote:
>> On Wed, Feb 1, 2012 at 6:08 PM, Derek Buitenhuis
>> <derek.buitenhuis@gmail.com> wrote:
>>> On 22/01/2012 1:57 PM, Khem Raj wrote:
>>>> 
>>>> while this patch is ok. It occurs to me that we might have to find an
>>>> easier way to specify common options once for all binutils recipes
>>> 
>>> 
>>> So uh, I am not clear if this patch will be pushed or if you're
>>> waiting for a refactor of binutils...
>> 
>> this is ok to go in. cleanup can happen at later times
> 
> Ping! Resurrecting an old thread!
> 
> Is this going to be pushed?

You could start by sending it to the right mailing list. Hint: not poky.


^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2012-04-30 15:52 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-04  1:23 [PATCH 1/2] binutils-cross-canadian: Allow ld-is-gold Derek Buitenhuis
2012-01-04  1:23 ` [PATCH 2/2] binutils: Allow plugins Derek Buitenhuis
2012-01-06 21:48   ` Derek Buitenhuis
2012-01-06 22:31   ` Saul Wold
2012-01-21 22:58   ` Khem Raj
2012-01-22 18:41     ` Derek Buitenhuis
2012-01-05 20:15 ` [PATCH 1/2] binutils-cross-canadian: Allow ld-is-gold Saul Wold
2012-01-05 20:33   ` Derek Buitenhuis
2012-01-22 18:41 ` [PATCH 2/2 v2] binutils: Always enable plugins Derek Buitenhuis
2012-01-22 18:57   ` Khem Raj
2012-01-22 19:01     ` Derek Buitenhuis
2012-01-22 19:05       ` Khem Raj
2012-02-02  2:08     ` Derek Buitenhuis
2012-02-02  5:04       ` Khem Raj
2012-04-29 17:56         ` Derek Buitenhuis
2012-04-30 14:36           ` Saul Wold
2012-04-30 15:52           ` Koen Kooi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.