* [Qemu-devel] [PATCH 1.1] kvm: Fix wrong size in memset
@ 2012-05-16 5:53 Stefan Weil
2012-05-16 5:55 ` Andreas Färber
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2012-05-16 5:53 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Jan Kiszka, qemu-devel, Stefan Weil
Only the first 4 or 8 bytes were set to 0.
This bug was found by cppcheck.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
hw/kvm/apic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/kvm/apic.c b/hw/kvm/apic.c
index ffe7a52..a0ab503 100644
--- a/hw/kvm/apic.c
+++ b/hw/kvm/apic.c
@@ -29,7 +29,7 @@ void kvm_put_apic_state(DeviceState *d, struct kvm_lapic_state *kapic)
APICCommonState *s = DO_UPCAST(APICCommonState, busdev.qdev, d);
int i;
- memset(kapic, 0, sizeof(kapic));
+ memset(kapic, 0, sizeof(*kapic));
kvm_apic_set_reg(kapic, 0x2, s->id << 24);
kvm_apic_set_reg(kapic, 0x8, s->tpr);
kvm_apic_set_reg(kapic, 0xd, s->log_dest << 24);
--
1.7.10
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH 1.1] kvm: Fix wrong size in memset
2012-05-16 5:53 [Qemu-devel] [PATCH 1.1] kvm: Fix wrong size in memset Stefan Weil
@ 2012-05-16 5:55 ` Andreas Färber
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Färber @ 2012-05-16 5:55 UTC (permalink / raw)
To: Stefan Weil; +Cc: Jan Kiszka, Anthony Liguori, qemu-devel
Am 16.05.2012 07:53, schrieb Stefan Weil:
> Only the first 4 or 8 bytes were set to 0.
> This bug was found by cppcheck.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
This was already posted by Jim.
/-F
> ---
> hw/kvm/apic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/kvm/apic.c b/hw/kvm/apic.c
> index ffe7a52..a0ab503 100644
> --- a/hw/kvm/apic.c
> +++ b/hw/kvm/apic.c
> @@ -29,7 +29,7 @@ void kvm_put_apic_state(DeviceState *d, struct kvm_lapic_state *kapic)
> APICCommonState *s = DO_UPCAST(APICCommonState, busdev.qdev, d);
> int i;
>
> - memset(kapic, 0, sizeof(kapic));
> + memset(kapic, 0, sizeof(*kapic));
> kvm_apic_set_reg(kapic, 0x2, s->id << 24);
> kvm_apic_set_reg(kapic, 0x8, s->tpr);
> kvm_apic_set_reg(kapic, 0xd, s->log_dest << 24);
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-16 5:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-16 5:53 [Qemu-devel] [PATCH 1.1] kvm: Fix wrong size in memset Stefan Weil
2012-05-16 5:55 ` Andreas Färber
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.