All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Arend van Spriel" <arend@broadcom.com>
To: "Hauke Mehrtens" <hauke@hauke-m.de>
Cc: "Florian Fainelli" <florian@openwrt.org>,
	linville@tuxdriver.com, zajec5@gmail.com,
	b43-dev@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/8] bcma: Fix for 4329b0 bad LPOM is detection
Date: Wed, 6 Jun 2012 13:45:30 +0200	[thread overview]
Message-ID: <4FCF42DA.7080509@broadcom.com> (raw)
In-Reply-To: <4FCF17DA.4010100@hauke-m.de>

On 06/06/2012 10:42 AM, Hauke Mehrtens wrote:
> On 06/06/2012 10:08 AM, Florian Fainelli wrote:
>> Hi Hauke,
>>
>> On Tuesday 05 June 2012 23:55:02 Hauke Mehrtens wrote:
>>>  
>>> -	if (cc->core->id.id == 0x4329 && cc->core->id.rev == 2)
>>> +	if (bus->chipinfo.id == 0x4329 && bus->chipinfo.rev == 2)
>>>  		pr_err("Fix for 4329b0 bad LPOM state not implemented!\n");
>>
>> Does not that deserve a new define to be in line with your previous patch?
>> --
>> Florian
> 
> Probably we can remove this completely. The BCM4329 is a fullmac chip
> mostly used in phones and this part is done in the firmware.

That is correct. PMU initialization is done in the firmware for a
fullmac device.

Gr. AvS


WARNING: multiple messages have this Message-ID (diff)
From: Arend van Spriel <arend@broadcom.com>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: Florian Fainelli <florian@openwrt.org>,
	linville@tuxdriver.com, zajec5@gmail.com,
	b43-dev@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: [PATCH 3/8] bcma: Fix for 4329b0 bad LPOM is detection
Date: Wed, 6 Jun 2012 13:45:30 +0200	[thread overview]
Message-ID: <4FCF42DA.7080509@broadcom.com> (raw)
In-Reply-To: <4FCF17DA.4010100@hauke-m.de>

On 06/06/2012 10:42 AM, Hauke Mehrtens wrote:
> On 06/06/2012 10:08 AM, Florian Fainelli wrote:
>> Hi Hauke,
>>
>> On Tuesday 05 June 2012 23:55:02 Hauke Mehrtens wrote:
>>>  
>>> -	if (cc->core->id.id == 0x4329 && cc->core->id.rev == 2)
>>> +	if (bus->chipinfo.id == 0x4329 && bus->chipinfo.rev == 2)
>>>  		pr_err("Fix for 4329b0 bad LPOM state not implemented!\n");
>>
>> Does not that deserve a new define to be in line with your previous patch?
>> --
>> Florian
> 
> Probably we can remove this completely. The BCM4329 is a fullmac chip
> mostly used in phones and this part is done in the firmware.

That is correct. PMU initialization is done in the firmware for a
fullmac device.

Gr. AvS

  reply	other threads:[~2012-06-06 11:45 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-05 21:54 [PATCH 0/8] bcma misc updates Hauke Mehrtens
2012-06-05 21:55 ` [PATCH 1/8] bcma: extend workaround for bcm4331 Hauke Mehrtens
2012-06-05 21:55 ` [PATCH 2/8] bcma: add constants for chip ids Hauke Mehrtens
2012-06-06 11:51   ` Arend van Spriel
2012-06-06 11:51     ` Arend van Spriel
2012-06-05 21:55 ` [PATCH 3/8] bcma: Fix for 4329b0 bad LPOM is detection Hauke Mehrtens
2012-06-06  8:08   ` Florian Fainelli
2012-06-06  8:08     ` Florian Fainelli
2012-06-06  8:42     ` Hauke Mehrtens
2012-06-06  8:42       ` Hauke Mehrtens
2012-06-06 11:45       ` Arend van Spriel [this message]
2012-06-06 11:45         ` Arend van Spriel
2012-06-05 21:55 ` [PATCH 4/8] bcma: add PCI ID for BCM43224 Hauke Mehrtens
2012-06-05 21:55 ` [PATCH 5/8] bcma: complete workaround for BCMA43224 and BCM4313 Hauke Mehrtens
2012-06-05 21:55 ` [PATCH 6/8] bcma: handle SoCs in pmu initialization Hauke Mehrtens
2012-06-06 12:19   ` Florian Fainelli
2012-06-06 12:19     ` Florian Fainelli
2012-06-07 12:59     ` Hauke Mehrtens
2012-06-07 12:59       ` Hauke Mehrtens
2012-06-10 16:54     ` Rafał Miłecki
2012-06-10 16:54       ` Rafał Miłecki
2012-06-10 19:37       ` Hauke Mehrtens
2012-06-10 19:37         ` Hauke Mehrtens
2012-06-28 15:52         ` Rafał Miłecki
2012-06-28 15:52           ` Rafał Miłecki
2012-06-28 18:14           ` Hauke Mehrtens
2012-06-28 18:14             ` Hauke Mehrtens
2012-06-05 21:55 ` [PATCH 7/8] bcma: add bcma_pmu_spuravoid_pllupdate() Hauke Mehrtens
2012-06-10 16:53   ` Rafał Miłecki
2012-06-10 16:53     ` Rafał Miłecki
2012-06-10 19:34     ` Hauke Mehrtens
2012-06-10 19:34       ` Hauke Mehrtens
2012-06-05 21:55 ` [PATCH 8/8] bcma: add mdelay bcma_pmu_resources_init() Hauke Mehrtens
2012-06-29  7:44 ` [PATCH 0/8] bcma misc updates Rafał Miłecki
2012-06-29  7:44   ` Rafał Miłecki
2012-06-29 13:37   ` John W. Linville
2012-06-29 13:37     ` John W. Linville
2012-06-29 16:40   ` Hauke Mehrtens
2012-06-29 16:40     ` Hauke Mehrtens
2012-06-29 19:33     ` Rafał Miłecki
2012-06-29 19:33       ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FCF42DA.7080509@broadcom.com \
    --to=arend@broadcom.com \
    --cc=b43-dev@lists.infradead.org \
    --cc=florian@openwrt.org \
    --cc=hauke@hauke-m.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.