From: Hauke Mehrtens <hauke@hauke-m.de> To: Florian Fainelli <florian@openwrt.org> Cc: linville@tuxdriver.com, zajec5@gmail.com, b43-dev@lists.infradead.org, arend@broadcom.com, linux-wireless@vger.kernel.org Subject: Re: [PATCH 6/8] bcma: handle SoCs in pmu initialization Date: Thu, 07 Jun 2012 14:59:30 +0200 [thread overview] Message-ID: <4FD0A5B2.1090604@hauke-m.de> (raw) In-Reply-To: <2716026.rMfCBzMpF9@flexo> On 06/06/2012 02:19 PM, Florian Fainelli wrote: > Hi Hauke, > > On Tuesday 05 June 2012 23:55:05 Hauke Mehrtens wrote: >> The SoCs do not need any special handling in bcma_pmu_pll_init(), >> bcma_pmu_resources_init(), bcma_pmu_swreg_init() and >> bcma_pmu_workarounds. This patches suppresses some warnings in the log. > > This does not look like it scales very good, how about you turn the pr_err() > into a pr_debug() so that developpers porting bcma on a new chip need to turn > on the appropriate debug knobs to get the message? I would more like to remove this message completely so that the default case does nothing. A developer should be capable of finding this function without any debug message when he wants to add support for a new device. >> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> >> --- >> drivers/bcma/driver_chipcommon_pmu.c | 32 > ++++++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> >> diff --git a/drivers/bcma/driver_chipcommon_pmu.c > b/drivers/bcma/driver_chipcommon_pmu.c >> index 2ebba9c..9bf2dff 100644 >> --- a/drivers/bcma/driver_chipcommon_pmu.c >> +++ b/drivers/bcma/driver_chipcommon_pmu.c >> @@ -63,6 +63,14 @@ static void bcma_pmu_pll_init(struct bcma_drv_cc *cc) >> case BCMA_CHIP_ID_BCM4331: >> case BCMA_CHIP_ID_BCM43224: >> case BCMA_CHIP_ID_BCM43225: >> + case BCMA_CHIP_ID_BCM4716: >> + case BCMA_CHIP_ID_BCM4748: >> + case BCMA_CHIP_ID_BCM47162: >> + case BCMA_CHIP_ID_BCM4749: >> + case BCMA_CHIP_ID_BCM5357: >> + case BCMA_CHIP_ID_BCM5356: >> + case BCMA_CHIP_ID_BCM53572: >> + case BCMA_CHIP_ID_BCM4706: >> break; >> default: >> pr_err("PLL init unknown for device 0x%04X\n", >> @@ -83,6 +91,14 @@ static void bcma_pmu_resources_init(struct bcma_drv_cc > *cc) >> case BCMA_CHIP_ID_BCM4331: >> case BCMA_CHIP_ID_BCM43224: >> case BCMA_CHIP_ID_BCM43225: >> + case BCMA_CHIP_ID_BCM4716: >> + case BCMA_CHIP_ID_BCM4748: >> + case BCMA_CHIP_ID_BCM47162: >> + case BCMA_CHIP_ID_BCM4749: >> + case BCMA_CHIP_ID_BCM5357: >> + case BCMA_CHIP_ID_BCM5356: >> + case BCMA_CHIP_ID_BCM53572: >> + case BCMA_CHIP_ID_BCM4706: >> break; >> default: >> pr_err("PMU resource config unknown for device 0x%04X\n", >> @@ -105,6 +121,14 @@ static void bcma_pmu_swreg_init(struct bcma_drv_cc *cc) >> case BCMA_CHIP_ID_BCM4331: >> case BCMA_CHIP_ID_BCM43224: >> case BCMA_CHIP_ID_BCM43225: >> + case BCMA_CHIP_ID_BCM4716: >> + case BCMA_CHIP_ID_BCM4748: >> + case BCMA_CHIP_ID_BCM47162: >> + case BCMA_CHIP_ID_BCM4749: >> + case BCMA_CHIP_ID_BCM5357: >> + case BCMA_CHIP_ID_BCM5356: >> + case BCMA_CHIP_ID_BCM53572: >> + case BCMA_CHIP_ID_BCM4706: >> break; >> default: >> pr_err("PMU switch/regulators init unknown for device " >> @@ -168,6 +192,14 @@ static void bcma_pmu_workarounds(struct bcma_drv_cc > *cc) >> } >> break; >> case BCMA_CHIP_ID_BCM43225: >> + case BCMA_CHIP_ID_BCM4716: >> + case BCMA_CHIP_ID_BCM4748: >> + case BCMA_CHIP_ID_BCM47162: >> + case BCMA_CHIP_ID_BCM4749: >> + case BCMA_CHIP_ID_BCM5357: >> + case BCMA_CHIP_ID_BCM5356: >> + case BCMA_CHIP_ID_BCM53572: >> + case BCMA_CHIP_ID_BCM4706: >> break; >> default: >> pr_err("Workarounds unknown for device 0x%04X\n", >> -- >> 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Hauke Mehrtens <hauke@hauke-m.de> To: Florian Fainelli <florian@openwrt.org> Cc: linville@tuxdriver.com, zajec5@gmail.com, b43-dev@lists.infradead.org, arend@broadcom.com, linux-wireless@vger.kernel.org Subject: [PATCH 6/8] bcma: handle SoCs in pmu initialization Date: Thu, 07 Jun 2012 14:59:30 +0200 [thread overview] Message-ID: <4FD0A5B2.1090604@hauke-m.de> (raw) In-Reply-To: <2716026.rMfCBzMpF9@flexo> On 06/06/2012 02:19 PM, Florian Fainelli wrote: > Hi Hauke, > > On Tuesday 05 June 2012 23:55:05 Hauke Mehrtens wrote: >> The SoCs do not need any special handling in bcma_pmu_pll_init(), >> bcma_pmu_resources_init(), bcma_pmu_swreg_init() and >> bcma_pmu_workarounds. This patches suppresses some warnings in the log. > > This does not look like it scales very good, how about you turn the pr_err() > into a pr_debug() so that developpers porting bcma on a new chip need to turn > on the appropriate debug knobs to get the message? I would more like to remove this message completely so that the default case does nothing. A developer should be capable of finding this function without any debug message when he wants to add support for a new device. >> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> >> --- >> drivers/bcma/driver_chipcommon_pmu.c | 32 > ++++++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> >> diff --git a/drivers/bcma/driver_chipcommon_pmu.c > b/drivers/bcma/driver_chipcommon_pmu.c >> index 2ebba9c..9bf2dff 100644 >> --- a/drivers/bcma/driver_chipcommon_pmu.c >> +++ b/drivers/bcma/driver_chipcommon_pmu.c >> @@ -63,6 +63,14 @@ static void bcma_pmu_pll_init(struct bcma_drv_cc *cc) >> case BCMA_CHIP_ID_BCM4331: >> case BCMA_CHIP_ID_BCM43224: >> case BCMA_CHIP_ID_BCM43225: >> + case BCMA_CHIP_ID_BCM4716: >> + case BCMA_CHIP_ID_BCM4748: >> + case BCMA_CHIP_ID_BCM47162: >> + case BCMA_CHIP_ID_BCM4749: >> + case BCMA_CHIP_ID_BCM5357: >> + case BCMA_CHIP_ID_BCM5356: >> + case BCMA_CHIP_ID_BCM53572: >> + case BCMA_CHIP_ID_BCM4706: >> break; >> default: >> pr_err("PLL init unknown for device 0x%04X\n", >> @@ -83,6 +91,14 @@ static void bcma_pmu_resources_init(struct bcma_drv_cc > *cc) >> case BCMA_CHIP_ID_BCM4331: >> case BCMA_CHIP_ID_BCM43224: >> case BCMA_CHIP_ID_BCM43225: >> + case BCMA_CHIP_ID_BCM4716: >> + case BCMA_CHIP_ID_BCM4748: >> + case BCMA_CHIP_ID_BCM47162: >> + case BCMA_CHIP_ID_BCM4749: >> + case BCMA_CHIP_ID_BCM5357: >> + case BCMA_CHIP_ID_BCM5356: >> + case BCMA_CHIP_ID_BCM53572: >> + case BCMA_CHIP_ID_BCM4706: >> break; >> default: >> pr_err("PMU resource config unknown for device 0x%04X\n", >> @@ -105,6 +121,14 @@ static void bcma_pmu_swreg_init(struct bcma_drv_cc *cc) >> case BCMA_CHIP_ID_BCM4331: >> case BCMA_CHIP_ID_BCM43224: >> case BCMA_CHIP_ID_BCM43225: >> + case BCMA_CHIP_ID_BCM4716: >> + case BCMA_CHIP_ID_BCM4748: >> + case BCMA_CHIP_ID_BCM47162: >> + case BCMA_CHIP_ID_BCM4749: >> + case BCMA_CHIP_ID_BCM5357: >> + case BCMA_CHIP_ID_BCM5356: >> + case BCMA_CHIP_ID_BCM53572: >> + case BCMA_CHIP_ID_BCM4706: >> break; >> default: >> pr_err("PMU switch/regulators init unknown for device " >> @@ -168,6 +192,14 @@ static void bcma_pmu_workarounds(struct bcma_drv_cc > *cc) >> } >> break; >> case BCMA_CHIP_ID_BCM43225: >> + case BCMA_CHIP_ID_BCM4716: >> + case BCMA_CHIP_ID_BCM4748: >> + case BCMA_CHIP_ID_BCM47162: >> + case BCMA_CHIP_ID_BCM4749: >> + case BCMA_CHIP_ID_BCM5357: >> + case BCMA_CHIP_ID_BCM5356: >> + case BCMA_CHIP_ID_BCM53572: >> + case BCMA_CHIP_ID_BCM4706: >> break; >> default: >> pr_err("Workarounds unknown for device 0x%04X\n", >> -- >> 1.7.9.5
next prev parent reply other threads:[~2012-06-07 12:59 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-06-05 21:54 [PATCH 0/8] bcma misc updates Hauke Mehrtens 2012-06-05 21:55 ` [PATCH 1/8] bcma: extend workaround for bcm4331 Hauke Mehrtens 2012-06-05 21:55 ` [PATCH 2/8] bcma: add constants for chip ids Hauke Mehrtens 2012-06-06 11:51 ` Arend van Spriel 2012-06-06 11:51 ` Arend van Spriel 2012-06-05 21:55 ` [PATCH 3/8] bcma: Fix for 4329b0 bad LPOM is detection Hauke Mehrtens 2012-06-06 8:08 ` Florian Fainelli 2012-06-06 8:08 ` Florian Fainelli 2012-06-06 8:42 ` Hauke Mehrtens 2012-06-06 8:42 ` Hauke Mehrtens 2012-06-06 11:45 ` Arend van Spriel 2012-06-06 11:45 ` Arend van Spriel 2012-06-05 21:55 ` [PATCH 4/8] bcma: add PCI ID for BCM43224 Hauke Mehrtens 2012-06-05 21:55 ` [PATCH 5/8] bcma: complete workaround for BCMA43224 and BCM4313 Hauke Mehrtens 2012-06-05 21:55 ` [PATCH 6/8] bcma: handle SoCs in pmu initialization Hauke Mehrtens 2012-06-06 12:19 ` Florian Fainelli 2012-06-06 12:19 ` Florian Fainelli 2012-06-07 12:59 ` Hauke Mehrtens [this message] 2012-06-07 12:59 ` Hauke Mehrtens 2012-06-10 16:54 ` Rafał Miłecki 2012-06-10 16:54 ` Rafał Miłecki 2012-06-10 19:37 ` Hauke Mehrtens 2012-06-10 19:37 ` Hauke Mehrtens 2012-06-28 15:52 ` Rafał Miłecki 2012-06-28 15:52 ` Rafał Miłecki 2012-06-28 18:14 ` Hauke Mehrtens 2012-06-28 18:14 ` Hauke Mehrtens 2012-06-05 21:55 ` [PATCH 7/8] bcma: add bcma_pmu_spuravoid_pllupdate() Hauke Mehrtens 2012-06-10 16:53 ` Rafał Miłecki 2012-06-10 16:53 ` Rafał Miłecki 2012-06-10 19:34 ` Hauke Mehrtens 2012-06-10 19:34 ` Hauke Mehrtens 2012-06-05 21:55 ` [PATCH 8/8] bcma: add mdelay bcma_pmu_resources_init() Hauke Mehrtens 2012-06-29 7:44 ` [PATCH 0/8] bcma misc updates Rafał Miłecki 2012-06-29 7:44 ` Rafał Miłecki 2012-06-29 13:37 ` John W. Linville 2012-06-29 13:37 ` John W. Linville 2012-06-29 16:40 ` Hauke Mehrtens 2012-06-29 16:40 ` Hauke Mehrtens 2012-06-29 19:33 ` Rafał Miłecki 2012-06-29 19:33 ` Rafał Miłecki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4FD0A5B2.1090604@hauke-m.de \ --to=hauke@hauke-m.de \ --cc=arend@broadcom.com \ --cc=b43-dev@lists.infradead.org \ --cc=florian@openwrt.org \ --cc=linux-wireless@vger.kernel.org \ --cc=linville@tuxdriver.com \ --cc=zajec5@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.