From: Minchan Kim <minchan@kernel.org> To: John Stultz <john.stultz@linaro.org> Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>, Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, KOSAKI Motohiro <kosaki.motohiro@gmail.com>, Johannes Weiner <hannes@cmpxchg.org>, Andrea Arcangeli <aarcange@redhat.com>, Andrew Morton <akpm@linux-foundation.org>, Anton Vorontsov <anton.vorontsov@linaro.org>, Pekka Enberg <penberg@kernel.org>, Wu Fengguang <fengguang.wu@intel.com>, Hugh Dickins <hughd@google.com> Subject: Re: RFC: Easy-Reclaimable LRU list Date: Fri, 22 Jun 2012 15:57:22 +0900 [thread overview] Message-ID: <4FE41752.8050305@kernel.org> (raw) In-Reply-To: <4FE37434.808@linaro.org> Hi John, On 06/22/2012 04:21 AM, John Stultz wrote: > On 06/18/2012 10:49 PM, Minchan Kim wrote: >> Hi everybody! >> >> Recently, there are some efforts to handle system memory pressure. >> >> 1) low memory notification - [1] >> 2) fallocate(VOLATILE) - [2] >> 3) fadvise(NOREUSE) - [3] >> >> For them, I would like to add new LRU list, aka "Ereclaimable" which >> is opposite of "unevictable". >> Reclaimable LRU list includes _easy_ reclaimable pages. >> For example, easy reclaimable pages are following as. >> >> 1. invalidated but remained LRU list. >> 2. pageout pages for reclaim(PG_reclaim pages) >> 3. fadvise(NOREUSE) >> 4. fallocate(VOLATILE) >> >> Their pages shouldn't stir normal LRU list and compaction might not >> migrate them, even. >> Reclaimer can reclaim Ereclaimable pages before normal lru list and >> will avoid unnecessary >> swapout in anon pages in easy-reclaimable LRU list. > > I was hoping there would be further comment on this by more core VM > devs, but so far things have been quiet (is everyone on vacation?). At least, there are no dissent comment until now. Let be a positive. :) > > Overall this seems reasonable for the volatile ranges functionality. > The one down-side being that dealing with the ranges on a per-page basis > can make marking and unmarking larger ranges as volatile fairly > expensive. In my tests with my last patchset, it was over 75x slower > (~1.5ms) marking and umarking a 1meg range when we deactivate and > activate all of the pages, instead of just inserting the volatile range > into an interval tree and purge via the shrinker (~20us). Granted, my > initial approach is somewhat naive, and some pagevec batching has > improved things three-fold (down to ~500us) , but I'm still ~25x slower > when iterating over all the pages. > > There's surely further improvements to be made, but this added cost > worries me, as users are unlikely to generously volunteer up memory to > the kernel as volatile if doing so frequently adds significant overhead. > > This makes me wonder if having something like an early-shrinker which > gets called prior to shrinking the lrus might be a better approach for > volatile ranges. It would still be numa-unaware, but would keep the > overhead very light to both volatile users and non users. How about doing it in background? In your process context, you can schedule your work to workqueue and when work is executed, you can move the pages into lru list you want. Just an idea. > > Even so, I'd be interested in seeing more about your approach, in the > hopes that it might not be as costly as my initial attempt. Do you have > any plans to start prototyping this? I will wait response a few day and if anyone doesn't raise critical problems, will start. But please keep in mind.I guess it's never trivial so you shouldn't depend on my schedule. Thanks. > > thanks > -john > -- Kind regards, Minchan Kim
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org> To: John Stultz <john.stultz@linaro.org> Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>, Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, KOSAKI Motohiro <kosaki.motohiro@gmail.com>, Johannes Weiner <hannes@cmpxchg.org>, Andrea Arcangeli <aarcange@redhat.com>, Andrew Morton <akpm@linux-foundation.org>, Anton Vorontsov <anton.vorontsov@linaro.org>, Pekka Enberg <penberg@kernel.org>, Wu Fengguang <fengguang.wu@intel.com>, Hugh Dickins <hughd@google.com> Subject: Re: RFC: Easy-Reclaimable LRU list Date: Fri, 22 Jun 2012 15:57:22 +0900 [thread overview] Message-ID: <4FE41752.8050305@kernel.org> (raw) In-Reply-To: <4FE37434.808@linaro.org> Hi John, On 06/22/2012 04:21 AM, John Stultz wrote: > On 06/18/2012 10:49 PM, Minchan Kim wrote: >> Hi everybody! >> >> Recently, there are some efforts to handle system memory pressure. >> >> 1) low memory notification - [1] >> 2) fallocate(VOLATILE) - [2] >> 3) fadvise(NOREUSE) - [3] >> >> For them, I would like to add new LRU list, aka "Ereclaimable" which >> is opposite of "unevictable". >> Reclaimable LRU list includes _easy_ reclaimable pages. >> For example, easy reclaimable pages are following as. >> >> 1. invalidated but remained LRU list. >> 2. pageout pages for reclaim(PG_reclaim pages) >> 3. fadvise(NOREUSE) >> 4. fallocate(VOLATILE) >> >> Their pages shouldn't stir normal LRU list and compaction might not >> migrate them, even. >> Reclaimer can reclaim Ereclaimable pages before normal lru list and >> will avoid unnecessary >> swapout in anon pages in easy-reclaimable LRU list. > > I was hoping there would be further comment on this by more core VM > devs, but so far things have been quiet (is everyone on vacation?). At least, there are no dissent comment until now. Let be a positive. :) > > Overall this seems reasonable for the volatile ranges functionality. > The one down-side being that dealing with the ranges on a per-page basis > can make marking and unmarking larger ranges as volatile fairly > expensive. In my tests with my last patchset, it was over 75x slower > (~1.5ms) marking and umarking a 1meg range when we deactivate and > activate all of the pages, instead of just inserting the volatile range > into an interval tree and purge via the shrinker (~20us). Granted, my > initial approach is somewhat naive, and some pagevec batching has > improved things three-fold (down to ~500us) , but I'm still ~25x slower > when iterating over all the pages. > > There's surely further improvements to be made, but this added cost > worries me, as users are unlikely to generously volunteer up memory to > the kernel as volatile if doing so frequently adds significant overhead. > > This makes me wonder if having something like an early-shrinker which > gets called prior to shrinking the lrus might be a better approach for > volatile ranges. It would still be numa-unaware, but would keep the > overhead very light to both volatile users and non users. How about doing it in background? In your process context, you can schedule your work to workqueue and when work is executed, you can move the pages into lru list you want. Just an idea. > > Even so, I'd be interested in seeing more about your approach, in the > hopes that it might not be as costly as my initial attempt. Do you have > any plans to start prototyping this? I will wait response a few day and if anyone doesn't raise critical problems, will start. But please keep in mind.I guess it's never trivial so you shouldn't depend on my schedule. Thanks. > > thanks > -john > -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-22 6:57 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-06-19 5:49 RFC: Easy-Reclaimable LRU list Minchan Kim 2012-06-19 5:49 ` Minchan Kim 2012-06-21 19:21 ` John Stultz 2012-06-21 19:21 ` John Stultz 2012-06-22 6:57 ` Minchan Kim [this message] 2012-06-22 6:57 ` Minchan Kim 2012-06-23 4:45 ` Kamezawa Hiroyuki 2012-06-23 4:45 ` Kamezawa Hiroyuki 2012-06-23 15:53 ` Rik van Riel 2012-06-23 15:53 ` Rik van Riel 2012-06-24 11:09 ` KOSAKI Motohiro 2012-06-24 11:09 ` KOSAKI Motohiro 2012-06-25 0:15 ` Minchan Kim 2012-06-25 0:15 ` Minchan Kim 2012-06-25 8:46 ` Glauber Costa 2012-06-25 8:46 ` Glauber Costa 2012-06-26 0:12 ` Minchan Kim 2012-06-26 0:12 ` Minchan Kim 2012-06-26 8:07 ` Glauber Costa 2012-06-26 8:07 ` Glauber Costa 2012-06-25 10:24 ` Mel Gorman 2012-06-25 10:24 ` Mel Gorman 2012-06-26 0:26 ` Minchan Kim 2012-06-26 0:26 ` Minchan Kim 2012-07-17 16:03 ` Zheng Liu 2012-07-17 16:03 ` Zheng Liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4FE41752.8050305@kernel.org \ --to=minchan@kernel.org \ --cc=aarcange@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=anton.vorontsov@linaro.org \ --cc=fengguang.wu@intel.com \ --cc=hannes@cmpxchg.org \ --cc=hughd@google.com \ --cc=john.stultz@linaro.org \ --cc=kamezawa.hiroyu@jp.fujitsu.com \ --cc=kosaki.motohiro@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=penberg@kernel.org \ --cc=riel@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.